)]}'
{".zuul.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"38deb337246fc9da7338897c53ff010cd6c5356b","unresolved":true,"context_lines":[{"line_number":18,"context_line":"      Eventlet."},{"line_number":19,"context_line":"    vars:"},{"line_number":20,"context_line":"      tox_environment:"},{"line_number":21,"context_line":"        RABBITMQ_LOGS: \"{{ ansible_user_dir }}/zuul-output/logs/rabbitmq.log\""},{"line_number":22,"context_line":"        OSLO_MESSAGING_TEST_EXECUTOR: threading"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- job:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"a3fa8a40_4eb711a6","line":21,"range":{"start_line":21,"start_character":8,"end_line":21,"end_character":21},"updated":"2026-10-29 09:04:17.000000000","message":"(nit) This should be inherited from the base job (because zuul deep-merge options) so may not be needed here.","commit_id":"7c73bc41054719184027c4fa4773a6c51c5501c5"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"beffe5621b9f1d1c9095d2960dcda8491e41e84c","unresolved":false,"context_lines":[{"line_number":18,"context_line":"      Eventlet."},{"line_number":19,"context_line":"    vars:"},{"line_number":20,"context_line":"      tox_environment:"},{"line_number":21,"context_line":"        RABBITMQ_LOGS: \"{{ ansible_user_dir }}/zuul-output/logs/rabbitmq.log\""},{"line_number":22,"context_line":"        OSLO_MESSAGING_TEST_EXECUTOR: threading"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- job:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"0aea45de_21af2d72","line":21,"in_reply_to":"a3fa8a40_4eb711a6","updated":"2026-10-29 09:22:30.000000000","message":"Done in PS4: I dropped it. The parent job\u0027s tox_environment is merged in.","commit_id":"7c73bc41054719184027c4fa4773a6c51c5501c5"}],"oslo_messaging/tests/functional/utils.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"38deb337246fc9da7338897c53ff010cd6c5356b","unresolved":true,"context_lines":[{"line_number":340,"context_line":""},{"line_number":341,"context_line":"        # Some transports need settings beyond their URL. The same file"},{"line_number":342,"context_line":"        # can configure test servers and external fixture processes."},{"line_number":343,"context_line":"        config_file \u003d os.environ.get(\u0027OSLO_MESSAGING_TEST_CONFIG\u0027)"},{"line_number":344,"context_line":"        if config_file:"},{"line_number":345,"context_line":"            conf(args\u003d[], default_config_files\u003d[config_file])"},{"line_number":346,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7bfebaf4_1b9a7e09","line":343,"range":{"start_line":343,"start_character":38,"end_line":343,"end_character":64},"updated":"2026-10-29 09:04:17.000000000","message":"Do you have an example use case of this ? Is it for http driver ?","commit_id":"7c73bc41054719184027c4fa4773a6c51c5501c5"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"beffe5621b9f1d1c9095d2960dcda8491e41e84c","unresolved":false,"context_lines":[{"line_number":340,"context_line":""},{"line_number":341,"context_line":"        # Some transports need settings beyond their URL. The same file"},{"line_number":342,"context_line":"        # can configure test servers and external fixture processes."},{"line_number":343,"context_line":"        config_file \u003d os.environ.get(\u0027OSLO_MESSAGING_TEST_CONFIG\u0027)"},{"line_number":344,"context_line":"        if config_file:"},{"line_number":345,"context_line":"            conf(args\u003d[], default_config_files\u003d[config_file])"},{"line_number":346,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"58487e65_d49d46b6","line":343,"in_reply_to":"7bfebaf4_1b9a7e09","updated":"2026-10-29 09:22:30.000000000","message":"Yes, it\u0027s for the HTTP driver. Its functional scenario (tools/setup-http-scenario.py in https://review.opendev.org/c/openstack/oslo.messaging/+/1007624) writes a config file with the driver\u0027s options, which can\u0027t go in the transport URL. It points both the test process and the fixture processes it starts at that file. PS4\u0027s commit message now says so.","commit_id":"7c73bc41054719184027c4fa4773a6c51c5501c5"}],"oslo_messaging/tests/test_functional_utils.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"38deb337246fc9da7338897c53ff010cd6c5356b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright 2026 GEICO"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":2,"id":"569107e8_dda526b3","line":1,"updated":"2026-10-29 09:04:17.000000000","message":"test target is just an internal utility for testing and is not meant to be consumed externally, and \"tests for tests\" feels over-testing, but I\u0027d be open for feedback from the other cores.","commit_id":"7c73bc41054719184027c4fa4773a6c51c5501c5"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"beffe5621b9f1d1c9095d2960dcda8491e41e84c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2026 GEICO"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":2,"id":"ddeb44ca_3e9b6048","line":1,"in_reply_to":"569107e8_dda526b3","updated":"2026-10-29 09:22:30.000000000","message":"Yeah, this was Claude being a bit over-excited about testing, and I just left it since it seemed fine, but I agree that it is kind of pointless and adds more lines to review. Actually if I had one complaint about changes Claude assists on, it\u0027s that the testing is often a bit overdone, so I may go back through some of my other CRs and see if any of them have stuff that should be simplified too...\nAnyway, the new scenario01-threading job also now covers the executor selection for real.","commit_id":"7c73bc41054719184027c4fa4773a6c51c5501c5"}]}