)]}'
{"oslo/messaging/_drivers/amqpdriver.py":[{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"a4e32ec2958e717fac72e413adea9f9d78ac67fe","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        self._dispatch_callbacks.put(callback)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def _drain_dispatch_callbacks(self):"},{"line_number":135,"context_line":"        while not self._dispatch_callbacks.empty():"},{"line_number":136,"context_line":"            yield self._dispatch_callbacks.get()"},{"line_number":137,"context_line":"            self._dispatch_callbacks.task_done()"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_cb4de79a","line":135,"updated":"2014-07-28 03:56:20.000000000","message":"Whats your expectation on exceptions here?\n\nDo u want to do??\n\ntry:\n    yield self._dispatch_callbacks.get()\nfinally:\n    self._dispatch_callbacks.task_done()\n\nWithout this a callback can cause your queue to become corrupted.","commit_id":"5b1965b97f22cccb5fc7c79a06003dd7d0c3b39d"},{"author":{"_account_id":7763,"name":"Alexei Kornienko","email":"akornienko@mirantis.com","username":"akornienko"},"change_message_id":"7f391f894bc857be6a614094526585442f423ca8","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        self._dispatch_callbacks.put(callback)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def _drain_dispatch_callbacks(self):"},{"line_number":135,"context_line":"        while not self._dispatch_callbacks.empty():"},{"line_number":136,"context_line":"            yield self._dispatch_callbacks.get()"},{"line_number":137,"context_line":"            self._dispatch_callbacks.task_done()"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_c2886124","line":135,"in_reply_to":"baada198_cb4de79a","updated":"2014-07-28 15:56:22.000000000","message":"Agreed. needs to be fixed.","commit_id":"5b1965b97f22cccb5fc7c79a06003dd7d0c3b39d"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"a4e32ec2958e717fac72e413adea9f9d78ac67fe","unresolved":false,"context_lines":[{"line_number":445,"context_line":""},{"line_number":446,"context_line":"        return listener"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    def create_notifications_listener(self, targets_and_priorities):"},{"line_number":449,"context_line":"        conn \u003d self._get_connection(pooled\u003dFalse)"},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"        listener \u003d AMQPListener(self, conn)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_4b59d759","line":448,"updated":"2014-07-28 03:56:20.000000000","message":"This ones name is still weird imho.\n\nIt also seems like it should be named: \u0027create_and_association_notification_listener\u0027 since it does more than just create and it does more than just listen...\n\nMaybe the ``for target, priority`` should be a method on the listener itself.\n\nSomething like listener.associate() or something...","commit_id":"5b1965b97f22cccb5fc7c79a06003dd7d0c3b39d"},{"author":{"_account_id":7763,"name":"Alexei Kornienko","email":"akornienko@mirantis.com","username":"akornienko"},"change_message_id":"7f391f894bc857be6a614094526585442f423ca8","unresolved":false,"context_lines":[{"line_number":445,"context_line":""},{"line_number":446,"context_line":"        return listener"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    def create_notifications_listener(self, targets_and_priorities):"},{"line_number":449,"context_line":"        conn \u003d self._get_connection(pooled\u003dFalse)"},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"        listener \u003d AMQPListener(self, conn)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_c2a141aa","line":448,"in_reply_to":"baada198_4b59d759","updated":"2014-07-28 15:56:22.000000000","message":"IMHO it would be good to have a method in listener. However it\u0027s out of scope of this patch and it requires a separate patch.","commit_id":"5b1965b97f22cccb5fc7c79a06003dd7d0c3b39d"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"ad4f28af3b7becb5efe9972ee6b85eae4ee18b90","unresolved":false,"context_lines":[{"line_number":445,"context_line":""},{"line_number":446,"context_line":"        return listener"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    def create_notifications_listener(self, targets_and_priorities):"},{"line_number":449,"context_line":"        conn \u003d self._get_connection(pooled\u003dFalse)"},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"        listener \u003d AMQPListener(self, conn)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_78de4140","line":448,"in_reply_to":"baada198_c2a141aa","updated":"2014-07-29 03:16:54.000000000","message":"Ok.","commit_id":"5b1965b97f22cccb5fc7c79a06003dd7d0c3b39d"}],"oslo/messaging/_executors/impl_blocking.py":[{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"a4e32ec2958e717fac72e413adea9f9d78ac67fe","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    def __init__(self, conf, callback):"},{"line_number":27,"context_line":"        self._callback \u003d callback"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def __call__(self, *args, **kwargs):"},{"line_number":30,"context_line":"        self._callback(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_2b2583c1","line":29,"updated":"2014-07-28 03:56:20.000000000","message":"I\u0027m not sure I like using __call__\n\nWhy not use names that are similar to the python executor base classes that already exist...\n\nAka, submit() or something else that actually tells more about what the method does, __call__ has none of these properties, and it shows me very little information on what the actually method does.","commit_id":"5b1965b97f22cccb5fc7c79a06003dd7d0c3b39d"}],"oslo/messaging/_executors/impl_eventlet.py":[{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"a4e32ec2958e717fac72e413adea9f9d78ac67fe","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        self._callback \u003d callback"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def __call__(self, *args, **kwargs):"},{"line_number":38,"context_line":"        self._greenpool.spawn(self._callback, *args, **kwargs)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def wait(self):"},{"line_number":41,"context_line":"        self._greenpool.waitall()"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_eb0e2b3c","line":38,"updated":"2014-07-28 03:56:20.000000000","message":"I\u0027d prefer something more meaningful than __call__ as the method name here.","commit_id":"5b1965b97f22cccb5fc7c79a06003dd7d0c3b39d"},{"author":{"_account_id":7763,"name":"Alexei Kornienko","email":"akornienko@mirantis.com","username":"akornienko"},"change_message_id":"7f391f894bc857be6a614094526585442f423ca8","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        self._callback \u003d callback"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def __call__(self, *args, **kwargs):"},{"line_number":38,"context_line":"        self._greenpool.spawn(self._callback, *args, **kwargs)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def wait(self):"},{"line_number":41,"context_line":"        self._greenpool.waitall()"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_a22b6d7a","line":38,"in_reply_to":"baada198_eb0e2b3c","updated":"2014-07-28 15:56:22.000000000","message":"Please see my comment in dispatcher. Names should be the same for this 2 classes (to enable using executor as a decorator)","commit_id":"5b1965b97f22cccb5fc7c79a06003dd7d0c3b39d"}],"oslo/messaging/notify/dispatcher.py":[{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"a4e32ec2958e717fac72e413adea9f9d78ac67fe","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                                                         priorities))"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def __call__(self, incoming):"},{"line_number":63,"context_line":"        result_wrapper \u003d []"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        result_wrapper.append(self._dispatch_and_handle_error(incoming))"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_b602d606","line":63,"updated":"2014-07-28 03:56:20.000000000","message":"Thanks, I wonder this can be also better named then using __call__\n\nSomething with more meaning...","commit_id":"5b1965b97f22cccb5fc7c79a06003dd7d0c3b39d"},{"author":{"_account_id":7763,"name":"Alexei Kornienko","email":"akornienko@mirantis.com","username":"akornienko"},"change_message_id":"7f391f894bc857be6a614094526585442f423ca8","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                                                         priorities))"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def __call__(self, incoming):"},{"line_number":63,"context_line":"        result_wrapper \u003d []"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        result_wrapper.append(self._dispatch_and_handle_error(incoming))"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_ff0ede3b","line":63,"in_reply_to":"baada198_b602d606","updated":"2014-07-28 15:56:22.000000000","message":"IMHO it better to use call. This allows us to replace dispatcher with a simple function for some cases:\n\ndef dispatch(message):\n    .... \n\nserver \u003d Server(dispatcher)\n\nSo choosing another name will make this feature impossible. What do you think?","commit_id":"5b1965b97f22cccb5fc7c79a06003dd7d0c3b39d"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"ad4f28af3b7becb5efe9972ee6b85eae4ee18b90","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                                                         priorities))"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def __call__(self, incoming):"},{"line_number":63,"context_line":"        result_wrapper \u003d []"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        result_wrapper.append(self._dispatch_and_handle_error(incoming))"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_f86ed163","line":63,"in_reply_to":"baada198_ff0ede3b","updated":"2014-07-29 03:16:54.000000000","message":"I\u0027m personally a fan of using meaningful name and handling the case where we want to use a simple function (a case that doesn\u0027t exist at the moment) in a different manner. Code is meant to be read by humans, not by machines, so imho meaningful names are more important.","commit_id":"5b1965b97f22cccb5fc7c79a06003dd7d0c3b39d"}],"oslo/messaging/rpc/server.py":[{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"a4e32ec2958e717fac72e413adea9f9d78ac67fe","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    mgr \u003d driver.DriverManager(\u0027oslo.messaging.executors\u0027, executor)"},{"line_number":126,"context_line":"    dispatcher \u003d mgr.driver(transport.conf, dispatcher)"},{"line_number":127,"context_line":"    start_thread \u003d executor is not \u0027blocking\u0027"},{"line_number":128,"context_line":"    return msg_server.MessageHandlingServer(transport, target,"},{"line_number":129,"context_line":"                                            dispatcher, start_thread)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_3635e6da","line":128,"updated":"2014-07-28 03:56:20.000000000","message":"This needs work, starting a thread should be a property of the executor imho; I\u0027m not sure why it needs to be a decision made right here.","commit_id":"5b1965b97f22cccb5fc7c79a06003dd7d0c3b39d"},{"author":{"_account_id":7763,"name":"Alexei Kornienko","email":"akornienko@mirantis.com","username":"akornienko"},"change_message_id":"7f391f894bc857be6a614094526585442f423ca8","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    mgr \u003d driver.DriverManager(\u0027oslo.messaging.executors\u0027, executor)"},{"line_number":126,"context_line":"    dispatcher \u003d mgr.driver(transport.conf, dispatcher)"},{"line_number":127,"context_line":"    start_thread \u003d executor is not \u0027blocking\u0027"},{"line_number":128,"context_line":"    return msg_server.MessageHandlingServer(transport, target,"},{"line_number":129,"context_line":"                                            dispatcher, start_thread)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_42e7f111","line":128,"in_reply_to":"baada198_3635e6da","updated":"2014-07-28 15:56:22.000000000","message":"My thoughts were that server\u0027s responsibility is receiving messages, Executor\u0027s responsibility is to provide a additional features to dispatcher. So threads for executor and thread for the server serve for different purpose. It\u0027s defined here since it\u0027s a hack for backwards compatibility since server behaviour was different depending on executor. In the future we\u0027ll define in a spec how server should work with threads.","commit_id":"5b1965b97f22cccb5fc7c79a06003dd7d0c3b39d"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"4ca97cae44281733424969d66606dca0097b0304","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    mgr \u003d driver.DriverManager(\u0027oslo.messaging.executors\u0027, executor)"},{"line_number":126,"context_line":"    dispatcher \u003d mgr.driver(transport.conf, dispatcher)"},{"line_number":127,"context_line":"    start_thread \u003d executor is not \u0027blocking\u0027"},{"line_number":128,"context_line":"    return msg_server.MessageHandlingServer(transport, target,"},{"line_number":129,"context_line":"                                            dispatcher, start_thread)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_9ed85d82","line":128,"in_reply_to":"baada198_42e7f111","updated":"2014-07-29 04:23:09.000000000","message":"Ok.","commit_id":"5b1965b97f22cccb5fc7c79a06003dd7d0c3b39d"}]}
