)]}'
{"tests/drivers/test_impl_qpid.py":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"a53de68406b7edd6de0726eb35c3572ddef3a523","unresolved":false,"context_lines":[{"line_number":21,"context_line":"import mock"},{"line_number":22,"context_line":"try:"},{"line_number":23,"context_line":"    import qpid"},{"line_number":24,"context_line":"except ImportError:"},{"line_number":25,"context_line":"    raise unittest.SkipTest(\"qpid not available\")"},{"line_number":26,"context_line":"from six.moves import _thread"},{"line_number":27,"context_line":"import testscenarios"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_ba9b2916","line":24,"updated":"2014-08-06 20:37:36.000000000","message":"I really don\u0027t like this.  Having tests skipped this way has led to bugs creeping into the driver in the past because if qpid doesn\u0027t get installed the tests are silently skipped.  Is this because qpid isn\u0027t py3 compatible?","commit_id":"b9d47c7cc82bff051cef59dfdccf79393586e0db"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"335ad3141f31d667f6e222020db43a11d2351b07","unresolved":false,"context_lines":[{"line_number":21,"context_line":"import mock"},{"line_number":22,"context_line":"try:"},{"line_number":23,"context_line":"    import qpid"},{"line_number":24,"context_line":"except ImportError:"},{"line_number":25,"context_line":"    raise unittest.SkipTest(\"qpid not available\")"},{"line_number":26,"context_line":"from six.moves import _thread"},{"line_number":27,"context_line":"import testscenarios"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_480152b4","line":24,"in_reply_to":"baada198_ba9b2916","updated":"2014-08-07 12:04:47.000000000","message":"Yes, that\u0027s why. I don\u0027t see any other solution for now.","commit_id":"b9d47c7cc82bff051cef59dfdccf79393586e0db"}],"tests/test_opts.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"575482f44cf6955abca76776495bd5aeecb1b52f","unresolved":false,"context_lines":[{"line_number":19,"context_line":"try:"},{"line_number":20,"context_line":"    from oslo.messaging import opts"},{"line_number":21,"context_line":"except ImportError:"},{"line_number":22,"context_line":"    raise unittest.SkipTest"},{"line_number":23,"context_line":"from tests import utils as test_utils"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_1bbdedb1","line":22,"updated":"2014-07-23 13:48:17.000000000","message":"out of curiosity... why would this have an issue importing?","commit_id":"eba4ff97fd097b40c88e137bc499ffc294f11bcb"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"b375ac034b44f3cee5833e708ac2c0cc84e67ee4","unresolved":false,"context_lines":[{"line_number":19,"context_line":"try:"},{"line_number":20,"context_line":"    from oslo.messaging import opts"},{"line_number":21,"context_line":"except ImportError:"},{"line_number":22,"context_line":"    raise unittest.SkipTest"},{"line_number":23,"context_line":"from tests import utils as test_utils"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_c80d3f42","line":22,"in_reply_to":"baada198_1bbdedb1","updated":"2014-07-24 14:18:44.000000000","message":"Because it\u0027s not Python 3 compatible and therefore qpid is not listed in test-requirements-py3.txt. So this is going to fail :)","commit_id":"eba4ff97fd097b40c88e137bc499ffc294f11bcb"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"e09ad548f06ec324d3d01dee9f0e125af156a649","unresolved":false,"context_lines":[{"line_number":19,"context_line":"try:"},{"line_number":20,"context_line":"    from oslo.messaging import opts"},{"line_number":21,"context_line":"except ImportError:"},{"line_number":22,"context_line":"    raise unittest.SkipTest"},{"line_number":23,"context_line":"from tests import utils as test_utils"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_353fd5e0","line":22,"in_reply_to":"baada198_55d1a9ca","updated":"2014-08-01 13:17:16.000000000","message":"Done","commit_id":"eba4ff97fd097b40c88e137bc499ffc294f11bcb"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"d1ff7829bd3a2ea5bcb300e86cfd2418051f9b59","unresolved":false,"context_lines":[{"line_number":19,"context_line":"try:"},{"line_number":20,"context_line":"    from oslo.messaging import opts"},{"line_number":21,"context_line":"except ImportError:"},{"line_number":22,"context_line":"    raise unittest.SkipTest"},{"line_number":23,"context_line":"from tests import utils as test_utils"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_55d1a9ca","line":22,"in_reply_to":"baada198_c80d3f42","updated":"2014-08-01 13:13:48.000000000","message":"Can we check against six.PY3 to skip the file, to ensure test is never skipped in python2 ?","commit_id":"eba4ff97fd097b40c88e137bc499ffc294f11bcb"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"a53de68406b7edd6de0726eb35c3572ddef3a523","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"try:"},{"line_number":20,"context_line":"    from oslo.messaging import opts"},{"line_number":21,"context_line":"except ImportError:"},{"line_number":22,"context_line":"    import six"},{"line_number":23,"context_line":"    if six.PY3:"},{"line_number":24,"context_line":"        raise unittest.SkipTest"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_9a174553","line":21,"updated":"2014-08-06 20:37:36.000000000","message":"Oh, ick. :-(\n\nSo impl_qpid can\u0027t even be imported in py3?  It looks like it should work, we\u0027re using try_import for the qpid imports so even if they fail the import won\u0027t.  The code just won\u0027t work, right?","commit_id":"b9d47c7cc82bff051cef59dfdccf79393586e0db"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"335ad3141f31d667f6e222020db43a11d2351b07","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"try:"},{"line_number":20,"context_line":"    from oslo.messaging import opts"},{"line_number":21,"context_line":"except ImportError:"},{"line_number":22,"context_line":"    import six"},{"line_number":23,"context_line":"    if six.PY3:"},{"line_number":24,"context_line":"        raise unittest.SkipTest"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_48287236","line":21,"in_reply_to":"baada198_9a174553","updated":"2014-08-07 12:04:47.000000000","message":"The problem here is zmq/eventlet\n\n\u003e\u003e\u003e import oslo.messaging.opts\nTraceback (most recent call last):\n  File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\n  File \"/Users/jd/Source/oslo.messaging/.tox/py34/lib/python3.4/site-packages/oslo/messaging/opts.py\", line 26, in \u003cmodule\u003e\n    from oslo.messaging._drivers import impl_zmq\n  File \"/Users/jd/Source/oslo.messaging/.tox/py34/lib/python3.4/site-packages/oslo/messaging/_drivers/impl_zmq.py\", line 26, in \u003cmodule\u003e\n    import eventlet\nImportError: No module named \u0027eventlet\u0027","commit_id":"b9d47c7cc82bff051cef59dfdccf79393586e0db"}],"tox.ini":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"a53de68406b7edd6de0726eb35c3572ddef3a523","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"envlist \u003d py26,py27,py33,pep8"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"[testenv]"},{"line_number":5,"context_line":"setenv \u003d"}],"source_content_type":"text/x-properties","patch_set":4,"id":"baada198_ba408960","line":2,"updated":"2014-08-06 20:37:36.000000000","message":"py33 needs to come before the py2x ones.  Otherwise one of the tools (testr?) generates a db in a format the py3 version can\u0027t read.","commit_id":"b9d47c7cc82bff051cef59dfdccf79393586e0db"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"335ad3141f31d667f6e222020db43a11d2351b07","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"envlist \u003d py26,py27,py33,pep8"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"[testenv]"},{"line_number":5,"context_line":"setenv \u003d"}],"source_content_type":"text/x-properties","patch_set":4,"id":"baada198_08683a87","line":2,"in_reply_to":"baada198_ba408960","updated":"2014-08-07 12:04:47.000000000","message":"Done","commit_id":"b9d47c7cc82bff051cef59dfdccf79393586e0db"}]}