)]}'
{"oslo/messaging/rpc/server.py":[{"author":{"_account_id":7763,"name":"Alexei Kornienko","email":"akornienko@mirantis.com","username":"akornienko"},"change_message_id":"7de2c3a54c09d1059fda813157877cfb65311e59","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        target \u003d messaging.Target(namespace\u003d\u0027control\u0027,"},{"line_number":51,"context_line":"                                  version\u003d\u00272.0\u0027)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        def __init__(self, server):"},{"line_number":54,"context_line":"            self.server \u003d server"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_99fe2c05","line":52,"updated":"2014-07-24 19:36:20.000000000","message":"server is expected here. Cause of this fix is not valid and I guess example should be rewritten to remove stop() method and need for server reference. Or it can be set via a setter and removed from __init__","commit_id":"a2e32931b683721d676ba6f22072b0a38d031a32"},{"author":{"_account_id":7763,"name":"Alexei Kornienko","email":"akornienko@mirantis.com","username":"akornienko"},"change_message_id":"feb742e7c506ee15e45937c4b837e79df8caad7a","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        target \u003d messaging.Target(namespace\u003d\u0027control\u0027,"},{"line_number":51,"context_line":"                                  version\u003d\u00272.0\u0027)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        def __init__(self, server):"},{"line_number":54,"context_line":"            self.server \u003d server"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_00637cb1","line":52,"in_reply_to":"baada198_20a160f7","updated":"2014-07-24 21:13:37.000000000","message":"I don\u0027t really understand how this script can run without passing something to __init__ - it requires 2 arguments. You could at least pass None instead of server object.","commit_id":"a2e32931b683721d676ba6f22072b0a38d031a32"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"ca5cb8c0f3f29849f02771e8bf8e95c635492c04","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        target \u003d messaging.Target(namespace\u003d\u0027control\u0027,"},{"line_number":51,"context_line":"                                  version\u003d\u00272.0\u0027)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        def __init__(self, server):"},{"line_number":54,"context_line":"            self.server \u003d server"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_20a160f7","line":52,"in_reply_to":"baada198_99fe2c05","updated":"2014-07-24 21:07:13.000000000","message":"Thanks for the review and comment. Unfortunately I\u0027m not sure I\u0027m best placed to be the one to fix this demo code. I just happened to try it and had the experience that the script failed to run with the \u0027self\u0027 typo, but doesn\u0027t without it. That needs to be fixed no matter what, but the actual usefulness of the script may need to be a different patchset, prompted by a bug report perhaps?","commit_id":"a2e32931b683721d676ba6f22072b0a38d031a32"}]}