)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"98a8d1755968efb06652384ea84bea505ad52b5d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Should not send replies for cast messages"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This stupid but powerful fix allows server to process 10 times more!!!"},{"line_number":10,"context_line":"cast messages."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I913bdf58aa258e355c5eb14fe3623b10b2876f65"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"baada198_7d8afa1a","line":10,"updated":"2014-08-11 07:41:40.000000000","message":"Some more useful context would be useful here - like explaining that cast messages will not contain a msg_id  and we\u0027re currently sending messages to the reply_q with empty msg_id\n\nI also don\u0027t find \"10 times more!!!\" to be particularly useful information.","commit_id":"849466615e7f3f4a1309d1c3f7d8987e04a5a53e"}],"oslo/messaging/_drivers/amqpdriver.py":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"eeb0ca3d9bf388b6d2f87016b40c003067570eed","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def reply(self, reply\u003dNone, failure\u003dNone, log_failure\u003dTrue):"},{"line_number":67,"context_line":"        if not self.msg_id:"},{"line_number":68,"context_line":"            return  # Message is a cast message so no need to send reply"},{"line_number":69,"context_line":"        with self.listener.driver._get_connection() as conn:"},{"line_number":70,"context_line":"            self._send_reply(conn, reply, failure, log_failure\u003dlog_failure)"},{"line_number":71,"context_line":"            self._send_reply(conn, ending\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_b83d952e","line":68,"updated":"2014-07-25 10:44:12.000000000","message":"Can you change to the format:\n\n# NOTE (Alexei_987):  ....\n\nAlso the driver don\u0027t know what is a cast, the message need to be more generic","commit_id":"ec89c0ede1aec2bd611441e1ba239107e8baa945"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"1ae4991e16483565db0f5c4776eeae2bdcecf371","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def reply(self, reply\u003dNone, failure\u003dNone, log_failure\u003dTrue):"},{"line_number":67,"context_line":"        if not self.msg_id:"},{"line_number":68,"context_line":"            return  # NOTE(Alexei_987) not sending reply"},{"line_number":69,"context_line":"        with self.listener.driver._get_connection() as conn:"},{"line_number":70,"context_line":"            self._send_reply(conn, reply, failure, log_failure\u003dlog_failure)"},{"line_number":71,"context_line":"            self._send_reply(conn, ending\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_6d9ff651","line":68,"updated":"2014-08-07 21:14:21.000000000","message":"Nit: This comment by itself is kind of stating the obvious.  Something like \"Not replying if the sender isn\u0027t waiting for a reply\" would make the \"why\" clear.","commit_id":"849466615e7f3f4a1309d1c3f7d8987e04a5a53e"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"98a8d1755968efb06652384ea84bea505ad52b5d","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def reply(self, reply\u003dNone, failure\u003dNone, log_failure\u003dTrue):"},{"line_number":67,"context_line":"        if not self.msg_id:"},{"line_number":68,"context_line":"            return  # NOTE(Alexei_987) not sending reply"},{"line_number":69,"context_line":"        with self.listener.driver._get_connection() as conn:"},{"line_number":70,"context_line":"            self._send_reply(conn, reply, failure, log_failure\u003dlog_failure)"},{"line_number":71,"context_line":"            self._send_reply(conn, ending\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_dd1ce616","line":68,"in_reply_to":"baada198_6d9ff651","updated":"2014-08-11 07:41:40.000000000","message":"Yeah, agree","commit_id":"849466615e7f3f4a1309d1c3f7d8987e04a5a53e"}]}
