)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"ee8fc5319d692172a404c65ee46e824b4ed530e0","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Declare DirectPublisher exchanges with passive\u003dTrue"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If rabbit dies, the consumer can be disconnected before the publisher"},{"line_number":10,"context_line":"sends, and if the consumer hasn\u0027t delared the queue, the publisher\u0027s"},{"line_number":11,"context_line":"will send a message to an exchange that\u0027s not bound to a queue, and"},{"line_number":12,"context_line":"the message wll be lost.  Setting passive\u003dTrue will cause the"},{"line_number":13,"context_line":"publisher to fail and retry if the consumer hasn\u0027t declared the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"fa98f980_9447da4a","line":10,"updated":"2014-09-02 15:48:56.000000000","message":"declared?","commit_id":"0a68bcad0bb1dd6b5d2b515b471e868e353e72fc"},{"author":{"_account_id":8922,"name":"haruka tanizawa","email":"h-tanizawa@intellilink.co.jp","username":"h-tanizawa"},"change_message_id":"58320f5cc62cf9bd3cece1fffe674e905a75439c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"If rabbit dies, the consumer can be disconnected before the publisher"},{"line_number":10,"context_line":"sends, and if the consumer hasn\u0027t delared the queue, the publisher\u0027s"},{"line_number":11,"context_line":"will send a message to an exchange that\u0027s not bound to a queue, and"},{"line_number":12,"context_line":"the message wll be lost.  Setting passive\u003dTrue will cause the"},{"line_number":13,"context_line":"publisher to fail and retry if the consumer hasn\u0027t declared the"},{"line_number":14,"context_line":"receiving queue yet."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"fa98f980_95c5898f","line":12,"updated":"2014-09-16 08:14:50.000000000","message":"wll -\u003e will ?","commit_id":"0a68bcad0bb1dd6b5d2b515b471e868e353e72fc"},{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"cfd646670f820f82bcee14486ee077440d485a65","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Declare DirectPublisher exchanges with passive\u003dTrue"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If rabbit dies, the consumer can be disconnected before the publisher"},{"line_number":10,"context_line":"sends, and if the consumer hasn\u0027t delared the queue, the publisher\u0027s"},{"line_number":11,"context_line":"will send a message to an exchange that\u0027s not bound to a queue, and"},{"line_number":12,"context_line":"the message wll be lost.  Setting passive\u003dTrue will cause the"},{"line_number":13,"context_line":"publisher to fail and retry if the consumer hasn\u0027t declared the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"1a930d6b_9e3b40d0","line":10,"updated":"2015-01-26 13:43:53.000000000","message":"s/delared/declared","commit_id":"1d5c64bbd4fe1d9ad12da5f26d7bf62f41434732"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"2793d6a9c5110533880bb6ad212e6dd0cf326795","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Declare DirectPublisher exchanges with passive\u003dTrue"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If rabbit dies, the consumer can be disconnected before the publisher"},{"line_number":10,"context_line":"sends, and if the consumer hasn\u0027t delared the queue, the publisher\u0027s"},{"line_number":11,"context_line":"will send a message to an exchange that\u0027s not bound to a queue, and"},{"line_number":12,"context_line":"the message wll be lost.  Setting passive\u003dTrue will cause the"},{"line_number":13,"context_line":"publisher to fail and retry if the consumer hasn\u0027t declared the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"1a930d6b_79df65d6","line":10,"in_reply_to":"1a930d6b_9e3b40d0","updated":"2015-01-27 10:06:48.000000000","message":"Done","commit_id":"1d5c64bbd4fe1d9ad12da5f26d7bf62f41434732"}],"oslo_messaging/_drivers/common.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"9b6266ca9da5134b95d3aa833ca48570fefaa3be","unresolved":false,"context_lines":[{"line_number":351,"context_line":""},{"line_number":352,"context_line":"        left \u003d self._ends_at - time.time()"},{"line_number":353,"context_line":"        if left \u003c\u003d 0:"},{"line_number":354,"context_line":"            timeout_callback(*args, **kwargs)"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"        return left if maximum is None else min(left, maximum)"}],"source_content_type":"text/x-python","patch_set":19,"id":"1a930d6b_669a826f","line":354,"updated":"2015-01-26 17:53:16.000000000","message":"as Andrea pointed out. this could end up being None...","commit_id":"1d5c64bbd4fe1d9ad12da5f26d7bf62f41434732"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"2793d6a9c5110533880bb6ad212e6dd0cf326795","unresolved":false,"context_lines":[{"line_number":351,"context_line":""},{"line_number":352,"context_line":"        left \u003d self._ends_at - time.time()"},{"line_number":353,"context_line":"        if left \u003c\u003d 0:"},{"line_number":354,"context_line":"            timeout_callback(*args, **kwargs)"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"        return left if maximum is None else min(left, maximum)"}],"source_content_type":"text/x-python","patch_set":19,"id":"1a930d6b_99f1716d","line":354,"in_reply_to":"1a930d6b_669a826f","updated":"2015-01-27 10:06:48.000000000","message":"Done","commit_id":"1d5c64bbd4fe1d9ad12da5f26d7bf62f41434732"}],"oslo_messaging/_drivers/impl_rabbit.py":[{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"cfd646670f820f82bcee14486ee077440d485a65","unresolved":false,"context_lines":[{"line_number":794,"context_line":"            except self.connection.channel_errors as exc:"},{"line_number":795,"context_line":"                # NOTE(noelbk/sileht):"},{"line_number":796,"context_line":"                # If rabbit dies, the consumer can be disconnected before the"},{"line_number":797,"context_line":"                # publisher sends, and if the consumer hasn\u0027t delared the"},{"line_number":798,"context_line":"                # queue, the publisher\u0027s will send a message to an exchange"},{"line_number":799,"context_line":"                # that\u0027s not bound to a queue, and the message wll be lost."},{"line_number":800,"context_line":"                # So we set passive\u003dTrue to the publisher exchange and catch"}],"source_content_type":"text/x-python","patch_set":19,"id":"1a930d6b_1e7670a4","line":797,"updated":"2015-01-26 13:43:53.000000000","message":"s/delared/declared","commit_id":"1d5c64bbd4fe1d9ad12da5f26d7bf62f41434732"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"2793d6a9c5110533880bb6ad212e6dd0cf326795","unresolved":false,"context_lines":[{"line_number":794,"context_line":"            except self.connection.channel_errors as exc:"},{"line_number":795,"context_line":"                # NOTE(noelbk/sileht):"},{"line_number":796,"context_line":"                # If rabbit dies, the consumer can be disconnected before the"},{"line_number":797,"context_line":"                # publisher sends, and if the consumer hasn\u0027t delared the"},{"line_number":798,"context_line":"                # queue, the publisher\u0027s will send a message to an exchange"},{"line_number":799,"context_line":"                # that\u0027s not bound to a queue, and the message wll be lost."},{"line_number":800,"context_line":"                # So we set passive\u003dTrue to the publisher exchange and catch"}],"source_content_type":"text/x-python","patch_set":19,"id":"1a930d6b_b488f471","line":797,"in_reply_to":"1a930d6b_1e7670a4","updated":"2015-01-27 10:06:48.000000000","message":"Done","commit_id":"1d5c64bbd4fe1d9ad12da5f26d7bf62f41434732"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"1a6766b9d29323719862f502c60f4c5fc5dc7912","unresolved":false,"context_lines":[{"line_number":800,"context_line":"                # So we set passive\u003dTrue to the publisher exchange and catch"},{"line_number":801,"context_line":"                # the 404 kombu ChannelError and retry until the exchange"},{"line_number":802,"context_line":"                # appears"},{"line_number":803,"context_line":"                if exc.code \u003d\u003d 404 and timer.check_return() \u003e 0:"},{"line_number":804,"context_line":"                    LOG.info(_LI(\"The exchange to reply to %s doesn\u0027t \""},{"line_number":805,"context_line":"                                 \"exist yet, retrying...\") % msg_id)"},{"line_number":806,"context_line":"                    time.sleep(1)"}],"source_content_type":"text/x-python","patch_set":19,"id":"1a930d6b_00d0c61d","line":803,"updated":"2015-01-26 17:01:08.000000000","message":"iiuc, check_return requires a callback parameter... i take it we need to fix test case\n\nhttps://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/_drivers/common.py#L344-L356","commit_id":"1d5c64bbd4fe1d9ad12da5f26d7bf62f41434732"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"df34b5b561e287b5bdff56ef635f86b0bbc0785d","unresolved":false,"context_lines":[{"line_number":800,"context_line":"                # So we set passive\u003dTrue to the publisher exchange and catch"},{"line_number":801,"context_line":"                # the 404 kombu ChannelError and retry until the exchange"},{"line_number":802,"context_line":"                # appears"},{"line_number":803,"context_line":"                if exc.code \u003d\u003d 404 and timer.check_return() \u003e 0:"},{"line_number":804,"context_line":"                    LOG.info(_LI(\"The exchange to reply to %s doesn\u0027t \""},{"line_number":805,"context_line":"                                 \"exist yet, retrying...\") % msg_id)"},{"line_number":806,"context_line":"                    time.sleep(1)"}],"source_content_type":"text/x-python","patch_set":19,"id":"1a930d6b_06dffe69","line":803,"in_reply_to":"1a930d6b_00d0c61d","updated":"2015-01-26 17:45:30.000000000","message":"Andrea corrected me. ignore my stupidity. :)","commit_id":"1d5c64bbd4fe1d9ad12da5f26d7bf62f41434732"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"2793d6a9c5110533880bb6ad212e6dd0cf326795","unresolved":false,"context_lines":[{"line_number":800,"context_line":"                # So we set passive\u003dTrue to the publisher exchange and catch"},{"line_number":801,"context_line":"                # the 404 kombu ChannelError and retry until the exchange"},{"line_number":802,"context_line":"                # appears"},{"line_number":803,"context_line":"                if exc.code \u003d\u003d 404 and timer.check_return() \u003e 0:"},{"line_number":804,"context_line":"                    LOG.info(_LI(\"The exchange to reply to %s doesn\u0027t \""},{"line_number":805,"context_line":"                                 \"exist yet, retrying...\") % msg_id)"},{"line_number":806,"context_line":"                    time.sleep(1)"}],"source_content_type":"text/x-python","patch_set":19,"id":"1a930d6b_f9e995b7","line":803,"in_reply_to":"1a930d6b_06dffe69","updated":"2015-01-27 10:06:48.000000000","message":"Done","commit_id":"1d5c64bbd4fe1d9ad12da5f26d7bf62f41434732"}]}
