)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"10393fa9adff8dbec3199c10612ce586b69a66c0","unresolved":false,"context_lines":[{"line_number":10,"context_line":"also provides two plugin implementations, a dummy pass through"},{"line_number":11,"context_line":"and one for using kite."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This is work in progress."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Icbed9d0aee4c84bb396f58bcb7516797a97a515b"},{"line_number":16,"context_line":"Implements: blueprint trusted-messaging"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa98f980_ff97af45","line":13,"updated":"2014-09-05 09:39:26.000000000","message":"If this patch is in progress, set workflow to -1.","commit_id":"57b5c1e8ee29c36197c5d0fa0980527e43fc3d48"}],"oslo/messaging/_security/__init__.py":[{"author":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"change_message_id":"a428853e0f4c5a2b4eae2591815d9261410226d2","unresolved":false,"context_lines":[{"line_number":1,"context_line":" "}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_336ded32","line":1,"updated":"2014-07-28 11:00:10.000000000","message":"unnecessary whitespace, I\u0027m surprised pep8 doesn\u0027t complain","commit_id":"78c9a55465f55aa7af8181ef12cb4e66593e4e77"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"82dff6dfca680849df3763209f12edc2617bba2e","unresolved":false,"context_lines":[{"line_number":1,"context_line":" "}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_b81b6e1c","line":1,"in_reply_to":"baada198_336ded32","updated":"2014-07-29 09:10:34.000000000","message":"heh, so am I, will fix thanks!","commit_id":"78c9a55465f55aa7af8181ef12cb4e66593e4e77"}],"oslo/messaging/_security/dummy.py":[{"author":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"change_message_id":"5addc200123e723aaf6066a8f2fa2af55d66a53c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"class DummySecPolicy(security.SecurityPolicyBase):"},{"line_number":22,"context_line":"    \"\"\"This is a dummy pass-through security policy.\"\"\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    log \u003d logging.getLogger(__name__)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def __init__(self, identity):"},{"line_number":27,"context_line":"        self.log.debug(\"Peer identified as %s\" % identity)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_412c284a","line":24,"updated":"2014-08-05 10:22:35.000000000","message":"The openstack standard seems to be a module-global:\n\n    LOG \u003d logging.getLogger(__name__)\n\n(have a look at oslo/messaging/rpc/dispatcher.py for example)","commit_id":"9ff4a15314af71ba0bf5ce316f6ee4c45966abe1"},{"author":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"change_message_id":"10e8134fd5441d6e36349a47cc8ef48725e61946","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    \"\"\"This is a dummy pass-through security policy.\"\"\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def __init__(self, identity):"},{"line_number":27,"context_line":"        self.LOG.debug(\"Peer identified as %s\" % identity)"},{"line_number":28,"context_line":"        super(DummySecPolicy, self).__init__(identity)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def secure(self, target, message):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1abeadc6_7746c850","line":27,"updated":"2014-08-20 14:46:43.000000000","message":"shouldn\u0027t this use module-global LOG?\n\n(same for others below and in other modules)","commit_id":"258b5991488d043ef7640e701e6d7b2b51fe4a00"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"2f78983ac26da8b995eb193fb07e0122bc42cb8b","unresolved":false,"context_lines":[{"line_number":20,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class DummySecPolicy(security.SecurityPolicyBase):"},{"line_number":24,"context_line":"    \"\"\"This is a dummy pass-through security policy.\"\"\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def __init__(self, identity):"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_d9911553","line":23,"updated":"2014-09-16 01:09:19.000000000","message":"Why not have the default at least use a hmac policy? Seems better than nothing...","commit_id":"b843cb2a81c3bbb3f4a709805b6c297de471c6d0"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"dc92bf408a16aa6fe7ce35c186966f522c6ed09b","unresolved":false,"context_lines":[{"line_number":20,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class DummySecPolicy(security.SecurityPolicyBase):"},{"line_number":24,"context_line":"    \"\"\"This is a dummy pass-through security policy.\"\"\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def __init__(self, identity):"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_92cbdc72","line":23,"in_reply_to":"fa98f980_ab7dd41d","updated":"2014-09-16 11:04:49.000000000","message":"Yeah, I wrote this as a pure pass-through with logging, but I like the idea of wrapping it in a dict, will do.","commit_id":"b843cb2a81c3bbb3f4a709805b6c297de471c6d0"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"eb94e41c5986887caf4c60efe40d824847551e79","unresolved":false,"context_lines":[{"line_number":20,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class DummySecPolicy(security.SecurityPolicyBase):"},{"line_number":24,"context_line":"    \"\"\"This is a dummy pass-through security policy.\"\"\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def __init__(self, identity):"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_ab7dd41d","line":23,"in_reply_to":"fa98f980_d9911553","updated":"2014-09-16 02:26:05.000000000","message":"even just nest it in a dictionary, like {msg: message} so that you can tell that you can get an error if there is a mistake.","commit_id":"b843cb2a81c3bbb3f4a709805b6c297de471c6d0"}],"oslo/messaging/_security/kite.py":[{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"d7c0f577f18bcd57b65519dce3a42b6ffdea5875","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"def getSession():"},{"line_number":27,"context_line":"    # NOTE(tkelsey): using developer interface to remove the need to run"},{"line_number":28,"context_line":"    # a keystone server."},{"line_number":29,"context_line":"    host \u003d \"localhost\""},{"line_number":30,"context_line":"    port \u003d 9109"},{"line_number":31,"context_line":"    kite \u003d \"http://%s:%s/v1\" % (host, port)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_2a090b84","line":28,"updated":"2014-07-26 09:48:05.000000000","message":"This will be fixed before code leaves WIP","commit_id":"78c9a55465f55aa7af8181ef12cb4e66593e4e77"},{"author":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"change_message_id":"a428853e0f4c5a2b4eae2591815d9261410226d2","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            self.listener.__call__(message)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        def poll(self, timeout\u003dNone):"},{"line_number":56,"context_line":"            message \u003d self.listener.poll(timeout\u003dtimeout)"},{"line_number":57,"context_line":"            if message:"},{"line_number":58,"context_line":"                KiteSecPolicy.log.debug(\"Got secure message: %s\","},{"line_number":59,"context_line":"                                        message.message)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_ae4d1674","line":56,"updated":"2014-07-28 11:00:10.000000000","message":"Not sure if that naming convention is used anywhere else, but having message.message looks weird. Isn\u0027t it something like frame/wrapper if it contains more info than just the message?","commit_id":"78c9a55465f55aa7af8181ef12cb4e66593e4e77"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"82dff6dfca680849df3763209f12edc2617bba2e","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            self.listener.__call__(message)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        def poll(self, timeout\u003dNone):"},{"line_number":56,"context_line":"            message \u003d self.listener.poll(timeout\u003dtimeout)"},{"line_number":57,"context_line":"            if message:"},{"line_number":58,"context_line":"                KiteSecPolicy.log.debug(\"Got secure message: %s\","},{"line_number":59,"context_line":"                                        message.message)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_d8d58248","line":56,"in_reply_to":"baada198_ae4d1674","updated":"2014-07-29 09:10:34.000000000","message":"Yeah I agree its a bit eye catching, message (outer) is an IncommingMessage object instance, message (inner) is a field in that object called message, this is how its named in the code currently. I can have a look at adjusting the variable name.","commit_id":"78c9a55465f55aa7af8181ef12cb4e66593e4e77"},{"author":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"change_message_id":"a428853e0f4c5a2b4eae2591815d9261410226d2","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                                    b64decode\u003dTrue)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"                KiteSecPolicy.log.debug(\"Decrypted message: %s\", body)"},{"line_number":70,"context_line":"                message.message \u003d ast.literal_eval(body)"},{"line_number":71,"context_line":"            return message"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def __init__(self, identity, key\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_ee1c6e68","line":70,"updated":"2014-07-28 11:00:10.000000000","message":"so it\u0027s overwriting an existing field using a different structure instead? this seems evil - is it done for compatibility with insecure messages? I think it deserves a comment","commit_id":"78c9a55465f55aa7af8181ef12cb4e66593e4e77"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"82dff6dfca680849df3763209f12edc2617bba2e","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                                    b64decode\u003dTrue)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"                KiteSecPolicy.log.debug(\"Decrypted message: %s\", body)"},{"line_number":70,"context_line":"                message.message \u003d ast.literal_eval(body)"},{"line_number":71,"context_line":"            return message"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def __init__(self, identity, key\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_d8f102e0","line":70,"in_reply_to":"baada198_ee1c6e68","updated":"2014-07-29 09:10:34.000000000","message":"Yes this is done because in insecure messages its a dict with expected fields, in secured messaging its a dict with different fields, one of which \"body\" is the cypher-text version of the original dict. This code is actually resorting the message to its original structure.... defiantly need a comment here.","commit_id":"78c9a55465f55aa7af8181ef12cb4e66593e4e77"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"d7c0f577f18bcd57b65519dce3a42b6ffdea5875","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        else:"},{"line_number":81,"context_line":"            self._key \u003d v1.Key(self.identity, key, self._session)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def _get_ticket(self, target):"},{"line_number":84,"context_line":"        ticket \u003d v1.Ticket(self._key, target.topic, session\u003dself._session)"},{"line_number":85,"context_line":"        return ticket"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_8a2137fe","line":83,"updated":"2014-07-26 09:48:05.000000000","message":"this will use a cache to store the ticket before the code leaves WIP","commit_id":"78c9a55465f55aa7af8181ef12cb4e66593e4e77"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"9df9e1e3b79e3567a1ad82366b930345bd38eddd","unresolved":false,"context_lines":[{"line_number":22,"context_line":"import logging"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"def getSession():"},{"line_number":26,"context_line":"    # NOTE(tkelsey): using developer interface to remove the need to run"},{"line_number":27,"context_line":"    # a keystone server."},{"line_number":28,"context_line":"    host \u003d \"localhost\""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_f81b26c9","line":25,"updated":"2014-07-29 09:16:32.000000000","message":"using developer interface to remove the need to run Keystone. This will be fixed before the code leaves WIP.","commit_id":"521838219c3be736387d2b89ef5f2d068c90df6a"},{"author":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"change_message_id":"5addc200123e723aaf6066a8f2fa2af55d66a53c","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    use of Kite. A Kite server and a Keystone server must be available."},{"line_number":38,"context_line":"    \"\"\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    log \u003d logging.getLogger(__name__)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def __init__(self, identity, key\u003dNone):"},{"line_number":43,"context_line":"        super(KiteSecPolicy, self).__init__(identity)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_a176e43e","line":40,"updated":"2014-08-05 10:22:35.000000000","message":"same comment as in previous file","commit_id":"9ff4a15314af71ba0bf5ce316f6ee4c45966abe1"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"eb94e41c5986887caf4c60efe40d824847551e79","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    port \u003d 9109"},{"line_number":32,"context_line":"    kite \u003d \"http://%s:%s/v1\" % (host, port)"},{"line_number":33,"context_line":"    auth \u003d token_endpoint.Token(kite, \u0027aToken\u0027)"},{"line_number":34,"context_line":"    return session.Session(auth\u003dauth)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class KiteSecPolicy(security.SecurityPolicyBase):"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_4b946836","line":34,"updated":"2014-09-16 02:26:05.000000000","message":"hmm, kite will need some new options for here. but this will need to live in kiteclient rather than oslo.messaging anyway.","commit_id":"b843cb2a81c3bbb3f4a709805b6c297de471c6d0"},{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"6ac0b80ffd2e334c597eaaf3ec166fddd40754e2","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            \"esek\": ticket.b64_esek"},{"line_number":74,"context_line":"        }"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        LOG.debug(\"Securred Message: %s\", data)"},{"line_number":77,"context_line":"        return data"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def decrypt(self, message):"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_f127db0f","line":76,"updated":"2014-09-15 17:27:53.000000000","message":"Typo, should be \"secured\"","commit_id":"b843cb2a81c3bbb3f4a709805b6c297de471c6d0"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"dc92bf408a16aa6fe7ce35c186966f522c6ed09b","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            \"esek\": ticket.b64_esek"},{"line_number":74,"context_line":"        }"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        LOG.debug(\"Securred Message: %s\", data)"},{"line_number":77,"context_line":"        return data"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def decrypt(self, message):"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_15027672","line":76,"in_reply_to":"fa98f980_f127db0f","updated":"2014-09-16 11:04:49.000000000","message":"Done","commit_id":"b843cb2a81c3bbb3f4a709805b6c297de471c6d0"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"b1c49c376090f356feb28c1246fe911b805ecef3","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"CONF \u003d cfg.CONF"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"_kite_plugin_group \u003d cfg.OptGroup(name\u003d\u0027kite_plugin\u0027,"},{"line_number":30,"context_line":"                                  title\u003d\"Kite Secure RPC Plugin.\")"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"_kite_plugin_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":7,"id":"baa201ad_a4476576","line":29,"updated":"2014-10-13 19:44:54.000000000","message":"I\u0027m not sure about this name. Is it likely that an application is going to want its own kite plugin? Is a deployer going to know what this kite plugin is plugging into? Should each security plugin define its own group, or can the share \u0027oslo_messaging_security\u0027? I\u0027m not sure which is best, but this name seems insufficiently descriptive.","commit_id":"b350bd50b94f62fbeb0e5982efa4bfb53cac987c"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"6bf799f744dcd227e2d3e839b379c0231b785ab5","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"CONF \u003d cfg.CONF"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"_kite_plugin_group \u003d cfg.OptGroup(name\u003d\u0027kite_plugin\u0027,"},{"line_number":30,"context_line":"                                  title\u003d\"Kite Secure RPC Plugin.\")"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"_kite_plugin_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":7,"id":"baa201ad_9764f822","line":29,"in_reply_to":"baa201ad_a4476576","updated":"2014-10-16 10:15:59.000000000","message":"I agree the name lacks sufficient description, I\u0027ll come up with something better. I have placed the config options of each plugin into separate groups because I imagined new plugins may be added that have unique configuration options specific to themselves. Probably don\u0027t want to clutter up a shared set of options with special case stuff.","commit_id":"b350bd50b94f62fbeb0e5982efa4bfb53cac987c"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"b1c49c376090f356feb28c1246fe911b805ecef3","unresolved":false,"context_lines":[{"line_number":30,"context_line":"                                  title\u003d\"Kite Secure RPC Plugin.\")"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"_kite_plugin_opts \u003d ["},{"line_number":33,"context_line":"    cfg.StrOpt(\u0027sec_identity\u0027,"},{"line_number":34,"context_line":"               help\u003d\u0027An identity for this peer, It will be used to \u0027"},{"line_number":35,"context_line":"                    \u0027identify the peer to Kite, i.e. the key name that \u0027"},{"line_number":36,"context_line":"                    \u0027will be used. If running as a server then this \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"baa201ad_d7cb3948","line":33,"updated":"2014-10-13 19:44:54.000000000","message":"This feels like the sort of option that is going to be needed by any useful plugin. Does it make sense to put it in the kite plugin, or could it live in oslo.messaging and be shared?","commit_id":"b350bd50b94f62fbeb0e5982efa4bfb53cac987c"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"6bf799f744dcd227e2d3e839b379c0231b785ab5","unresolved":false,"context_lines":[{"line_number":30,"context_line":"                                  title\u003d\"Kite Secure RPC Plugin.\")"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"_kite_plugin_opts \u003d ["},{"line_number":33,"context_line":"    cfg.StrOpt(\u0027sec_identity\u0027,"},{"line_number":34,"context_line":"               help\u003d\u0027An identity for this peer, It will be used to \u0027"},{"line_number":35,"context_line":"                    \u0027identify the peer to Kite, i.e. the key name that \u0027"},{"line_number":36,"context_line":"                    \u0027will be used. If running as a server then this \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"baa201ad_22494c31","line":33,"in_reply_to":"baa201ad_d7cb3948","updated":"2014-10-16 10:15:59.000000000","message":"I originally had this option as part of the oslo.messaging shared set. However I was advised to move it out in a previous review. This was because it is not used by the pass-through plugin and may not be used by new plugins added in the future (though I believe thats unlikely personally).","commit_id":"b350bd50b94f62fbeb0e5982efa4bfb53cac987c"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"b1c49c376090f356feb28c1246fe911b805ecef3","unresolved":false,"context_lines":[{"line_number":44,"context_line":"]"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"CONF.register_group(_kite_plugin_group)"},{"line_number":47,"context_line":"CONF.register_opts(_kite_plugin_opts, group\u003d_kite_plugin_group)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"def getSession(conf):"}],"source_content_type":"text/x-python","patch_set":7,"id":"baa201ad_c40b8929","line":47,"updated":"2014-10-13 19:44:54.000000000","message":"These options also need to be added to to oslo.messaging.opts.list_opts() so they show up in the config file generator output.","commit_id":"b350bd50b94f62fbeb0e5982efa4bfb53cac987c"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"6bf799f744dcd227e2d3e839b379c0231b785ab5","unresolved":false,"context_lines":[{"line_number":44,"context_line":"]"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"CONF.register_group(_kite_plugin_group)"},{"line_number":47,"context_line":"CONF.register_opts(_kite_plugin_opts, group\u003d_kite_plugin_group)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"def getSession(conf):"}],"source_content_type":"text/x-python","patch_set":7,"id":"baa201ad_22386cd2","line":47,"in_reply_to":"baa201ad_c40b8929","updated":"2014-10-16 10:15:59.000000000","message":"These options would only need to appear in the config if the Kite plugin is being used, as apposed to any other security plugin, or none. Is it appropriate to include them in the generator output?","commit_id":"b350bd50b94f62fbeb0e5982efa4bfb53cac987c"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"d49ed7a35fda928059049cf04ad6c5b69fd16a98","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    # a keystone server."},{"line_number":53,"context_line":"    host \u003d conf.kite_plugin.host"},{"line_number":54,"context_line":"    port \u003d conf.kite_plugin.port"},{"line_number":55,"context_line":"    kite \u003d \"http://%s:%s/v1\" % (host, port)"},{"line_number":56,"context_line":"    auth \u003d token_endpoint.Token(kite, \u0027aToken\u0027)"},{"line_number":57,"context_line":"    return session.Session(auth\u003dauth)"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_0da07242","line":55,"updated":"2014-11-12 05:01:53.000000000","message":"why wouldn\u0027t we just accept the URI from the config file.","commit_id":"b350bd50b94f62fbeb0e5982efa4bfb53cac987c"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"d49ed7a35fda928059049cf04ad6c5b69fd16a98","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            if key is None:"},{"line_number":77,"context_line":"                self._key \u003d v1.Key.generate(self.identity, self._session)"},{"line_number":78,"context_line":"            else:"},{"line_number":79,"context_line":"                self._key \u003d v1.Key(self.identity, key, self._session)"},{"line_number":80,"context_line":"        except Exception as e:"},{"line_number":81,"context_line":"            LOG.error(e)"},{"line_number":82,"context_line":"            raise"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_2da52e53","line":79,"updated":"2014-11-12 05:01:53.000000000","message":"we should allow for the case where key is provided via config file.","commit_id":"b350bd50b94f62fbeb0e5982efa4bfb53cac987c"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"b1c49c376090f356feb28c1246fe911b805ecef3","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def encrypt(self, target, message):"},{"line_number":90,"context_line":"        \"\"\"Secure a message to a given target.\"\"\""},{"line_number":91,"context_line":"        LOG.debug(\"Securing Message: %s\", message)"},{"line_number":92,"context_line":"        ticket \u003d self._get_ticket(target)"},{"line_number":93,"context_line":"        enc, sig \u003d ticket.encrypt(str(message))"},{"line_number":94,"context_line":"        data \u003d {"}],"source_content_type":"text/x-python","patch_set":7,"id":"baa201ad_172f8189","line":91,"updated":"2014-10-13 19:44:54.000000000","message":"This is going to log every message in the clear, isn\u0027t it? That seems counter to the idea of encrypting them and is going to significantly increase the amount of logging.","commit_id":"b350bd50b94f62fbeb0e5982efa4bfb53cac987c"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"6bf799f744dcd227e2d3e839b379c0231b785ab5","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def encrypt(self, target, message):"},{"line_number":90,"context_line":"        \"\"\"Secure a message to a given target.\"\"\""},{"line_number":91,"context_line":"        LOG.debug(\"Securing Message: %s\", message)"},{"line_number":92,"context_line":"        ticket \u003d self._get_ticket(target)"},{"line_number":93,"context_line":"        enc, sig \u003d ticket.encrypt(str(message))"},{"line_number":94,"context_line":"        data \u003d {"}],"source_content_type":"text/x-python","patch_set":7,"id":"baa201ad_e27024a6","line":91,"in_reply_to":"baa201ad_172f8189","updated":"2014-10-16 10:15:59.000000000","message":"Yes, but only in debug configuration. I can remove the logging if desired though perhaps its useful when debugging?","commit_id":"b350bd50b94f62fbeb0e5982efa4bfb53cac987c"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"b1c49c376090f356feb28c1246fe911b805ecef3","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        \"\"\"Secure a message to a given target.\"\"\""},{"line_number":91,"context_line":"        LOG.debug(\"Securing Message: %s\", message)"},{"line_number":92,"context_line":"        ticket \u003d self._get_ticket(target)"},{"line_number":93,"context_line":"        enc, sig \u003d ticket.encrypt(str(message))"},{"line_number":94,"context_line":"        data \u003d {"},{"line_number":95,"context_line":"            \"sender\": self._key.key_name,"},{"line_number":96,"context_line":"            \"body\": enc,"}],"source_content_type":"text/x-python","patch_set":7,"id":"baa201ad_97a8d1dc","line":93,"updated":"2014-10-13 19:44:54.000000000","message":"If message includes non-ASCII characters str() is going to cause a UnicodeEncodingError. It would be better to get the unicode representation of the message and then call .encode(\u0027utf-8\u0027) on it to get bytes. I don\u0027t know if message is already a string or if it\u0027s a dictionary here.","commit_id":"b350bd50b94f62fbeb0e5982efa4bfb53cac987c"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"6bf799f744dcd227e2d3e839b379c0231b785ab5","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        \"\"\"Secure a message to a given target.\"\"\""},{"line_number":91,"context_line":"        LOG.debug(\"Securing Message: %s\", message)"},{"line_number":92,"context_line":"        ticket \u003d self._get_ticket(target)"},{"line_number":93,"context_line":"        enc, sig \u003d ticket.encrypt(str(message))"},{"line_number":94,"context_line":"        data \u003d {"},{"line_number":95,"context_line":"            \"sender\": self._key.key_name,"},{"line_number":96,"context_line":"            \"body\": enc,"}],"source_content_type":"text/x-python","patch_set":7,"id":"baa201ad_e2a74409","line":93,"in_reply_to":"baa201ad_97a8d1dc","updated":"2014-10-16 10:15:59.000000000","message":"good catch! I\u0027ll fix this and try t be clearer about the state of the message as well.","commit_id":"b350bd50b94f62fbeb0e5982efa4bfb53cac987c"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"70fa137aaca17223b26cdfaef733535398419778","unresolved":false,"context_lines":[{"line_number":124,"context_line":"            raise security.SecurityValidityFailure(e)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        LOG.debug(\"Decrypted message: %s\", body)"},{"line_number":127,"context_line":"        return body"}],"source_content_type":"text/x-python","patch_set":7,"id":"9aa7fdbe_5074f89b","line":127,"updated":"2014-10-20 10:21:56.000000000","message":"At what point do you think we move this file to kiteclient? this should all be loaded via stevedore.","commit_id":"b350bd50b94f62fbeb0e5982efa4bfb53cac987c"}],"oslo/messaging/security.py":[{"author":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"change_message_id":"a428853e0f4c5a2b4eae2591815d9261410226d2","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    @abc.abstractmethod"},{"line_number":34,"context_line":"    def poll(self, timeout\u003dNone):"},{"line_number":35,"context_line":"        \"\"\"Delegate to a wrapped Listener. Decode and verify incoming"},{"line_number":36,"context_line":"        messages, returning the plain text."},{"line_number":37,"context_line":"        \"\"\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_3325edc1","line":36,"updated":"2014-07-28 11:00:10.000000000","message":"this doesn\u0027t match the implementation as far as I see from this patch. in _security/kite.py it returns an object with a message field which is a literal_eval\u0027d value, rather than plaintext","commit_id":"78c9a55465f55aa7af8181ef12cb4e66593e4e77"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"82dff6dfca680849df3763209f12edc2617bba2e","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    @abc.abstractmethod"},{"line_number":34,"context_line":"    def poll(self, timeout\u003dNone):"},{"line_number":35,"context_line":"        \"\"\"Delegate to a wrapped Listener. Decode and verify incoming"},{"line_number":36,"context_line":"        messages, returning the plain text."},{"line_number":37,"context_line":"        \"\"\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_f8c32656","line":36,"in_reply_to":"baada198_3325edc1","updated":"2014-07-29 09:10:34.000000000","message":"correct, my bad, patch 2 changes this behaviour anyway so please see that one.","commit_id":"78c9a55465f55aa7af8181ef12cb4e66593e4e77"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"9df9e1e3b79e3567a1ad82366b930345bd38eddd","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        self._listener \u003d listener"},{"line_number":36,"context_line":"        self._policy \u003d policy"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def _patch_message(self, message):"},{"line_number":39,"context_line":"        # NOTE(tkelsey): this is a bit of a wart. To respond to a"},{"line_number":40,"context_line":"        # message the message.reply method is used, so we need to wrap"},{"line_number":41,"context_line":"        # it with a version that first secures the response before we"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_9836aa50","line":38,"updated":"2014-07-29 09:16:32.000000000","message":"I am not 100% happy with doing it this way, but it needs intercept message.reply() in order to secure responses.","commit_id":"521838219c3be736387d2b89ef5f2d068c90df6a"},{"author":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"change_message_id":"10e8134fd5441d6e36349a47cc8ef48725e61946","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    \"\"\"Class for wrapping listener objects."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    This is Used to intercept incoming messages for decryption and"},{"line_number":30,"context_line":"    verification. The intercepted messages ar patched such that using"},{"line_number":31,"context_line":"    message.reply will send a secured response back to the originator."},{"line_number":32,"context_line":"    \"\"\""},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1abeadc6_57b70c3a","line":30,"updated":"2014-08-20 14:46:43.000000000","message":"are","commit_id":"258b5991488d043ef7640e701e6d7b2b51fe4a00"},{"author":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"change_message_id":"10e8134fd5441d6e36349a47cc8ef48725e61946","unresolved":false,"context_lines":[{"line_number":88,"context_line":"class SecurityLoadFailure(exceptions.MessagingException):"},{"line_number":89,"context_line":"    \"\"\"Raised if a transport security policy can\u0027t be loaded.\"\"\""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def __init__(self, security, ex):"},{"line_number":92,"context_line":"        msg \u003d \u0027Failed to load security policy \"%s\": %s\u0027 % (security, ex)"},{"line_number":93,"context_line":"        super(SecurityLoadFailure, self).__init__(msg)"},{"line_number":94,"context_line":"        self.security \u003d security"}],"source_content_type":"text/x-python","patch_set":4,"id":"1abeadc6_9760c4a6","line":91,"updated":"2014-08-20 14:46:43.000000000","message":"shouldn\u0027t `security` be called `policy` here, or `security_policy`?","commit_id":"258b5991488d043ef7640e701e6d7b2b51fe4a00"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"eb94e41c5986887caf4c60efe40d824847551e79","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        message._policy \u003d self._policy"},{"line_number":50,"context_line":"        message._source \u003d message.message[\"sender\"]"},{"line_number":51,"context_line":"        message._wrapped_reply \u003d message.reply"},{"line_number":52,"context_line":"        message.reply \u003d types.MethodType(wrapper, message)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        # NOTE(tkelsey): decryption returns a string, but in this case"},{"line_number":55,"context_line":"        # the message data is a dict, so we need to interpret it."}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_ebc51c5c","line":52,"updated":"2014-09-16 02:26:05.000000000","message":"i think create your own message object that proxies the original rather than try to monkeypatch the existing.","commit_id":"b843cb2a81c3bbb3f4a709805b6c297de471c6d0"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"dc92bf408a16aa6fe7ce35c186966f522c6ed09b","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        message._policy \u003d self._policy"},{"line_number":50,"context_line":"        message._source \u003d message.message[\"sender\"]"},{"line_number":51,"context_line":"        message._wrapped_reply \u003d message.reply"},{"line_number":52,"context_line":"        message.reply \u003d types.MethodType(wrapper, message)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        # NOTE(tkelsey): decryption returns a string, but in this case"},{"line_number":55,"context_line":"        # the message data is a dict, so we need to interpret it."}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_35b93acc","line":52,"in_reply_to":"fa98f980_ebc51c5c","updated":"2014-09-16 11:04:49.000000000","message":"Done","commit_id":"b843cb2a81c3bbb3f4a709805b6c297de471c6d0"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"eb94e41c5986887caf4c60efe40d824847551e79","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        # the message data is a dict, so we need to interpret it."},{"line_number":56,"context_line":"        #"},{"line_number":57,"context_line":"        body \u003d self._policy.decrypt(message.message)"},{"line_number":58,"context_line":"        message.message \u003d ast.literal_eval(body)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def __call__(self, message):"},{"line_number":61,"context_line":"        self.listener.__call__(message)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_2bdf240e","line":58,"updated":"2014-09-16 02:26:05.000000000","message":"ast!?!","commit_id":"b843cb2a81c3bbb3f4a709805b6c297de471c6d0"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"dc92bf408a16aa6fe7ce35c186966f522c6ed09b","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        # the message data is a dict, so we need to interpret it."},{"line_number":56,"context_line":"        #"},{"line_number":57,"context_line":"        body \u003d self._policy.decrypt(message.message)"},{"line_number":58,"context_line":"        message.message \u003d ast.literal_eval(body)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def __call__(self, message):"},{"line_number":61,"context_line":"        self.listener.__call__(message)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_55aebe82","line":58,"in_reply_to":"fa98f980_2bdf240e","updated":"2014-09-16 11:04:49.000000000","message":"huh?","commit_id":"b843cb2a81c3bbb3f4a709805b6c297de471c6d0"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"eb94e41c5986887caf4c60efe40d824847551e79","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        \"\"\"Secure a message to a given target.\"\"\""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    @abc.abstractmethod"},{"line_number":84,"context_line":"    def listen(self, listener):"},{"line_number":85,"context_line":"        \"\"\"Wrap a Listener and decode incoming messages.\"\"\""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_8bac90a0","line":84,"updated":"2014-09-16 02:26:05.000000000","message":"can we just export decrypt() or the opposite of secure/encrypt? It doesn\u0027t seem like an encryption wrapper should know how to listen.","commit_id":"b843cb2a81c3bbb3f4a709805b6c297de471c6d0"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"dc92bf408a16aa6fe7ce35c186966f522c6ed09b","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        \"\"\"Secure a message to a given target.\"\"\""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    @abc.abstractmethod"},{"line_number":84,"context_line":"    def listen(self, listener):"},{"line_number":85,"context_line":"        \"\"\"Wrap a Listener and decode incoming messages.\"\"\""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_15b436d3","line":84,"in_reply_to":"fa98f980_8bac90a0","updated":"2014-09-16 11:04:49.000000000","message":"I\u0027ll grant this seems a little odd, something needs to wrap the actual listener with a SecureListener object, thats what happens here. I\u0027ll have a look and see what the options are.","commit_id":"b843cb2a81c3bbb3f4a709805b6c297de471c6d0"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"eb94e41c5986887caf4c60efe40d824847551e79","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    \"\"\""},{"line_number":117,"context_line":"    if not identity:"},{"line_number":118,"context_line":"        raise RuntimeError((\"peer identity is required when using a \""},{"line_number":119,"context_line":"                           \"security policy\"))"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    try:"},{"line_number":122,"context_line":"        mgr \u003d driver.DriverManager(\u0027oslo.messaging.security\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_eb9c3c6c","line":119,"updated":"2014-09-16 02:26:05.000000000","message":"wouldn\u0027t this be kite specific? Maybe you want to create a plugin that has different required information. Why not pass the whole CONF? For example kite is going to need to know the URL of the server and dummy doesn\u0027t use this at all.","commit_id":"b843cb2a81c3bbb3f4a709805b6c297de471c6d0"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"dc92bf408a16aa6fe7ce35c186966f522c6ed09b","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    \"\"\""},{"line_number":117,"context_line":"    if not identity:"},{"line_number":118,"context_line":"        raise RuntimeError((\"peer identity is required when using a \""},{"line_number":119,"context_line":"                           \"security policy\"))"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    try:"},{"line_number":122,"context_line":"        mgr \u003d driver.DriverManager(\u0027oslo.messaging.security\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_95c74646","line":119,"in_reply_to":"fa98f980_eb9c3c6c","updated":"2014-09-16 11:04:49.000000000","message":"yeah good point, will do.","commit_id":"b843cb2a81c3bbb3f4a709805b6c297de471c6d0"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"b1c49c376090f356feb28c1246fe911b805ecef3","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":93,"context_line":"class SecurityPolicyBase(object):"},{"line_number":94,"context_line":"    \"\"\"Abstract base class for Transport security policies.\"\"\""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def __init__(self, conf):"}],"source_content_type":"text/x-python","patch_set":7,"id":"baa201ad_37d00553","line":93,"updated":"2014-10-13 19:44:54.000000000","message":"Does this class need to be part of the public API of oslo.messaging? Is something outside of the library going to instantiate one or be given one to use?","commit_id":"b350bd50b94f62fbeb0e5982efa4bfb53cac987c"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"6bf799f744dcd227e2d3e839b379c0231b785ab5","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":93,"context_line":"class SecurityPolicyBase(object):"},{"line_number":94,"context_line":"    \"\"\"Abstract base class for Transport security policies.\"\"\""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def __init__(self, conf):"}],"source_content_type":"text/x-python","patch_set":7,"id":"baa201ad_977a38ef","line":93,"in_reply_to":"baa201ad_37d00553","updated":"2014-10-16 10:15:59.000000000","message":"another vender may wish to create their own security plugin externally to oslo.messaging and loaded by stevedore. They would extend this base class to do that.","commit_id":"b350bd50b94f62fbeb0e5982efa4bfb53cac987c"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"b1c49c376090f356feb28c1246fe911b805ecef3","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    @abc.abstractmethod"},{"line_number":100,"context_line":"    def encrypt(self, target, message):"},{"line_number":101,"context_line":"        \"\"\"Encrypt a message to a given target.\"\"\""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    @abc.abstractmethod"},{"line_number":104,"context_line":"    def decrypt(self, message):"}],"source_content_type":"text/x-python","patch_set":7,"id":"baa201ad_97f611f8","line":101,"updated":"2014-10-13 19:44:54.000000000","message":"Can you document the argument types?","commit_id":"b350bd50b94f62fbeb0e5982efa4bfb53cac987c"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"6bf799f744dcd227e2d3e839b379c0231b785ab5","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    @abc.abstractmethod"},{"line_number":100,"context_line":"    def encrypt(self, target, message):"},{"line_number":101,"context_line":"        \"\"\"Encrypt a message to a given target.\"\"\""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    @abc.abstractmethod"},{"line_number":104,"context_line":"    def decrypt(self, message):"}],"source_content_type":"text/x-python","patch_set":7,"id":"baa201ad_f78544cf","line":101,"in_reply_to":"baa201ad_97f611f8","updated":"2014-10-16 10:15:59.000000000","message":"yes I\u0027ll do that.","commit_id":"b350bd50b94f62fbeb0e5982efa4bfb53cac987c"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"70fa137aaca17223b26cdfaef733535398419778","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def listen(self, listener):"},{"line_number":108,"context_line":"        \"\"\"Wrap a Listener to decrypt incoming messages.\"\"\""},{"line_number":109,"context_line":"        return SecureListener(listener, self)"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"class SecurityLoadFailure(exceptions.MessagingException):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9aa7fdbe_d012a857","line":109,"updated":"2014-10-20 10:21:56.000000000","message":"is there any reason why a listener would be create from outside of oslo.messaging? ie do we need this function or can the object that calls .listen() contruct the SecureListener with the arguments itself?","commit_id":"b350bd50b94f62fbeb0e5982efa4bfb53cac987c"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"70fa137aaca17223b26cdfaef733535398419778","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        self.ex \u003d ex"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"class SecurityValidityFailure(exceptions.MessagingException):"},{"line_number":123,"context_line":"    \"\"\"Raised if a message fails security validation.\"\"\""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def __init__(self, ex):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9aa7fdbe_9020209d","line":122,"updated":"2014-10-20 10:21:56.000000000","message":"i think we should subclass MessagingException with like a generic MessageSecurity exception that these inherit from.","commit_id":"b350bd50b94f62fbeb0e5982efa4bfb53cac987c"}],"oslo/messaging/transport.py":[{"author":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"change_message_id":"10e8134fd5441d6e36349a47cc8ef48725e61946","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                                           \u0027topic and server names specified\u0027,"},{"line_number":122,"context_line":"                                           target)"},{"line_number":123,"context_line":"        if self._security:"},{"line_number":124,"context_line":"            ipt \u003d self._driver.listen(target)"},{"line_number":125,"context_line":"            return self._security.listen(ipt)"},{"line_number":126,"context_line":"        return self._driver.listen(target)"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1abeadc6_57c2ac34","line":124,"updated":"2014-08-20 14:46:43.000000000","message":"what\u0027s ipt?","commit_id":"258b5991488d043ef7640e701e6d7b2b51fe4a00"},{"author":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"change_message_id":"10e8134fd5441d6e36349a47cc8ef48725e61946","unresolved":false,"context_lines":[{"line_number":215,"context_line":"    sec_policy \u003d None"},{"line_number":216,"context_line":"    if conf.sec_policy_name:"},{"line_number":217,"context_line":"        if not conf.sec_identity:"},{"line_number":218,"context_line":"            raise RuntimeError((\"sec_identity must be set if using a \""},{"line_number":219,"context_line":"                               \"seucrity policy\"))"},{"line_number":220,"context_line":"        sec_policy \u003d security.get_security_policy(conf.sec_policy_name,"},{"line_number":221,"context_line":"                                                  conf.sec_identity)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1abeadc6_37f7f08c","line":218,"updated":"2014-08-20 14:46:43.000000000","message":"unnecessary parentheses","commit_id":"258b5991488d043ef7640e701e6d7b2b51fe4a00"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"eb94e41c5986887caf4c60efe40d824847551e79","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                                     wait_for_reply\u003dwait_for_reply,"},{"line_number":104,"context_line":"                                     timeout\u003dtimeout, retry\u003dretry)"},{"line_number":105,"context_line":"        if self._security and response:"},{"line_number":106,"context_line":"            response \u003d self._security.decrypt(response)"},{"line_number":107,"context_line":"        return response"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def _send_notification(self, target, ctxt, message, version, retry\u003dNone):"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_cb9f784e","line":106,"updated":"2014-09-16 02:26:05.000000000","message":"decrypt is not mentioned on the abstract class,\n\nalso secure and decrypt don\u0027t match up, encrypt/decrypt, encode/decode, something that implies they are opposites.","commit_id":"b843cb2a81c3bbb3f4a709805b6c297de471c6d0"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"dc92bf408a16aa6fe7ce35c186966f522c6ed09b","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                                     wait_for_reply\u003dwait_for_reply,"},{"line_number":104,"context_line":"                                     timeout\u003dtimeout, retry\u003dretry)"},{"line_number":105,"context_line":"        if self._security and response:"},{"line_number":106,"context_line":"            response \u003d self._security.decrypt(response)"},{"line_number":107,"context_line":"        return response"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def _send_notification(self, target, ctxt, message, version, retry\u003dNone):"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_7501026a","line":106,"in_reply_to":"fa98f980_cb9f784e","updated":"2014-09-16 11:04:49.000000000","message":"Done","commit_id":"b843cb2a81c3bbb3f4a709805b6c297de471c6d0"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"eb94e41c5986887caf4c60efe40d824847551e79","unresolved":false,"context_lines":[{"line_number":216,"context_line":"    if conf.sec_policy_name:"},{"line_number":217,"context_line":"        if not conf.sec_identity:"},{"line_number":218,"context_line":"            raise RuntimeError((\"sec_identity must be set if using a \""},{"line_number":219,"context_line":"                               \"seucrity policy\"))"},{"line_number":220,"context_line":"        sec_policy \u003d security.get_security_policy(conf.sec_policy_name,"},{"line_number":221,"context_line":"                                                  conf.sec_identity)"},{"line_number":222,"context_line":"    return Transport(mgr.driver, sec_policy)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_6bae8c82","line":219,"updated":"2014-09-16 02:26:05.000000000","message":"seucrity, also you do pretty much the exact same check in get_security_policy","commit_id":"b843cb2a81c3bbb3f4a709805b6c297de471c6d0"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"dc92bf408a16aa6fe7ce35c186966f522c6ed09b","unresolved":false,"context_lines":[{"line_number":216,"context_line":"    if conf.sec_policy_name:"},{"line_number":217,"context_line":"        if not conf.sec_identity:"},{"line_number":218,"context_line":"            raise RuntimeError((\"sec_identity must be set if using a \""},{"line_number":219,"context_line":"                               \"seucrity policy\"))"},{"line_number":220,"context_line":"        sec_policy \u003d security.get_security_policy(conf.sec_policy_name,"},{"line_number":221,"context_line":"                                                  conf.sec_identity)"},{"line_number":222,"context_line":"    return Transport(mgr.driver, sec_policy)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_95f58686","line":219,"in_reply_to":"fa98f980_6bae8c82","updated":"2014-09-16 11:04:49.000000000","message":"Done","commit_id":"b843cb2a81c3bbb3f4a709805b6c297de471c6d0"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"b1c49c376090f356feb28c1246fe911b805ecef3","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                    \u0027transport_url option.\u0027),"},{"line_number":53,"context_line":"    cfg.StrOpt(\u0027sec_policy_name\u0027,"},{"line_number":54,"context_line":"               help\u003d\u0027The name of a securoty policy plugin to use. If unset \u0027"},{"line_number":55,"context_line":"                    \u0027then no message level securoty will be used. Possible \u0027"},{"line_number":56,"context_line":"                    \u0027valuse inculde: dummy, kite\u0027),"},{"line_number":57,"context_line":"]"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"baa201ad_97129107","line":55,"updated":"2014-10-13 19:44:54.000000000","message":"typo: securoty","commit_id":"b350bd50b94f62fbeb0e5982efa4bfb53cac987c"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"6bf799f744dcd227e2d3e839b379c0231b785ab5","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                    \u0027transport_url option.\u0027),"},{"line_number":53,"context_line":"    cfg.StrOpt(\u0027sec_policy_name\u0027,"},{"line_number":54,"context_line":"               help\u003d\u0027The name of a securoty policy plugin to use. If unset \u0027"},{"line_number":55,"context_line":"                    \u0027then no message level securoty will be used. Possible \u0027"},{"line_number":56,"context_line":"                    \u0027valuse inculde: dummy, kite\u0027),"},{"line_number":57,"context_line":"]"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"baa201ad_17a488a4","line":55,"in_reply_to":"baa201ad_97129107","updated":"2014-10-16 10:15:59.000000000","message":"Done","commit_id":"b350bd50b94f62fbeb0e5982efa4bfb53cac987c"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"b1c49c376090f356feb28c1246fe911b805ecef3","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    cfg.StrOpt(\u0027sec_policy_name\u0027,"},{"line_number":54,"context_line":"               help\u003d\u0027The name of a securoty policy plugin to use. If unset \u0027"},{"line_number":55,"context_line":"                    \u0027then no message level securoty will be used. Possible \u0027"},{"line_number":56,"context_line":"                    \u0027valuse inculde: dummy, kite\u0027),"},{"line_number":57,"context_line":"]"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"baa201ad_d71a5917","line":56,"updated":"2014-10-13 19:44:54.000000000","message":"Typo: valuse\n\nShould this option have a \"choices\" parameter set to restrict the input values?","commit_id":"b350bd50b94f62fbeb0e5982efa4bfb53cac987c"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"6bf799f744dcd227e2d3e839b379c0231b785ab5","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    cfg.StrOpt(\u0027sec_policy_name\u0027,"},{"line_number":54,"context_line":"               help\u003d\u0027The name of a securoty policy plugin to use. If unset \u0027"},{"line_number":55,"context_line":"                    \u0027then no message level securoty will be used. Possible \u0027"},{"line_number":56,"context_line":"                    \u0027valuse inculde: dummy, kite\u0027),"},{"line_number":57,"context_line":"]"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"baa201ad_b7bc9cbc","line":56,"in_reply_to":"baa201ad_d71a5917","updated":"2014-10-16 10:15:59.000000000","message":"maybe, but others may add new plugins to the set of available ones, so perhaps we should leave it open? what do you think.","commit_id":"b350bd50b94f62fbeb0e5982efa4bfb53cac987c"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"b1c49c376090f356feb28c1246fe911b805ecef3","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        if not target.topic:"},{"line_number":92,"context_line":"            raise exceptions.InvalidTarget(\u0027A topic is required to send\u0027,"},{"line_number":93,"context_line":"                                           target)"},{"line_number":94,"context_line":"        if self._security:"},{"line_number":95,"context_line":"            message \u003d self._security.encrypt(target.topic, message)"},{"line_number":96,"context_line":"        response \u003d self._driver.send(target, ctxt, message,"},{"line_number":97,"context_line":"                                     wait_for_reply\u003dwait_for_reply,"}],"source_content_type":"text/x-python","patch_set":7,"id":"baa201ad_17c30158","line":94,"updated":"2014-10-13 19:44:54.000000000","message":"Instead of having to remember to check self._security everywhere, would it make sense to default the security implementation to the pass-through implementation if none is provided?","commit_id":"b350bd50b94f62fbeb0e5982efa4bfb53cac987c"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"6bf799f744dcd227e2d3e839b379c0231b785ab5","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        if not target.topic:"},{"line_number":92,"context_line":"            raise exceptions.InvalidTarget(\u0027A topic is required to send\u0027,"},{"line_number":93,"context_line":"                                           target)"},{"line_number":94,"context_line":"        if self._security:"},{"line_number":95,"context_line":"            message \u003d self._security.encrypt(target.topic, message)"},{"line_number":96,"context_line":"        response \u003d self._driver.send(target, ctxt, message,"},{"line_number":97,"context_line":"                                     wait_for_reply\u003dwait_for_reply,"}],"source_content_type":"text/x-python","patch_set":7,"id":"baa201ad_174008a4","line":94,"in_reply_to":"baa201ad_17c30158","updated":"2014-10-16 10:15:59.000000000","message":"Yes that could make things cleaner, I have endeavoured to leave the behaviour unchanged as much as possible if no security plugin is requested. The pass-through plugin effectively accomplishes this but adds some complexity into the code. If you think it is worth defaulting to it then I\u0027ll make the needed changes, I wasn\u0027t sure of the best option here. Its worth noting that the pass-through plugin does a lot of logging that may not be desirable under normal situations.","commit_id":"b350bd50b94f62fbeb0e5982efa4bfb53cac987c"}],"scripts/secure_rpc_client.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"b1c49c376090f356feb28c1246fe911b805ecef3","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                 sec_policy_name\u003d\"kite\")"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"group \u003d cfg.OptGroup(name\u003d\u0027kite_plugin\u0027, title\u003d\"Kite Secure RPC Plugin.\")"},{"line_number":45,"context_line":"ident \u003d cfg.StrOpt(\u0027identity\u0027, default\u003dpeer_name)"},{"line_number":46,"context_line":"cfg.CONF.register_group(group)"},{"line_number":47,"context_line":"cfg.CONF.register_opt(ident, group\u003dgroup)"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"baa201ad_d7f2599a","line":45,"updated":"2014-10-13 19:44:54.000000000","message":"The name of the option in the plugin seems to be sec_identity.\n\nAre these scripts tested? If we need to include these example scripts, it would be good for them to have tests.","commit_id":"b350bd50b94f62fbeb0e5982efa4bfb53cac987c"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"6bf799f744dcd227e2d3e839b379c0231b785ab5","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                 sec_policy_name\u003d\"kite\")"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"group \u003d cfg.OptGroup(name\u003d\u0027kite_plugin\u0027, title\u003d\"Kite Secure RPC Plugin.\")"},{"line_number":45,"context_line":"ident \u003d cfg.StrOpt(\u0027identity\u0027, default\u003dpeer_name)"},{"line_number":46,"context_line":"cfg.CONF.register_group(group)"},{"line_number":47,"context_line":"cfg.CONF.register_opt(ident, group\u003dgroup)"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"baa201ad_5773704d","line":45,"in_reply_to":"baa201ad_d7f2599a","updated":"2014-10-16 10:15:59.000000000","message":"well spotted, I must have introduced this bug during one of the updates. These scripts have no tests run against them and are intended to be illustrative (so getting it wrong is doubly bad), how would you recommend  tests be run against scripts of this nature?","commit_id":"b350bd50b94f62fbeb0e5982efa4bfb53cac987c"}],"scripts/secure_rpc_server.py":[{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"d7c0f577f18bcd57b65519dce3a42b6ffdea5875","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def test(self, ctx, arg):"},{"line_number":43,"context_line":"        print(\"Got call: \", arg)"},{"line_number":44,"context_line":"        return \"echo \u0027%s\u0027\" % arg"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"cfg.set_defaults(messaging.transport._transport_opts,"},{"line_number":47,"context_line":"                 sec_policy_name\u003d\"kite\","}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_4a0c7f93","line":44,"updated":"2014-07-26 09:48:05.000000000","message":"NOTE: message reply are not protected, this will be fixed before code leaves WIP","commit_id":"78c9a55465f55aa7af8181ef12cb4e66593e4e77"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"b1c49c376090f356feb28c1246fe911b805ecef3","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                 sec_policy_name\u003d\"kite\")"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"group \u003d cfg.OptGroup(name\u003d\u0027kite_plugin\u0027, title\u003d\"Kite Secure RPC Plugin.\")"},{"line_number":51,"context_line":"ident \u003d cfg.StrOpt(\u0027identity\u0027, default\u003dpeer_name)"},{"line_number":52,"context_line":"cfg.CONF.register_group(group)"},{"line_number":53,"context_line":"cfg.CONF.register_opt(ident, group\u003dgroup)"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"baa201ad_17edc1b7","line":51,"updated":"2014-10-13 19:44:54.000000000","message":"Same comment on option name.","commit_id":"b350bd50b94f62fbeb0e5982efa4bfb53cac987c"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"6bf799f744dcd227e2d3e839b379c0231b785ab5","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                 sec_policy_name\u003d\"kite\")"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"group \u003d cfg.OptGroup(name\u003d\u0027kite_plugin\u0027, title\u003d\"Kite Secure RPC Plugin.\")"},{"line_number":51,"context_line":"ident \u003d cfg.StrOpt(\u0027identity\u0027, default\u003dpeer_name)"},{"line_number":52,"context_line":"cfg.CONF.register_group(group)"},{"line_number":53,"context_line":"cfg.CONF.register_opt(ident, group\u003dgroup)"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"baa201ad_b7d9fc58","line":51,"in_reply_to":"baa201ad_17edc1b7","updated":"2014-10-16 10:15:59.000000000","message":"see response to your first similar comment.","commit_id":"b350bd50b94f62fbeb0e5982efa4bfb53cac987c"}],"setup.cfg":[{"author":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"change_message_id":"5addc200123e723aaf6066a8f2fa2af55d66a53c","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    noop \u003d oslo.messaging.notify._impl_noop:NoOpDriver"},{"line_number":51,"context_line":"    routing \u003d oslo.messaging.notify._impl_routing:RoutingDriver"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"oslo.messaging.security \u003d "},{"line_number":54,"context_line":"    dummy \u003d oslo.messaging._security.dummy:DummySecPolicy"},{"line_number":55,"context_line":"    kite \u003d oslo.messaging._security.kite:KiteSecPolicy"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"baada198_2183b407","line":53,"updated":"2014-08-05 10:22:35.000000000","message":"whitespace","commit_id":"9ff4a15314af71ba0bf5ce316f6ee4c45966abe1"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"b1c49c376090f356feb28c1246fe911b805ecef3","unresolved":false,"context_lines":[{"line_number":58,"context_line":"oslo.config.opts \u003d"},{"line_number":59,"context_line":"    oslo.messaging \u003d oslo.messaging.opts:list_opts"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"[kite_plugin]"},{"line_number":62,"context_line":"host\u003dlocalhost"},{"line_number":63,"context_line":"port\u003d9109"},{"line_number":64,"context_line":"identity\u003ddefault"}],"source_content_type":"text/x-ttcn-cfg","patch_set":7,"id":"baa201ad_b725d50b","line":61,"updated":"2014-10-13 19:44:54.000000000","message":"I don\u0027t think we want these in the setup.cfg, do we?","commit_id":"b350bd50b94f62fbeb0e5982efa4bfb53cac987c"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"6bf799f744dcd227e2d3e839b379c0231b785ab5","unresolved":false,"context_lines":[{"line_number":58,"context_line":"oslo.config.opts \u003d"},{"line_number":59,"context_line":"    oslo.messaging \u003d oslo.messaging.opts:list_opts"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"[kite_plugin]"},{"line_number":62,"context_line":"host\u003dlocalhost"},{"line_number":63,"context_line":"port\u003d9109"},{"line_number":64,"context_line":"identity\u003ddefault"}],"source_content_type":"text/x-ttcn-cfg","patch_set":7,"id":"baa201ad_972dd848","line":61,"in_reply_to":"baa201ad_b725d50b","updated":"2014-10-16 10:15:59.000000000","message":"mea culpa, of course we don\u0027t want these here, I\u0027ll remove them.","commit_id":"b350bd50b94f62fbeb0e5982efa4bfb53cac987c"}]}
