)]}'
{"oslo/messaging/_drivers/impl_rabbit.py":[{"author":{"_account_id":8784,"name":"Gordon Sim","email":"gsim@redhat.com","username":"gordonsim"},"change_message_id":"6344421fa8a11c0623532ddb171287e642943584","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        self.channel \u003d channel"},{"line_number":162,"context_line":"        self.kwargs[\u0027channel\u0027] \u003d channel"},{"line_number":163,"context_line":"        if self.kwargs.pop(\u0027auto_delete\u0027, False):"},{"line_number":164,"context_line":"            self.kwargs.setdefault(\u0027queue_arguments\u0027, {})["},{"line_number":165,"context_line":"                \u0027x-expires\u0027] \u003d 60 * 60 * 1000"},{"line_number":166,"context_line":"        self.queue \u003d kombu.entity.Queue(**self.kwargs)"},{"line_number":167,"context_line":"        self.queue.declare()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_38ac7835","line":164,"updated":"2014-08-19 12:01:57.000000000","message":"Rather than replacing any autodelete option, why not change the DirectConsumer to request x-expires instead of auto-delete in the first place?\n\nI think that would be clearer and would have less impact on other aspects of the system.","commit_id":"98627e44163477e59bcf552c576505ba76c9e1bf"},{"author":{"_account_id":7226,"name":"Stan Lagun","email":"stan.lagun@gmail.com","username":"istalker2"},"change_message_id":"c02e2517ea99d295619213335dfa5f7bb0d2121f","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        self.channel \u003d channel"},{"line_number":162,"context_line":"        self.kwargs[\u0027channel\u0027] \u003d channel"},{"line_number":163,"context_line":"        if self.kwargs.pop(\u0027auto_delete\u0027, False):"},{"line_number":164,"context_line":"            self.kwargs.setdefault(\u0027queue_arguments\u0027, {})["},{"line_number":165,"context_line":"                \u0027x-expires\u0027] \u003d 60 * 60 * 1000"},{"line_number":166,"context_line":"        self.queue \u003d kombu.entity.Queue(**self.kwargs)"},{"line_number":167,"context_line":"        self.queue.declare()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_7319b378","line":164,"in_reply_to":"1abeadc6_38ac7835","updated":"2014-08-19 12:05:23.000000000","message":"Because this allows fixing it in one place. auto-delete is caller intention and x-expires is a better way to implement auto-deletion","commit_id":"98627e44163477e59bcf552c576505ba76c9e1bf"},{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"1da891fc154df0c2facb72e50cfbccf1a91a8202","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        self.kwargs[\u0027channel\u0027] \u003d channel"},{"line_number":163,"context_line":"        if self.kwargs.pop(\u0027auto_delete\u0027, False):"},{"line_number":164,"context_line":"            self.kwargs.setdefault(\u0027queue_arguments\u0027, {})["},{"line_number":165,"context_line":"                \u0027x-expires\u0027] \u003d 60 * 60 * 1000"},{"line_number":166,"context_line":"        self.queue \u003d kombu.entity.Queue(**self.kwargs)"},{"line_number":167,"context_line":"        self.queue.declare()"},{"line_number":168,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_affd753c","line":165,"updated":"2014-09-02 10:33:00.000000000","message":"Please, explain to me this magic arithmetic operation. Thanks!","commit_id":"98627e44163477e59bcf552c576505ba76c9e1bf"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"fac834975f80d6ce0019eb6de8415d08898ff32b","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        self.kwargs[\u0027channel\u0027] \u003d channel"},{"line_number":163,"context_line":"        if self.kwargs.pop(\u0027auto_delete\u0027, False):"},{"line_number":164,"context_line":"            self.kwargs.setdefault(\u0027queue_arguments\u0027, {})["},{"line_number":165,"context_line":"                \u0027x-expires\u0027] \u003d 60 * 60 * 1000"},{"line_number":166,"context_line":"        self.queue \u003d kombu.entity.Queue(**self.kwargs)"},{"line_number":167,"context_line":"        self.queue.declare()"},{"line_number":168,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_c8b48ad3","line":165,"in_reply_to":"fa98f980_affd753c","updated":"2014-09-23 16:37:06.000000000","message":"I\u0027m guessing minutes * seconds * milliseconds, to get the number of milliseconds in an hour.","commit_id":"98627e44163477e59bcf552c576505ba76c9e1bf"}]}