)]}'
{"oslo/messaging/_drivers/impl_rabbit.py":[{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"90397737ffadfaa0215ec3b09a948a3a94bf3192","unresolved":false,"context_lines":[{"line_number":828,"context_line":"                                 title\u003d\u0027RabbitMQ driver options\u0027)"},{"line_number":829,"context_line":"        conf.register_group(opt_group)"},{"line_number":830,"context_line":"        conf.register_opts(rabbit_opts, group\u003dopt_group)"},{"line_number":831,"context_line":"        conf.register_opts(rpc_amqp.amqp_opts, group\u003dopt_group)"},{"line_number":832,"context_line":""},{"line_number":833,"context_line":"        connection_pool \u003d rpc_amqp.get_connection_pool("},{"line_number":834,"context_line":"            conf.oslo_messaging_rabbit, url, Connection)"}],"source_content_type":"text/x-python","patch_set":7,"id":"baa201ad_a9bbeec2","line":831,"updated":"2014-09-30 12:23:21.000000000","message":"How does it works? Can I have access to an old group? \n    \n     conf.fake_rabbit\n\nAnd in the same time to have access to a new group with the same options:\n\n    conf.oslo_messaging_rabbit.fake_rabbit\n\nI can\u0027t get this behavior in my code. If it works differently, why do we do it? What the behavior we expect? Please see my patch https://review.openstack.org/123711/","commit_id":"b7abf268798b11e3db4d9cae43cf00bf456a406d"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"58fc61cd0618d7e20af752592ebf57a2878483a4","unresolved":false,"context_lines":[{"line_number":828,"context_line":"                                 title\u003d\u0027RabbitMQ driver options\u0027)"},{"line_number":829,"context_line":"        conf.register_group(opt_group)"},{"line_number":830,"context_line":"        conf.register_opts(rabbit_opts, group\u003dopt_group)"},{"line_number":831,"context_line":"        conf.register_opts(rpc_amqp.amqp_opts, group\u003dopt_group)"},{"line_number":832,"context_line":""},{"line_number":833,"context_line":"        connection_pool \u003d rpc_amqp.get_connection_pool("},{"line_number":834,"context_line":"            conf.oslo_messaging_rabbit, url, Connection)"}],"source_content_type":"text/x-python","patch_set":7,"id":"baa201ad_8c8f1823","line":831,"in_reply_to":"baa201ad_a9bbeec2","updated":"2014-09-30 13:08:08.000000000","message":"No you must not access to the old group, your code must use only the new group.\n\nBut if conf.oslo_messaging_rabbit.fake_rabbit is not set and a deprecated locations is set in the config file, oslo.cfg will use the value from the deprecated location.\n\nIt\u0027s just completely transparent for us.","commit_id":"b7abf268798b11e3db4d9cae43cf00bf456a406d"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"3c61ca8bdde6e96b146f83ddda1b336eb0bc0f26","unresolved":false,"context_lines":[{"line_number":830,"context_line":"                                 title\u003d\u0027RabbitMQ driver options\u0027)"},{"line_number":831,"context_line":"        conf.register_group(opt_group)"},{"line_number":832,"context_line":"        conf.register_opts(rabbit_opts, group\u003dopt_group)"},{"line_number":833,"context_line":"        conf.register_opts(rpc_amqp.amqp_opts, group\u003dopt_group)"},{"line_number":834,"context_line":""},{"line_number":835,"context_line":"        connection_pool \u003d rpc_amqp.get_connection_pool("},{"line_number":836,"context_line":"            conf, conf.oslo_messaging_rabbit.rpc_conn_pool_size,"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a890539_cf71dd45","line":833,"updated":"2014-11-20 21:54:36.000000000","message":"So we have the same options being registered in 2 groups now, with a the same default group. Do you know for sure that the deprecation logic works as you would expect there? We don\u0027t end up with any sort of conflict?","commit_id":"c3805cd0298bbe5ae7dcf143cb2d77426add2714"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"90b456d7d01de91970b1fa9b74ba242d54a134b7","unresolved":false,"context_lines":[{"line_number":830,"context_line":"                                 title\u003d\u0027RabbitMQ driver options\u0027)"},{"line_number":831,"context_line":"        conf.register_group(opt_group)"},{"line_number":832,"context_line":"        conf.register_opts(rabbit_opts, group\u003dopt_group)"},{"line_number":833,"context_line":"        conf.register_opts(rpc_amqp.amqp_opts, group\u003dopt_group)"},{"line_number":834,"context_line":""},{"line_number":835,"context_line":"        connection_pool \u003d rpc_amqp.get_connection_pool("},{"line_number":836,"context_line":"            conf, conf.oslo_messaging_rabbit.rpc_conn_pool_size,"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a890539_dde41be2","line":833,"in_reply_to":"5a890539_cf71dd45","updated":"2014-11-21 16:13:58.000000000","message":"Hum, I guess it works only if you don\u0027t both driver at the same times...\n\nI have checked on oslo.config, and it doesn\u0027t looks good: https://review.openstack.org/136406","commit_id":"c3805cd0298bbe5ae7dcf143cb2d77426add2714"}],"oslo/messaging/opts.py":[{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"961bdb39ce2907e17233adc073cd2713570596b8","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    (\u0027matchmaker_ring\u0027, matchmaker_ring.matchmaker_opts),"},{"line_number":49,"context_line":"    (\u0027oslo_messaging_amqp\u0027, amqp_opts.amqp1_opts),"},{"line_number":50,"context_line":"    (\u0027oslo_messaging_rabbit\u0027, list(itertools.chain(amqp.amqp_opts,"},{"line_number":51,"context_line":"                                                   impl_rabbit.rabbit_opts))),"},{"line_number":52,"context_line":"    (\u0027oslo_messaging_qpid\u0027, list(itertools.chain(amqp.amqp_opts,"},{"line_number":53,"context_line":"                                                 impl_qpid.qpid_opts)))"},{"line_number":54,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a890539_85e46de1","line":51,"updated":"2014-12-05 11:02:12.000000000","message":"I think that will be better idea provide this groups separated. Better get it explicitly in a others modules.","commit_id":"b99063f8283644ae00501a56d9c137385544c00c"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"a982e92431e53db8457c70fbb8ed79f98121830f","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    (\u0027matchmaker_ring\u0027, matchmaker_ring.matchmaker_opts),"},{"line_number":49,"context_line":"    (\u0027oslo_messaging_amqp\u0027, amqp_opts.amqp1_opts),"},{"line_number":50,"context_line":"    (\u0027oslo_messaging_rabbit\u0027, list(itertools.chain(amqp.amqp_opts,"},{"line_number":51,"context_line":"                                                   impl_rabbit.rabbit_opts))),"},{"line_number":52,"context_line":"    (\u0027oslo_messaging_qpid\u0027, list(itertools.chain(amqp.amqp_opts,"},{"line_number":53,"context_line":"                                                 impl_qpid.qpid_opts)))"},{"line_number":54,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a961159_c7db324d","line":51,"in_reply_to":"5a890539_85e46de1","updated":"2014-12-12 07:11:36.000000000","message":"Separating it permits to have differente amqp_opts if you setup a transport with qpid and an other one with rabbit for example.","commit_id":"b99063f8283644ae00501a56d9c137385544c00c"},{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"b3d067aa9187023453ff6a40d2227fc3c137a335","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    (\u0027matchmaker_redis\u0027, matchmaker_redis.matchmaker_redis_opts),"},{"line_number":48,"context_line":"    (\u0027matchmaker_ring\u0027, matchmaker_ring.matchmaker_opts),"},{"line_number":49,"context_line":"    (\u0027oslo_messaging_amqp\u0027, amqp_opts.amqp1_opts),"},{"line_number":50,"context_line":"    (\u0027oslo_messaging_rabbit\u0027, list(itertools.chain(amqp.amqp_opts,"},{"line_number":51,"context_line":"                                                   impl_rabbit.rabbit_opts))),"},{"line_number":52,"context_line":"    (\u0027oslo_messaging_qpid\u0027, list(itertools.chain(amqp.amqp_opts,"},{"line_number":53,"context_line":"                                                 impl_qpid.qpid_opts)))"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a961159_72412ca5","line":50,"updated":"2015-01-08 16:04:54.000000000","message":"I\u0027m sorry, I missed your last comment on this line. Please, add a comment about different amqp options for Rabbit and qpid.","commit_id":"59d6a1da3434661f3eb3a62e6b27947d75031834"}],"tests/test_opts.py":[{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"13a699fc60e8776cdfedd93a3fc2b24033f8cbb8","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        self.assertIn(\u0027matchmaker_ring\u0027, groups)"},{"line_number":37,"context_line":"        self.assertIn(\u0027matchmaker_redis\u0027, groups)"},{"line_number":38,"context_line":"        self.assertIn(\u0027oslo_messaging_amqp\u0027, groups)"},{"line_number":39,"context_line":"        self.assertIn(\u0027oslo_messaging_rabbit\u0027, groups)"},{"line_number":40,"context_line":"        self.assertIn(\u0027oslo_messaging_qpid\u0027, groups)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        opt_names \u003d [o.name for (g, l) in result for o in l]"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a961159_01b3430a","line":39,"updated":"2014-12-23 14:22:56.000000000","message":"Do we have a group for zmq?","commit_id":"38ec9c2be694b8f06fd7ce52f3946da1c5eaa319"}]}