)]}'
{"doc/source/AMQP1.0.rst":[{"author":{"_account_id":8784,"name":"Gordon Sim","email":"gsim@redhat.com","username":"gordonsim"},"change_message_id":"843083f70b1b0a2cf24f956f194e32a1dbc695ae","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"The driver also requires a *broker* that supports version 1.0 of the"},{"line_number":56,"context_line":"AMQP protocol.  Adoption of AMQP 1.0 is in its early stages, so the"},{"line_number":57,"context_line":"choice of brokers is currently limited to the Apache `qpidd`_ broker"},{"line_number":58,"context_line":"(C++ only, not the Java broker).  The version of qpidd **must** be at"},{"line_number":59,"context_line":"least 0.26.  qpidd also uses the Proton engine for its AMQP 1.0"},{"line_number":60,"context_line":"support, so the Proton library must be installed on the system hosting"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa98f980_0ffd56b1","line":57,"updated":"2014-09-12 08:35:13.000000000","message":"I think this is potentially misleading. It sounds like qpidd is the only broker with support for 1.0. If this is documenting the fact that devstack only includes support for qpidd, that should be made more clear. The intent of the driver is to work with a wide variety of AMQP 1.0 supporting intermediaries.\n\nThe driver has been tested also with Qpid Dispatch Router, and it would be nice to mention that. (I also believe it would work with Apache ActiveMQ and ApolloMQ).","commit_id":"c9daa608d398aaa77cab2e315694acac6053695b"},{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"1423a5e6e55d85b811c1ed42e7f50ca91ee702f2","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"The driver also requires a *broker* that supports version 1.0 of the"},{"line_number":56,"context_line":"AMQP protocol.  Adoption of AMQP 1.0 is in its early stages, so the"},{"line_number":57,"context_line":"choice of brokers is currently limited to the Apache `qpidd`_ broker"},{"line_number":58,"context_line":"(C++ only, not the Java broker).  The version of qpidd **must** be at"},{"line_number":59,"context_line":"least 0.26.  qpidd also uses the Proton engine for its AMQP 1.0"},{"line_number":60,"context_line":"support, so the Proton library must be installed on the system hosting"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa98f980_4603c00f","line":57,"in_reply_to":"fa98f980_0ffd56b1","updated":"2014-09-12 13:57:56.000000000","message":"The target audience for this document - I *think* - will be folks that are interested in trying the new driver in an openstack deployment, not testing the olso.messaging module in isolation.  If that\u0027s the case, we need to be clear about what messaging services have actually been used with the driver in the context of a full openstack environment.\n\nTo date, that\u0027s only been qpidd.   While we have been testing the driver against Dispatch using test apps running directly over oslo.messaging, we haven\u0027t (yet) been testing an actual openstack deployment over Dispatch.  Same for ActiveMQ/ApolloMQ (this comes next, btw).\n\nEven if the driver works perfectly with those messaging services, using those messaging services in an openstack deployment is unproven and will likely be a source of issues unrelated to the driver.\n\nIn the short term, I\u0027d like to have the community at large focus on getting the driver tested/stabilized.  I think this is best achieved by minimizing the number of new variables introduced at once.\n\nThat said, I agree that the text as it exists now seems to imply a lack of adoption of AMQP 1.0 among brokers, which really isn\u0027t the case.  I probably should add some text to that affect, and maybe point out the status of rabbitmq support.","commit_id":"c9daa608d398aaa77cab2e315694acac6053695b"},{"author":{"_account_id":8784,"name":"Gordon Sim","email":"gsim@redhat.com","username":"gordonsim"},"change_message_id":"47b7026aad1fefb51dbdf0037130a280f2a49c45","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"The driver also requires a *broker* that supports version 1.0 of the"},{"line_number":56,"context_line":"AMQP protocol.  Adoption of AMQP 1.0 is in its early stages, so the"},{"line_number":57,"context_line":"choice of brokers is currently limited to the Apache `qpidd`_ broker"},{"line_number":58,"context_line":"(C++ only, not the Java broker).  The version of qpidd **must** be at"},{"line_number":59,"context_line":"least 0.26.  qpidd also uses the Proton engine for its AMQP 1.0"},{"line_number":60,"context_line":"support, so the Proton library must be installed on the system hosting"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa98f980_01fa82bc","line":57,"in_reply_to":"fa98f980_4603c00f","updated":"2014-09-12 14:07:23.000000000","message":"I agree that its is important to be clear what has actually been tested. (I did actually test via nova against dispatch, admittedly a long time ago now, and I started the router manually rather than through the devstack scripting).\n\nInstead of:\n\n    Adoption of AMQP 1.0 is in its early stages, so the\n    choice of brokers is currently limited to the Apache\n    `qpidd`_ broker (C++ only, not the Java broker).\n\nwhat about:\n\n    Most testing to date has used the Apache qpidd broker,\n    for which support has been (or is to be?) added to devstack.\n\nThat makes it clearer that the restriction is more around what is known to work and be easier to get started.","commit_id":"c9daa608d398aaa77cab2e315694acac6053695b"},{"author":{"_account_id":8784,"name":"Gordon Sim","email":"gsim@redhat.com","username":"gordonsim"},"change_message_id":"843083f70b1b0a2cf24f956f194e32a1dbc695ae","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"The new driver can be loaded and used by existing applications by"},{"line_number":110,"context_line":"specifying *amqp* as the RPC backend in the service\u0027s configuration"},{"line_number":111,"context_line":"file.  For example, in nova.conf::"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    rpc_backend \u003d amqp"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa98f980_af20ca49","line":111,"updated":"2014-09-12 08:35:13.000000000","message":"You can also specify the transport_url","commit_id":"c9daa608d398aaa77cab2e315694acac6053695b"},{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"1423a5e6e55d85b811c1ed42e7f50ca91ee702f2","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"The new driver can be loaded and used by existing applications by"},{"line_number":110,"context_line":"specifying *amqp* as the RPC backend in the service\u0027s configuration"},{"line_number":111,"context_line":"file.  For example, in nova.conf::"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    rpc_backend \u003d amqp"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa98f980_013b62d1","line":111,"in_reply_to":"fa98f980_af20ca49","updated":"2014-09-12 13:57:56.000000000","message":"You mean at the level of the olso.messaging API, right (AFAIKT, configuration files for the services don\u0027t support a full URL syntax for addressing the broker)?   I\u0027ll add a note about the URL syntax, I think that\u0027s valuable.","commit_id":"c9daa608d398aaa77cab2e315694acac6053695b"},{"author":{"_account_id":8784,"name":"Gordon Sim","email":"gsim@redhat.com","username":"gordonsim"},"change_message_id":"8a7dc0a9dc5256c719319160ef3b93ea1c3899db","unresolved":false,"context_lines":[{"line_number":56,"context_line":"AMQP protocol."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Of the three messaging brokers currently supported by olso.messaging,"},{"line_number":59,"context_line":"only `qpidd`_ has been tested using this driver in a devstack"},{"line_number":60,"context_line":"environment, using a `patched devstack`_.  The version of qpidd"},{"line_number":61,"context_line":"**must** be at least 0.26.  qpidd also uses the Proton engine for its"},{"line_number":62,"context_line":"AMQP 1.0 support, so the Proton library must be installed on the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa98f980_a9235c56","line":59,"updated":"2014-09-12 15:31:06.000000000","message":"I would change \n\n  \"Of the three messaging brokers currently supported by olso.messaging,\n   only `qpidd`_ has been tested using this driver in a devstack environment\"\n\nto just\n\n  \"This driver has only been tested using `qpidd`_  in a `patched\n   devstack`_ environment\"","commit_id":"affe0e7f1d029ec44edd87ee09b85316973ba6b2"},{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"c5670a39c0b6ce428519cb03e8722b9609eee14a","unresolved":false,"context_lines":[{"line_number":56,"context_line":"AMQP protocol."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Of the three messaging brokers currently supported by olso.messaging,"},{"line_number":59,"context_line":"only `qpidd`_ has been tested using this driver in a devstack"},{"line_number":60,"context_line":"environment, using a `patched devstack`_.  The version of qpidd"},{"line_number":61,"context_line":"**must** be at least 0.26.  qpidd also uses the Proton engine for its"},{"line_number":62,"context_line":"AMQP 1.0 support, so the Proton library must be installed on the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa98f980_acf0cafd","line":59,"in_reply_to":"fa98f980_a9235c56","updated":"2014-09-12 15:57:22.000000000","message":"Done - thanks Gordon!","commit_id":"affe0e7f1d029ec44edd87ee09b85316973ba6b2"}]}
