)]}'
{"oslo/messaging/_drivers/impl_zmq.py":[{"author":{"_account_id":935,"name":"James Page","email":"ringo.page@gmail.com","username":"james-page"},"change_message_id":"6ebfda816acf3756aebec8d4e60383d2847d2691","unresolved":false,"context_lines":[{"line_number":492,"context_line":"        if len(sock_name) + len(topic) \u003e 107:"},{"line_number":493,"context_line":"            # NOTE(I159): The guess that length of a dir path"},{"line_number":494,"context_line":"            # and zmq prefix can\u0027t be greater than 107 - 32."},{"line_number":495,"context_line":"            return sock_name + hashlib.md5(topic).hexdigest()"},{"line_number":496,"context_line":"        return sock_name + topic"},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"    @is_there_zmq"}],"source_content_type":"text/x-python","patch_set":8,"id":"baa201ad_b09726eb","line":495,"updated":"2014-10-17 09:33:46.000000000","message":"How about we just always hash topic names? this avoids the conditional check and means all topics will look the same in /var/run/openstack.","commit_id":"b42984a49d7ebe4e26e30a9b5b3ba20c8881bee8"},{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"7236eeecc489bdba666db5bcc22b1326d73d0dee","unresolved":false,"context_lines":[{"line_number":492,"context_line":"        if len(sock_name) + len(topic) \u003e 107:"},{"line_number":493,"context_line":"            # NOTE(I159): The guess that length of a dir path"},{"line_number":494,"context_line":"            # and zmq prefix can\u0027t be greater than 107 - 32."},{"line_number":495,"context_line":"            return sock_name + hashlib.md5(topic).hexdigest()"},{"line_number":496,"context_line":"        return sock_name + topic"},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"    @is_there_zmq"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a8c0949_bb7ce221","line":495,"in_reply_to":"7a8c0949_52aa2d1a","updated":"2014-11-05 13:17:47.000000000","message":"Done","commit_id":"b42984a49d7ebe4e26e30a9b5b3ba20c8881bee8"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"d07d5b77e85b021fca622175e55eebcb73f0d556","unresolved":false,"context_lines":[{"line_number":492,"context_line":"        if len(sock_name) + len(topic) \u003e 107:"},{"line_number":493,"context_line":"            # NOTE(I159): The guess that length of a dir path"},{"line_number":494,"context_line":"            # and zmq prefix can\u0027t be greater than 107 - 32."},{"line_number":495,"context_line":"            return sock_name + hashlib.md5(topic).hexdigest()"},{"line_number":496,"context_line":"        return sock_name + topic"},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"    @is_there_zmq"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a8c0949_52aa2d1a","line":495,"in_reply_to":"baa201ad_b09726eb","updated":"2014-10-31 14:24:43.000000000","message":"Good suggestion.","commit_id":"b42984a49d7ebe4e26e30a9b5b3ba20c8881bee8"},{"author":{"_account_id":935,"name":"James Page","email":"ringo.page@gmail.com","username":"james-page"},"change_message_id":"6ebfda816acf3756aebec8d4e60383d2847d2691","unresolved":false,"context_lines":[{"line_number":515,"context_line":"                LOG.warn(emsg)"},{"line_number":516,"context_line":"                raise RPCException(emsg)"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"            out_sock \u003d ZmqSocket(self.conf, self._compose_sock_name(topic),"},{"line_number":519,"context_line":"                                 sock_type, bind\u003dTrue)"},{"line_number":520,"context_line":"        except RPCException:"},{"line_number":521,"context_line":"            waiter.send_exception(*sys.exc_info())"}],"source_content_type":"text/x-python","patch_set":8,"id":"baa201ad_308b36c4","line":518,"updated":"2014-10-17 09:33:46.000000000","message":"Note that the consuming processes will also need to complete the same _compose_sock_name call otherwise they won\u0027t get the right ipc path.","commit_id":"b42984a49d7ebe4e26e30a9b5b3ba20c8881bee8"},{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"7236eeecc489bdba666db5bcc22b1326d73d0dee","unresolved":false,"context_lines":[{"line_number":515,"context_line":"                LOG.warn(emsg)"},{"line_number":516,"context_line":"                raise RPCException(emsg)"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"            out_sock \u003d ZmqSocket(self.conf, self._compose_sock_name(topic),"},{"line_number":519,"context_line":"                                 sock_type, bind\u003dTrue)"},{"line_number":520,"context_line":"        except RPCException:"},{"line_number":521,"context_line":"            waiter.send_exception(*sys.exc_info())"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a8c0949_fb2f4a9f","line":518,"in_reply_to":"baa201ad_308b36c4","updated":"2014-11-05 13:17:47.000000000","message":"Done","commit_id":"b42984a49d7ebe4e26e30a9b5b3ba20c8881bee8"},{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"26744a5453ed17d121ee2795a831513194889fe0","unresolved":false,"context_lines":[{"line_number":451,"context_line":""},{"line_number":452,"context_line":"        self.topic_proxy \u003d {}"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"    _topics \u003d {}"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"    def _compose_sock_name(self, topic):"},{"line_number":457,"context_line":"        topic \u003d six.text_type(topic).encode(\u0027utf-8\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a890539_5fb151f7","line":454,"updated":"2014-11-11 14:30:41.000000000","message":"Please, put this to __init__ self._topics for consistency with previous.","commit_id":"d511dc872d6de599fbb34db75d7f110b752b3f9c"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"d08ab12ffae4d483c6c888df987394b4239530fb","unresolved":false,"context_lines":[{"line_number":459,"context_line":"        ipc_dir \u003d self.conf.oslo_messaging_zmq.ipc_dir"},{"line_number":460,"context_line":"        sock_name \u003d \"ipc://%s/zmq_topic_\" % ipc_dir"},{"line_number":461,"context_line":"        # NOTE(I159): The guess that length of a dir path"},{"line_number":462,"context_line":"        # and zmq prefix can\u0027t be greater than 107 - 32."},{"line_number":463,"context_line":"        self._topics[topic] \u003d sock_name + hashlib.md5(topic).hexdigest()"},{"line_number":464,"context_line":"        return self._topics[topic]"},{"line_number":465,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5a890539_58b9e213","line":462,"updated":"2014-11-15 17:44:59.000000000","message":"then why we just can\u0027t limit it explicitly here, and do not wait for failure somewhere?","commit_id":"08f31ecc5d01f50fac6f4719058b87f474d4cd23"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"d08ab12ffae4d483c6c888df987394b4239530fb","unresolved":false,"context_lines":[{"line_number":460,"context_line":"        sock_name \u003d \"ipc://%s/zmq_topic_\" % ipc_dir"},{"line_number":461,"context_line":"        # NOTE(I159): The guess that length of a dir path"},{"line_number":462,"context_line":"        # and zmq prefix can\u0027t be greater than 107 - 32."},{"line_number":463,"context_line":"        self._topics[topic] \u003d sock_name + hashlib.md5(topic).hexdigest()"},{"line_number":464,"context_line":"        return self._topics[topic]"},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"    def _publisher(self, waiter, topic):"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a890539_184afa25","line":463,"updated":"2014-11-15 17:44:59.000000000","message":"why not UUID4?\ni\u0027d say that MD5 collision probability is pretty high, so i\u0027d strongly recommend to use UUID4","commit_id":"08f31ecc5d01f50fac6f4719058b87f474d4cd23"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"8bd174ccbdaa0100995a6a6b10a20605a3fccc47","unresolved":false,"context_lines":[{"line_number":461,"context_line":"        # NOTE(I159): The guess that length of a dir path"},{"line_number":462,"context_line":"        # and zmq prefix can\u0027t be greater than 107 - 32."},{"line_number":463,"context_line":"        self._topics[topic] \u003d sock_name + hashlib.md5(topic).hexdigest()"},{"line_number":464,"context_line":"        return self._topics[topic]"},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"    def _publisher(self, waiter, topic):"},{"line_number":467,"context_line":"        LOG.info(_(\"Creating proxy for topic: %s\"), topic)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a890539_fb051f11","line":464,"updated":"2014-11-17 02:52:56.000000000","message":"Can we verify the length of the sock_name? If it exceeds the allowed value, just throw an exception.","commit_id":"08f31ecc5d01f50fac6f4719058b87f474d4cd23"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"a40359a5b478efad41c047689f0545226494b544","unresolved":false,"context_lines":[{"line_number":409,"context_line":"            path_length \u003d len(sock_path)"},{"line_number":410,"context_line":"            if path_length \u003e 107:"},{"line_number":411,"context_line":"                raise OSError(\u0027ZMQ IPC socket paths limited to 107 characters \u0027"},{"line_number":412,"context_line":"                              \u0027in length: %d\u0027 % path_length)"},{"line_number":413,"context_line":"            self._sock_paths[topic] \u003d sock_path"},{"line_number":414,"context_line":"        return self._sock_paths[topic]"},{"line_number":415,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5a890539_6116aca8","line":412,"updated":"2014-12-04 20:58:18.000000000","message":"We should include the name and value of the configuration option, because it may not be obvious to the person reading the error in the log what configuration option they need to change to fix this problem. We should also change the limit to be 107 - (the number of fixed characters we are including) so the user knows what the real limit is.","commit_id":"77915bde187f2987ba82dd6137536e8eef02c341"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"8d0ccb4c9be676403230b990e4ce0019ad2dcfc9","unresolved":false,"context_lines":[{"line_number":408,"context_line":"                str(uuid.uuid4()))"},{"line_number":409,"context_line":"            path_length \u003d len(sock_path)"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"            if path_length \u003e 107:"},{"line_number":412,"context_line":"                msg \u003d (\u0027ZMQ IPC socket paths limited to 107 characters in \u0027"},{"line_number":413,"context_line":"                       \u0027length. The overall socket name length is %d. The\u0027"},{"line_number":414,"context_line":"                       \u0027 constant part of a socket name is 53 symbols, other\u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a961159_1e5cee7d","line":411,"updated":"2014-12-10 13:07:42.000000000","message":"it seems like i can create socket path with len to 107 symbols, so, it\u0027ll be good to include upper limit.\n\n       if path_length \u003e\u003d 107\n\nAlso, IPC pathnames have a maximum size that depends on the operating system. On Linux, the maximum is 113 characters including the \"ipc://\" prefix (107 characters for the real path name). See http://api.zeromq.org/4-2:zmq-ipc","commit_id":"56f76b48394b9548356f0a7184762b8f70765bfd"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"7f387bcfa10be42ec2c9cb11c9e1789ab31f4167","unresolved":false,"context_lines":[{"line_number":408,"context_line":"                str(uuid.uuid4()))"},{"line_number":409,"context_line":"            path_length \u003d len(sock_path)"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"            if path_length \u003e 107:"},{"line_number":412,"context_line":"                msg \u003d (\u0027ZMQ IPC socket paths limited to 107 characters in \u0027"},{"line_number":413,"context_line":"                       \u0027length. The overall socket name length is %d. The\u0027"},{"line_number":414,"context_line":"                       \u0027 constant part of a socket name is 53 symbols, other\u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a961159_d42f9ef4","line":411,"in_reply_to":"3a961159_1e5cee7d","updated":"2014-12-10 16:34:43.000000000","message":"+1 this would be great to fix it.","commit_id":"56f76b48394b9548356f0a7184762b8f70765bfd"},{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"7de193785aaa9b58763b5c561fa114ac223b3865","unresolved":false,"context_lines":[{"line_number":408,"context_line":"                str(uuid.uuid4()))"},{"line_number":409,"context_line":"            path_length \u003d len(sock_path)"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"            if path_length \u003e 107:"},{"line_number":412,"context_line":"                msg \u003d (\u0027ZMQ IPC socket paths limited to 107 characters in \u0027"},{"line_number":413,"context_line":"                       \u0027length. The overall socket name length is %d. The\u0027"},{"line_number":414,"context_line":"                       \u0027 constant part of a socket name is 53 symbols, other\u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a961159_4dbf2b61","line":411,"in_reply_to":"3a961159_1e5cee7d","updated":"2014-12-24 12:21:04.000000000","message":"Thanks for pointing to the 113 symbols limit. About upper limit. As you see, I raise an error if and only if the length greater than limit. In this way I allow to use sockets with the path length equals to limit. If I\u0027ll raise an error when the length equals to the limit we loose one symbol. So `\u003e` include upper limit.","commit_id":"56f76b48394b9548356f0a7184762b8f70765bfd"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"8d0ccb4c9be676403230b990e4ce0019ad2dcfc9","unresolved":false,"context_lines":[{"line_number":409,"context_line":"            path_length \u003d len(sock_path)"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"            if path_length \u003e 107:"},{"line_number":412,"context_line":"                msg \u003d (\u0027ZMQ IPC socket paths limited to 107 characters in \u0027"},{"line_number":413,"context_line":"                       \u0027length. The overall socket name length is %d. The\u0027"},{"line_number":414,"context_line":"                       \u0027 constant part of a socket name is 53 symbols, other\u0027"},{"line_number":415,"context_line":"                       \u0027 part is a path to socket. Please, check the config\u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a961159_7ed7b2bf","line":412,"updated":"2014-12-10 13:07:42.000000000","message":"limited to 113 with \"ipc://\" prefix","commit_id":"56f76b48394b9548356f0a7184762b8f70765bfd"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"8d0ccb4c9be676403230b990e4ce0019ad2dcfc9","unresolved":false,"context_lines":[{"line_number":414,"context_line":"                       \u0027 constant part of a socket name is 53 symbols, other\u0027"},{"line_number":415,"context_line":"                       \u0027 part is a path to socket. Please, check the config\u0027"},{"line_number":416,"context_line":"                       \u0027 option: group - oslo_messaging_zmq, opt name - \u0027"},{"line_number":417,"context_line":"                       \u0027ipc_dir\u0027)"},{"line_number":418,"context_line":"                raise OSError(msg % path_length)"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"            self._sock_paths[topic] \u003d sock_path"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a961159_9efd3e3d","line":417,"updated":"2014-12-10 13:07:42.000000000","message":"missing period","commit_id":"56f76b48394b9548356f0a7184762b8f70765bfd"},{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"7de193785aaa9b58763b5c561fa114ac223b3865","unresolved":false,"context_lines":[{"line_number":414,"context_line":"                       \u0027 constant part of a socket name is 53 symbols, other\u0027"},{"line_number":415,"context_line":"                       \u0027 part is a path to socket. Please, check the config\u0027"},{"line_number":416,"context_line":"                       \u0027 option: group - oslo_messaging_zmq, opt name - \u0027"},{"line_number":417,"context_line":"                       \u0027ipc_dir\u0027)"},{"line_number":418,"context_line":"                raise OSError(msg % path_length)"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"            self._sock_paths[topic] \u003d sock_path"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a961159_cd795bc9","line":417,"in_reply_to":"3a961159_9efd3e3d","updated":"2014-12-24 12:21:04.000000000","message":"What the period are you talking about? Please, describe.","commit_id":"56f76b48394b9548356f0a7184762b8f70765bfd"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"c037a39ebb462764ee502fe5a707497934c69ffa","unresolved":false,"context_lines":[{"line_number":414,"context_line":"                       \u0027 constant part of a socket name is 53 symbols, other\u0027"},{"line_number":415,"context_line":"                       \u0027 part is a path to socket. Please, check the config\u0027"},{"line_number":416,"context_line":"                       \u0027 option: group - oslo_messaging_zmq, opt name - \u0027"},{"line_number":417,"context_line":"                       \u0027ipc_dir\u0027)"},{"line_number":418,"context_line":"                raise OSError(msg % path_length)"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"            self._sock_paths[topic] \u003d sock_path"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a961159_b22366a6","line":417,"in_reply_to":"3a961159_cd795bc9","updated":"2014-12-26 11:33:20.000000000","message":"this is a sentence, sentence should have punctuation. So, end of this sentence should be a period(dot) - \"ipc_dir.\"","commit_id":"56f76b48394b9548356f0a7184762b8f70765bfd"},{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"5b32dc8d60aacc1c0ee1d6de42fa6db1fedfddee","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    return wrap"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"class Topic(object):"},{"line_number":96,"context_line":"    _value \u003d None"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def __init__(self, conf, seed\u003dNone):"}],"source_content_type":"text/x-python","patch_set":16,"id":"3a961159_0a59538e","line":95,"updated":"2014-12-29 11:21:54.000000000","message":"You introduced a new entity to the API. Please provide a short description on what is it for in a doc-comments.","commit_id":"db9095367c8e70dbf036e15bfeffcfcde5252535"},{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"5b32dc8d60aacc1c0ee1d6de42fa6db1fedfddee","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"class Topic(object):"},{"line_number":96,"context_line":"    _value \u003d None"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def __init__(self, conf, seed\u003dNone):"},{"line_number":99,"context_line":"        self.conf \u003d conf"}],"source_content_type":"text/x-python","patch_set":16,"id":"3a961159_aa1bdfc8","line":96,"updated":"2014-12-29 11:21:54.000000000","message":"This is not needed.","commit_id":"db9095367c8e70dbf036e15bfeffcfcde5252535"},{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"5b32dc8d60aacc1c0ee1d6de42fa6db1fedfddee","unresolved":false,"context_lines":[{"line_number":95,"context_line":"class Topic(object):"},{"line_number":96,"context_line":"    _value \u003d None"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def __init__(self, conf, seed\u003dNone):"},{"line_number":99,"context_line":"        self.conf \u003d conf"},{"line_number":100,"context_line":"        # NOTE(I159): the value of topic could be \u0027\u0027. It can cause a problem"},{"line_number":101,"context_line":"        self._value \u003d hashlib.md5(seed).hexdigest() if seed else self._value"}],"source_content_type":"text/x-python","patch_set":16,"id":"3a961159_6ad657c5","line":98,"updated":"2014-12-29 11:21:54.000000000","message":"\"Seed\" is not a good name for the parameter, because it has meaning for hash (which is implementation detail not visible outside the topic), but not for a topic. It\u0027s rather a topic name.","commit_id":"db9095367c8e70dbf036e15bfeffcfcde5252535"},{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"5b32dc8d60aacc1c0ee1d6de42fa6db1fedfddee","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    def __init__(self, conf, seed\u003dNone):"},{"line_number":99,"context_line":"        self.conf \u003d conf"},{"line_number":100,"context_line":"        # NOTE(I159): the value of topic could be \u0027\u0027. It can cause a problem"},{"line_number":101,"context_line":"        self._value \u003d hashlib.md5(seed).hexdigest() if seed else self._value"},{"line_number":102,"context_line":"        if seed and \u0027.\u0027 in seed:"},{"line_number":103,"context_line":"            self._value \u003d self._set_dot()"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3a961159_ca774b07","line":101,"updated":"2014-12-29 11:21:54.000000000","message":"self._value \u003d hashlib.md5(seed).hexdigest() if seed else None","commit_id":"db9095367c8e70dbf036e15bfeffcfcde5252535"},{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"5b32dc8d60aacc1c0ee1d6de42fa6db1fedfddee","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        return \u0027\u0027.join([i for i in self._value])"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def set_with_dash(self):"},{"line_number":117,"context_line":"        self._value \u003d self._value.replace(\u0027.\u0027, \u0027-\u0027, 1)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    @_copy_topic_instance"},{"line_number":120,"context_line":"    def get_fanout(self):"}],"source_content_type":"text/x-python","patch_set":16,"id":"3a961159_6a8497b1","line":117,"updated":"2014-12-29 11:21:54.000000000","message":"I don\u0027t understand, if the self._value is a hash, how can string operations make sense here?\n\nIf you\u0027d like to keep the possibility of changing the value of the topic you need to keep the original string value and rehash it each time after the string is changed.\n\nThe better way is not to get the hash at start in the constructor, but to have a method to provide it by request.","commit_id":"db9095367c8e70dbf036e15bfeffcfcde5252535"},{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"5b32dc8d60aacc1c0ee1d6de42fa6db1fedfddee","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        return self"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    @_copy_topic_instance"},{"line_number":136,"context_line":"    def priorytize(self, priority):"},{"line_number":137,"context_line":"        self._value \u003d \"%s-%s\" % ("},{"line_number":138,"context_line":"            self._value, priority) if self._value else None"},{"line_number":139,"context_line":"        return self"}],"source_content_type":"text/x-python","patch_set":16,"id":"3a961159_cadbcb1f","line":136,"updated":"2014-12-29 11:21:54.000000000","message":"spelling? prioritize?","commit_id":"db9095367c8e70dbf036e15bfeffcfcde5252535"},{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"5b32dc8d60aacc1c0ee1d6de42fa6db1fedfddee","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        return self._value.startswith(\u0027zmq_replies\u0027)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"class TopicDescriptor(object):"},{"line_number":160,"context_line":"    \"\"\"Base topic as unique value with the length of 32 symbols."},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    To standardize topics management a topic should be unique and has a"}],"source_content_type":"text/x-python","patch_set":16,"id":"3a961159_aa2aff8d","line":159,"updated":"2014-12-29 11:21:54.000000000","message":"The purpose of this entity is not clear for me. IMHO, it is redundant. As I mentioned above you need to keep the \"seed\" (which I recommend to rename) in Topic to make sense for string operations.","commit_id":"db9095367c8e70dbf036e15bfeffcfcde5252535"},{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"5b32dc8d60aacc1c0ee1d6de42fa6db1fedfddee","unresolved":false,"context_lines":[{"line_number":502,"context_line":"            s.close()"},{"line_number":503,"context_line":""},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"_IPC_INADDRS \u003d {}"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"def _get_ipc_addr(conf, topic):"}],"source_content_type":"text/x-python","patch_set":16,"id":"3a961159_057b047c","line":505,"updated":"2014-12-29 11:21:54.000000000","message":"This cache dictionary in pair of _get_ipc_addr tends to be a TopicsManager entity arranged into a class.","commit_id":"db9095367c8e70dbf036e15bfeffcfcde5252535"}]}
