)]}'
{"tests/functional/utils.py":[{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"65520ce947206de124d986f5f2787b45b8ba6398","unresolved":false,"context_lines":[{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    def _test_connection(self):"},{"line_number":278,"context_line":"        scheme, url_without_scheme \u003d self.url.split(\":\", 1)"},{"line_number":279,"context_line":"        if scheme in [\"rabbit\", \"qpid\"]:"},{"line_number":280,"context_line":"            conn \u003d kombu.connection.BrokerConnection("},{"line_number":281,"context_line":"                \"amqp:\" + url_without_scheme)"},{"line_number":282,"context_line":"            conn.connect()"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8c0949_e835e846","line":279,"updated":"2014-10-31 15:22:09.000000000","message":"Should \u0027amqp\u0027 be included in this list of schemes?   We\u0027re still talking to a qpidd broker in the case of scheme\u003d\u003damqp, so the kombu check should work.","commit_id":"43c7bc9081ade0772ea5e450780b606e77f136c5"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"01bf655f1607be5ad0bc096bd195dff5f06335e4","unresolved":false,"context_lines":[{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    def _test_connection(self):"},{"line_number":278,"context_line":"        scheme, url_without_scheme \u003d self.url.split(\":\", 1)"},{"line_number":279,"context_line":"        if scheme in [\"rabbit\", \"qpid\"]:"},{"line_number":280,"context_line":"            conn \u003d kombu.connection.BrokerConnection("},{"line_number":281,"context_line":"                \"amqp:\" + url_without_scheme)"},{"line_number":282,"context_line":"            conn.connect()"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8c0949_bb031e0e","line":279,"in_reply_to":"7a8c0949_660f6431","updated":"2014-11-03 06:31:25.000000000","message":"Done","commit_id":"43c7bc9081ade0772ea5e450780b606e77f136c5"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"3889c9f2234aa80f064d1597f9fec66dd1d863d2","unresolved":false,"context_lines":[{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    def _test_connection(self):"},{"line_number":278,"context_line":"        scheme, url_without_scheme \u003d self.url.split(\":\", 1)"},{"line_number":279,"context_line":"        if scheme in [\"rabbit\", \"qpid\"]:"},{"line_number":280,"context_line":"            conn \u003d kombu.connection.BrokerConnection("},{"line_number":281,"context_line":"                \"amqp:\" + url_without_scheme)"},{"line_number":282,"context_line":"            conn.connect()"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8c0949_660f6431","line":279,"in_reply_to":"7a8c0949_e835e846","updated":"2014-10-31 18:15:42.000000000","message":"fair enough, I guess we could add it.","commit_id":"43c7bc9081ade0772ea5e450780b606e77f136c5"},{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"e133cd8943c0214cfc99f507680c9c5d06f61747","unresolved":false,"context_lines":[{"line_number":278,"context_line":"        scheme, url_without_scheme \u003d self.url.split(\":\", 1)"},{"line_number":279,"context_line":"        if scheme in [\"rabbit\", \"qpid\", \"amqp\"]:"},{"line_number":280,"context_line":"            conn \u003d kombu.connection.BrokerConnection("},{"line_number":281,"context_line":"                \"amqp:\" + url_without_scheme)"},{"line_number":282,"context_line":"            conn.connect()"},{"line_number":283,"context_line":"            conn.release()"},{"line_number":284,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8c0949_117dd5b1","line":281,"updated":"2014-11-05 14:02:50.000000000","message":"Why do you use only amqp? Isn\u0027t it possible to have broken connection for others schemes?","commit_id":"8ce80b6cd6f37387ce7a580d78303f6279cb2347"},{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"ba9297bd12cc5f4121ab0f1634bd19dba7222bc3","unresolved":false,"context_lines":[{"line_number":278,"context_line":"        scheme, url_without_scheme \u003d self.url.split(\":\", 1)"},{"line_number":279,"context_line":"        if scheme in [\"rabbit\", \"qpid\", \"amqp\"]:"},{"line_number":280,"context_line":"            conn \u003d kombu.connection.BrokerConnection("},{"line_number":281,"context_line":"                \"amqp:\" + url_without_scheme)"},{"line_number":282,"context_line":"            conn.connect()"},{"line_number":283,"context_line":"            conn.release()"},{"line_number":284,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8c0949_b9bf7ffa","line":281,"in_reply_to":"7a8c0949_0ae11a9a","updated":"2014-11-06 09:08:09.000000000","message":"I see. Let move the list of drivers names to a property with the note which you provided in the comment. In this way it will be more clear that we need to modify only the list.\n\nAnd one more clarification. My comment is about BrokerConnection argument. Don\u0027t we need to try to connect with all the schemes?","commit_id":"8ce80b6cd6f37387ce7a580d78303f6279cb2347"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"cf543cd8115edd4784015e4078606d15a592f2ba","unresolved":false,"context_lines":[{"line_number":278,"context_line":"        scheme, url_without_scheme \u003d self.url.split(\":\", 1)"},{"line_number":279,"context_line":"        if scheme in [\"rabbit\", \"qpid\", \"amqp\"]:"},{"line_number":280,"context_line":"            conn \u003d kombu.connection.BrokerConnection("},{"line_number":281,"context_line":"                \"amqp:\" + url_without_scheme)"},{"line_number":282,"context_line":"            conn.connect()"},{"line_number":283,"context_line":"            conn.release()"},{"line_number":284,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8c0949_0ae11a9a","line":281,"in_reply_to":"7a8c0949_117dd5b1","updated":"2014-11-05 16:33:36.000000000","message":"Sure but I can test only this three driver with the kombu BrokerConnection, so I limit it to them.\n\nFor zmq or a future new driver if you want check if something is available, you have to add more code here, but this is not the purpose of this changes.","commit_id":"8ce80b6cd6f37387ce7a580d78303f6279cb2347"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"c1b8a35d2f4ae067bd80ef3844b5450192631caa","unresolved":false,"context_lines":[{"line_number":278,"context_line":"        scheme, url_without_scheme \u003d self.url.split(\":\", 1)"},{"line_number":279,"context_line":"        if scheme in [\"rabbit\", \"qpid\", \"amqp\"]:"},{"line_number":280,"context_line":"            conn \u003d kombu.connection.BrokerConnection("},{"line_number":281,"context_line":"                \"amqp:\" + url_without_scheme)"},{"line_number":282,"context_line":"            conn.connect()"},{"line_number":283,"context_line":"            conn.release()"},{"line_number":284,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_678ff22a","line":281,"in_reply_to":"7a8c0949_7f42573f","updated":"2014-11-14 14:56:48.000000000","message":"Done","commit_id":"8ce80b6cd6f37387ce7a580d78303f6279cb2347"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"28378e7faf2ecae736d383e7f50beb66b0cda0e5","unresolved":false,"context_lines":[{"line_number":278,"context_line":"        scheme, url_without_scheme \u003d self.url.split(\":\", 1)"},{"line_number":279,"context_line":"        if scheme in [\"rabbit\", \"qpid\", \"amqp\"]:"},{"line_number":280,"context_line":"            conn \u003d kombu.connection.BrokerConnection("},{"line_number":281,"context_line":"                \"amqp:\" + url_without_scheme)"},{"line_number":282,"context_line":"            conn.connect()"},{"line_number":283,"context_line":"            conn.release()"},{"line_number":284,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8c0949_7f42573f","line":281,"in_reply_to":"7a8c0949_b9bf7ffa","updated":"2014-11-06 10:18:52.000000000","message":"Yep good idea I will move the list as class variable with a note.\n\nFor why I replace the scheme by \u0027amqp\u0027, this is because the scheme in the url is the \u0027oslo.msg\u0027 driver name, and this name differs from the \u0027kombu\u0027 driver name.\n\nAnd to connect to rabbit or qpid with kombu you have to use amqp:// (or to hardcode the underlying library that kombu will use to connect to the broker, like librabbitmq/pyamqp/qpid/...)","commit_id":"8ce80b6cd6f37387ce7a580d78303f6279cb2347"},{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"e133cd8943c0214cfc99f507680c9c5d06f61747","unresolved":false,"context_lines":[{"line_number":280,"context_line":"            conn \u003d kombu.connection.BrokerConnection("},{"line_number":281,"context_line":"                \"amqp:\" + url_without_scheme)"},{"line_number":282,"context_line":"            conn.connect()"},{"line_number":283,"context_line":"            conn.release()"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"class NotificationFixture(fixtures.Fixture):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8c0949_942453b0","line":283,"updated":"2014-11-05 14:02:50.000000000","message":"We just invoke it and if it is broken don\u0027t we need some error wrapper for the error?","commit_id":"8ce80b6cd6f37387ce7a580d78303f6279cb2347"},{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"ba9297bd12cc5f4121ab0f1634bd19dba7222bc3","unresolved":false,"context_lines":[{"line_number":280,"context_line":"            conn \u003d kombu.connection.BrokerConnection("},{"line_number":281,"context_line":"                \"amqp:\" + url_without_scheme)"},{"line_number":282,"context_line":"            conn.connect()"},{"line_number":283,"context_line":"            conn.release()"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"class NotificationFixture(fixtures.Fixture):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8c0949_79b0b743","line":283,"in_reply_to":"7a8c0949_2aefb688","updated":"2014-11-06 09:08:09.000000000","message":"Reasonably, I\u0027m good with it.","commit_id":"8ce80b6cd6f37387ce7a580d78303f6279cb2347"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"cf543cd8115edd4784015e4078606d15a592f2ba","unresolved":false,"context_lines":[{"line_number":280,"context_line":"            conn \u003d kombu.connection.BrokerConnection("},{"line_number":281,"context_line":"                \"amqp:\" + url_without_scheme)"},{"line_number":282,"context_line":"            conn.connect()"},{"line_number":283,"context_line":"            conn.release()"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"class NotificationFixture(fixtures.Fixture):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8c0949_2aefb688","line":283,"in_reply_to":"7a8c0949_942453b0","updated":"2014-11-05 16:33:36.000000000","message":"No the goals is to have a backtrace to see why we cannot connect to the broken.","commit_id":"8ce80b6cd6f37387ce7a580d78303f6279cb2347"},{"author":{"_account_id":8784,"name":"Gordon Sim","email":"gsim@redhat.com","username":"gordonsim"},"change_message_id":"a509c9a84ab803c27eeb2e7f514e997748dfdab6","unresolved":false,"context_lines":[{"line_number":267,"context_line":""},{"line_number":268,"context_line":"OSLOMSG_TO_KOMBU_DRIVER_MAPPING \u003d {"},{"line_number":269,"context_line":"    \u0027rabbit\u0027: \u0027amqp\u0027,"},{"line_number":270,"context_line":"    \u0027qpid\u0027: \u0027amqp\u0027,"},{"line_number":271,"context_line":"    \u0027amqp\u0027: \u0027amqp\u0027"},{"line_number":272,"context_line":"}"},{"line_number":273,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a890539_aa70bfdc","line":270,"updated":"2014-11-14 15:28:51.000000000","message":"Will this work? qpidd will support AMQP 0-10 fo rthe impl_qpid.py driver. While support for that has recently been added to kombu, will it not require a different url (i.e. keep the qpid scheme)? AFAIK, the amqp scheme/transport in kombu is strictly AMQP 0-9-1 (which qpidd does not support)","commit_id":"eedb5037e4102da6683820ccc76a946c611811f3"},{"author":{"_account_id":8784,"name":"Gordon Sim","email":"gsim@redhat.com","username":"gordonsim"},"change_message_id":"a509c9a84ab803c27eeb2e7f514e997748dfdab6","unresolved":false,"context_lines":[{"line_number":268,"context_line":"OSLOMSG_TO_KOMBU_DRIVER_MAPPING \u003d {"},{"line_number":269,"context_line":"    \u0027rabbit\u0027: \u0027amqp\u0027,"},{"line_number":270,"context_line":"    \u0027qpid\u0027: \u0027amqp\u0027,"},{"line_number":271,"context_line":"    \u0027amqp\u0027: \u0027amqp\u0027"},{"line_number":272,"context_line":"}"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a890539_6a1fb76c","line":271,"updated":"2014-11-14 15:28:51.000000000","message":"There is no reliable way to test AMQP 1.0 support via kombu at present. You could test AMQP 0-10, which if successful would at least likely confirm the presence of a Qpid broker, but not necessarily that AMQP 1.0 support is enabled.","commit_id":"eedb5037e4102da6683820ccc76a946c611811f3"}]}