)]}'
{"oslo/messaging/_drivers/amqpdriver.py":[{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"e6053945e866e710654a467cd0472c2df25f9556","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        self.conn \u003d conn"},{"line_number":95,"context_line":"        self.msg_id_cache \u003d rpc_amqp._MsgIdCache()"},{"line_number":96,"context_line":"        self.incoming \u003d []"},{"line_number":97,"context_line":"        self._dispatch_callbacks \u003d moves.queue.Queue()"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def __call__(self, message):"},{"line_number":100,"context_line":"        # FIXME(markmc): logging isn\u0027t driver specific"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_d29c21c3","line":97,"updated":"2014-11-13 07:40:39.000000000","message":"So I\u0027d avoid doing the direct usage of \u0027moves\u0027 from six.\n\nhttps://bitbucket.org/gutworth/six/issue/98/periodically-able-to-cause-moved-functions\n\nThat was fixed (I don\u0027t think its been released yet) but it just seems safer to do something like the following at the top of the module:\n\n  from six.moves import queue as compat_queue","commit_id":"2a77c75fe4ae3203a4f40e20297023bdb98e85bd"},{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"ea22c42e59a3d965a815fbc4292479cd1b5eb2fc","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        self.conn \u003d conn"},{"line_number":95,"context_line":"        self.msg_id_cache \u003d rpc_amqp._MsgIdCache()"},{"line_number":96,"context_line":"        self.incoming \u003d []"},{"line_number":97,"context_line":"        self._dispatch_callbacks \u003d moves.queue.Queue()"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def __call__(self, message):"},{"line_number":100,"context_line":"        # FIXME(markmc): logging isn\u0027t driver specific"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_a66d939a","line":97,"in_reply_to":"5a890539_d29c21c3","updated":"2014-11-13 13:12:29.000000000","message":"Done","commit_id":"2a77c75fe4ae3203a4f40e20297023bdb98e85bd"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"e6053945e866e710654a467cd0472c2df25f9556","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            deadline \u003d None"},{"line_number":118,"context_line":"        while True:"},{"line_number":119,"context_line":"            for callback in self._drain_dispatch_callbacks():"},{"line_number":120,"context_line":"                callback()  # Send ack/requeue from processed messages"},{"line_number":121,"context_line":"            if self.incoming:"},{"line_number":122,"context_line":"                return self.incoming.pop(0)"},{"line_number":123,"context_line":"            if deadline is not None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_f2783d91","line":120,"updated":"2014-11-13 07:40:39.000000000","message":"Do you care if the callback raises an exception? Should those be caught and handled appropriatly?","commit_id":"2a77c75fe4ae3203a4f40e20297023bdb98e85bd"},{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"ea22c42e59a3d965a815fbc4292479cd1b5eb2fc","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            deadline \u003d None"},{"line_number":118,"context_line":"        while True:"},{"line_number":119,"context_line":"            for callback in self._drain_dispatch_callbacks():"},{"line_number":120,"context_line":"                callback()  # Send ack/requeue from processed messages"},{"line_number":121,"context_line":"            if self.incoming:"},{"line_number":122,"context_line":"                return self.incoming.pop(0)"},{"line_number":123,"context_line":"            if deadline is not None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_f70907de","line":120,"in_reply_to":"5a890539_f2783d91","updated":"2014-11-13 13:12:29.000000000","message":"Well, the situation is not clear to me yet. I don\u0027t know, what kind of callback error we should catch and handle? And I think we shouldn\u0027t catch all exceptions. I\u0027d rather raise exceptions and fix problems in callbacks. Any ideas about what should we catch?","commit_id":"2a77c75fe4ae3203a4f40e20297023bdb98e85bd"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"585d45d7cefae82e5db25ae3a823906051d4c0ca","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            deadline \u003d None"},{"line_number":118,"context_line":"        while True:"},{"line_number":119,"context_line":"            for callback in self._drain_dispatch_callbacks():"},{"line_number":120,"context_line":"                callback()  # Send ack/requeue from processed messages"},{"line_number":121,"context_line":"            if self.incoming:"},{"line_number":122,"context_line":"                return self.incoming.pop(0)"},{"line_number":123,"context_line":"            if deadline is not None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_6ff17c00","line":120,"in_reply_to":"5a890539_f70907de","updated":"2014-11-14 21:41:38.000000000","message":"I\u0027m not sure either, but if a callback does throw then it seems like the poll loop would break/stop, which seems bad right?","commit_id":"2a77c75fe4ae3203a4f40e20297023bdb98e85bd"}],"oslo/messaging/_executors/impl_blocking.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"ef036daf9c03d9a2e7409cb05697422708cc33fb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 Red Hat, Inc."},{"line_number":2,"context_line":"# Copyright 2013 New Dream Network, LLC (DreamHost)"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":6,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_4311dc50","side":"PARENT","line":3,"updated":"2014-11-17 14:21:26.000000000","message":"i\u0027m not quite sure if it\u0027s legal, we can\u0027t change copyright in headers","commit_id":"6eb0d2ff800089e56ac4bfd2f3b510749d55e9ce"},{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"a62863b83184ea24edf474474fe52edc61df67ac","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 Red Hat, Inc."},{"line_number":2,"context_line":"# Copyright 2013 New Dream Network, LLC (DreamHost)"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":6,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_6693a2fa","side":"PARENT","line":3,"in_reply_to":"5a890539_4311dc50","updated":"2014-12-01 14:24:20.000000000","message":"I is accident. I\u0027ll fix it.","commit_id":"6eb0d2ff800089e56ac4bfd2f3b510749d55e9ce"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"c7b269cf36a21754edb166f4ae08a1f13e6a56b4","unresolved":false,"context_lines":[{"line_number":14,"context_line":"class Executor(object):"},{"line_number":15,"context_line":"    \"\"\"A message executor which blocks the current thread."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    The blocking executor\u0027s start() method functions as a request processing"},{"line_number":18,"context_line":"    loop - i.e. it blocks, processes messages and only returns when stop() is"},{"line_number":19,"context_line":"    called from a dispatched method."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_2f7bf4f5","line":17,"updated":"2014-11-14 22:08:55.000000000","message":"This comment doesn\u0027t seem applicable anymore :)","commit_id":"9e377408da220ffb67105c407f7f22093f01f95c"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"ed0d0ae6c35d16603d02705a639c9ea511a8399d","unresolved":false,"context_lines":[{"line_number":14,"context_line":"class Executor(object):"},{"line_number":15,"context_line":"    \"\"\"A message executor which blocks the current thread."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    The blocking executor\u0027s start() method functions as a request processing"},{"line_number":18,"context_line":"    loop - i.e. it blocks, processes messages and only returns when stop() is"},{"line_number":19,"context_line":"    called from a dispatched method."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_789dbebb","line":17,"in_reply_to":"5a890539_2f7bf4f5","updated":"2014-11-15 17:24:00.000000000","message":"+1","commit_id":"9e377408da220ffb67105c407f7f22093f01f95c"},{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"a62863b83184ea24edf474474fe52edc61df67ac","unresolved":false,"context_lines":[{"line_number":14,"context_line":"class Executor(object):"},{"line_number":15,"context_line":"    \"\"\"A message executor which blocks the current thread."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    The blocking executor\u0027s start() method functions as a request processing"},{"line_number":18,"context_line":"    loop - i.e. it blocks, processes messages and only returns when stop() is"},{"line_number":19,"context_line":"    called from a dispatched method."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_3ced4a8f","line":17,"in_reply_to":"5a890539_2f7bf4f5","updated":"2014-12-01 14:24:20.000000000","message":"Done","commit_id":"9e377408da220ffb67105c407f7f22093f01f95c"}],"oslo/messaging/_executors/impl_eventlet.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"ef036daf9c03d9a2e7409cb05697422708cc33fb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 Red Hat, Inc."},{"line_number":2,"context_line":"# Copyright 2013 New Dream Network, LLC (DreamHost)"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":6,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_233851ee","side":"PARENT","line":3,"updated":"2014-11-17 14:21:26.000000000","message":"i\u0027m not quite sure if it\u0027s legal, we can\u0027t change copyright in headers","commit_id":"6eb0d2ff800089e56ac4bfd2f3b510749d55e9ce"},{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"a62863b83184ea24edf474474fe52edc61df67ac","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 Red Hat, Inc."},{"line_number":2,"context_line":"# Copyright 2013 New Dream Network, LLC (DreamHost)"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":6,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_dcfb6646","side":"PARENT","line":3,"in_reply_to":"5a890539_233851ee","updated":"2014-12-01 14:24:20.000000000","message":"Done","commit_id":"6eb0d2ff800089e56ac4bfd2f3b510749d55e9ce"}],"oslo/messaging/server.py":[{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"e6053945e866e710654a467cd0472c2df25f9556","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def start(self):"},{"line_number":76,"context_line":"        \"\"\"Start handling incoming messages."},{"line_number":77,"context_line":"        \"\"\""},{"line_number":78,"context_line":"        if self._start_thread:"},{"line_number":79,"context_line":"            super(MessageHandlingServer, self).start()"},{"line_number":80,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_52c5918c","line":77,"updated":"2014-11-13 07:40:39.000000000","message":"This part here makes me wonder why we have this class deriving from threading.Thread; if the code may not be used in a thread in all circumstances it doesn\u0027t seem to make sense to have it derive from the thread base class in all circumstances...","commit_id":"2a77c75fe4ae3203a4f40e20297023bdb98e85bd"},{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"ea22c42e59a3d965a815fbc4292479cd1b5eb2fc","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    def start(self):"},{"line_number":76,"context_line":"        \"\"\"Start handling incoming messages."},{"line_number":77,"context_line":"        \"\"\""},{"line_number":78,"context_line":"        if self._start_thread:"},{"line_number":79,"context_line":"            super(MessageHandlingServer, self).start()"},{"line_number":80,"context_line":"        else:"},{"line_number":81,"context_line":"            self.run()"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_60e38a05","line":78,"updated":"2014-11-13 13:12:29.000000000","message":"Unfortunately this code is not mine. So I need a bit of descriptions too. I agree with you, this snippet looks weird. I\u0027ll rid this logic.","commit_id":"2a77c75fe4ae3203a4f40e20297023bdb98e85bd"}],"oslo/messaging/transport.py":[{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"ac93c8544b1814a4cc876a11395fbb57072e021b","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                                               \u0027topic and server specified\u0027,"},{"line_number":107,"context_line":"                                               target)"},{"line_number":108,"context_line":"        else:"},{"line_number":109,"context_line":"            for t, _ in target:"},{"line_number":110,"context_line":"                if not t.topic:"},{"line_number":111,"context_line":"                    raise exceptions.InvalidTarget(\u0027A target must have \u0027"},{"line_number":112,"context_line":"                                                   \u0027topic specified\u0027, t)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_394e4197","line":109,"updated":"2014-11-12 15:20:07.000000000","message":"Seems like we don\u0027t need the _ here at all.","commit_id":"2a77c75fe4ae3203a4f40e20297023bdb98e85bd"},{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"9d5bf8c4d3896ca596b265db83fc7d34a40b3d87","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                                               \u0027topic and server specified\u0027,"},{"line_number":107,"context_line":"                                               target)"},{"line_number":108,"context_line":"        else:"},{"line_number":109,"context_line":"            for t, _ in target:"},{"line_number":110,"context_line":"                if not t.topic:"},{"line_number":111,"context_line":"                    raise exceptions.InvalidTarget(\u0027A target must have \u0027"},{"line_number":112,"context_line":"                                                   \u0027topic specified\u0027, t)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_28b5f2cc","line":109,"in_reply_to":"5a890539_394e4197","updated":"2014-11-13 09:21:15.000000000","message":"Done","commit_id":"2a77c75fe4ae3203a4f40e20297023bdb98e85bd"}],"tests/rpc/test_server.py":[{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"ac93c8544b1814a4cc876a11395fbb57072e021b","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        server \u003d messaging.get_rpc_server(transport, target, endpoints,"},{"line_number":121,"context_line":"                                          serializer\u003dserializer)"},{"line_number":122,"context_line":"        with mock.patch.object("},{"line_number":123,"context_line":"                server, \u0027dispatcher\u0027, autospec\u003dTrue) as dispatcher:"},{"line_number":124,"context_line":"            dispatcher.wait \u003d mock.Mock()"},{"line_number":125,"context_line":"            with mock.patch.object(server, \u0027join\u0027) as join:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_5c213b9e","line":122,"updated":"2014-11-12 15:20:07.000000000","message":"Can we reduce nested with blocks here by using mock decorators?","commit_id":"2a77c75fe4ae3203a4f40e20297023bdb98e85bd"},{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"9d5bf8c4d3896ca596b265db83fc7d34a40b3d87","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        server \u003d messaging.get_rpc_server(transport, target, endpoints,"},{"line_number":121,"context_line":"                                          serializer\u003dserializer)"},{"line_number":122,"context_line":"        with mock.patch.object("},{"line_number":123,"context_line":"                server, \u0027dispatcher\u0027, autospec\u003dTrue) as dispatcher:"},{"line_number":124,"context_line":"            dispatcher.wait \u003d mock.Mock()"},{"line_number":125,"context_line":"            with mock.patch.object(server, \u0027join\u0027) as join:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_68cd3a5d","line":122,"in_reply_to":"5a890539_5c213b9e","updated":"2014-11-13 09:21:15.000000000","message":"Done","commit_id":"2a77c75fe4ae3203a4f40e20297023bdb98e85bd"}]}
