)]}'
{"oslo/messaging/_drivers/protocols/amqp/eventloop.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"9583eef1f1c86d7e6c756114035d24887f2e0224","unresolved":false,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"        # Configure a container"},{"line_number":232,"context_line":"        if container_name is None:"},{"line_number":233,"context_line":"            container_name \u003d \"Container-\" + uuid.uuid4().hex"},{"line_number":234,"context_line":"        self._container \u003d pyngus.Container(container_name)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        self.name \u003d \"Thread for Proton container: %s\" % self._container.name"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_58464250","line":233,"updated":"2014-11-15 17:16:21.000000000","message":"Just as an example from previous file, i wonder why do you choose here to use simple construction \"Container\", but in previous file i\u0027ve picked something a bit different.","commit_id":"50aa7363d39e9b99662f7804e61c173bbf015c3d"},{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"30260faa086f272f8112d40fb45aaed0f299ff3c","unresolved":false,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"        # Configure a container"},{"line_number":232,"context_line":"        if container_name is None:"},{"line_number":233,"context_line":"            container_name \u003d \"Container-\" + uuid.uuid4().hex"},{"line_number":234,"context_line":"        self._container \u003d pyngus.Container(container_name)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        self.name \u003d \"Thread for Proton container: %s\" % self._container.name"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_86c2f250","line":233,"in_reply_to":"5a890539_58464250","updated":"2014-11-17 14:55:57.000000000","message":"Hi Denis,\n\nThere\u0027s a number of places where we end up using random uuids to name stuff like connections and links just as a simple way of guaranteeing uniqueness.  The problem with this is when viewing these items using a management tool (like qpid-stat, for instance), it\u0027s hard to correlate when the uuid is identifying without adding a bit more detail to the name.  So I\u0027ve added human-readable prefixes to the uuids, like \"Producer-/Consumer-\" for links and \"Container-\" to containers.   Just to give us a little clue (and to help when we look through the logs).   Prior to this patch, we never really hit line #233, since the controller would always pass in a generated container name - it was never None - and that name also contained the prefix \"container-\"","commit_id":"50aa7363d39e9b99662f7804e61c173bbf015c3d"}]}
