)]}'
{"oslo/messaging/rpc/dispatcher.py":[{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"58de43bca3d2f378f5bfcb39bcd49f6d192cf00e","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        endpoint_version \u003d target.version or \u00271.0\u0027"},{"line_number":119,"context_line":"        return utils.version_is_compatible(endpoint_version, version)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def _do_dispatch(self, endpoint, method, ctxt, args, executor_callback):"},{"line_number":122,"context_line":"        ctxt \u003d self.serializer.deserialize_context(ctxt)"},{"line_number":123,"context_line":"        new_args \u003d dict()"},{"line_number":124,"context_line":"        for argname, arg in six.iteritems(args):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_c9d5eb43","line":121,"updated":"2014-11-25 14:22:00.000000000","message":"It would be better to pass executor_callback in constructor.","commit_id":"587804bca60112987e9bcc6321a8549b9271b449"},{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"e16a87d4bf6d445e932e447b19fe21aace224bc0","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        endpoint_version \u003d target.version or \u00271.0\u0027"},{"line_number":119,"context_line":"        return utils.version_is_compatible(endpoint_version, version)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def _do_dispatch(self, endpoint, method, ctxt, args, executor_callback):"},{"line_number":122,"context_line":"        ctxt \u003d self.serializer.deserialize_context(ctxt)"},{"line_number":123,"context_line":"        new_args \u003d dict()"},{"line_number":124,"context_line":"        for argname, arg in six.iteritems(args):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_f3d8b11f","line":121,"in_reply_to":"5a890539_3c068b86","updated":"2014-11-26 12:37:56.000000000","message":"Ok, seems I didn\u0027t enough investigation. At first look passing the same  argument to each method asks to pass it once into constructor. I didn\u0027t take into account Executor-Dispactcher dependency loop.","commit_id":"587804bca60112987e9bcc6321a8549b9271b449"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"69a09ad01cdc6df4b29a8643b5f5707cd995bda9","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        endpoint_version \u003d target.version or \u00271.0\u0027"},{"line_number":119,"context_line":"        return utils.version_is_compatible(endpoint_version, version)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def _do_dispatch(self, endpoint, method, ctxt, args, executor_callback):"},{"line_number":122,"context_line":"        ctxt \u003d self.serializer.deserialize_context(ctxt)"},{"line_number":123,"context_line":"        new_args \u003d dict()"},{"line_number":124,"context_line":"        for argname, arg in six.iteritems(args):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_3c068b86","line":121,"in_reply_to":"5a890539_c9d5eb43","updated":"2014-11-26 11:27:11.000000000","message":"Currently, the constructor of executor classes takes a dispatcher object. I don\u0027t see how you can pass a method of the executor instance if you need first to instanciate the dispatcher class? Changing how and when classes are instanciated requires a non trivial redesign of Oslo Messaging.\n\nMaybe I missed something.","commit_id":"587804bca60112987e9bcc6321a8549b9271b449"}]}
