)]}'
{"oslo/messaging/_executors/impl_aioeventlet.py":[{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"e85be9ab821ac9b45cc926bd78fc25c6af74a743","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        if not isinstance(policy, aioeventlet.EventLoopPolicy):"},{"line_number":49,"context_line":"            raise RuntimeError(\"need an aioeventlet event loop policy\")"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        # create an aioeventlet event loop"},{"line_number":52,"context_line":"        self._loop \u003d trollius.new_event_loop()"},{"line_number":53,"context_line":"        trollius.set_event_loop(self._loop)"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_2a7a1888","line":51,"updated":"2014-12-03 01:06:02.000000000","message":"Isn\u0027t this sort of a bad thing for a library like oslo.messaging to do (to set global state in some other library)?\n\nMaybe it should just abort at this point instead of trying to initialize trollius with an eventloop.","commit_id":"af2111ed23c4350ec92f9bed54191165d373a0d1"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"4b7f5a967841475adbce9359af3fe1c763c7e543","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        if not isinstance(policy, aioeventlet.EventLoopPolicy):"},{"line_number":49,"context_line":"            raise RuntimeError(\"need an aioeventlet event loop policy\")"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        # create an aioeventlet event loop"},{"line_number":52,"context_line":"        self._loop \u003d trollius.new_event_loop()"},{"line_number":53,"context_line":"        trollius.set_event_loop(self._loop)"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_f41b85c8","line":51,"in_reply_to":"5a890539_2a7a1888","updated":"2014-12-03 13:59:46.000000000","message":"I focused on the Oslo Messaging repository: the only user of the aioeventlet executor is the test_executor if I understood correctly and this test uses a thread.\n\nYou are right that it\u0027s better to setup and run the event loop in the application.\n\nI discussed with Mehdi and he agrees. I posted a new patch which doesn\u0027t run the event loop anymore. It includes instead a comment explaining how to setup and run the aioeventlet event loop.","commit_id":"af2111ed23c4350ec92f9bed54191165d373a0d1"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"cd2cc05cc06bbeddf69d72a060c8fc59fa8c3619","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            loop.call_soon(event.send, \u0027running\u0027)"},{"line_number":57,"context_line":"            loop.run_forever()"},{"line_number":58,"context_line":"            loop.close()"},{"line_number":59,"context_line":"            trollius.set_event_loop(None)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        # run the event loop in a new greenthread"},{"line_number":62,"context_line":"        event \u003d eventlet.event.Event()"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_8af94cca","line":59,"updated":"2014-12-03 01:14:33.000000000","message":"Ditto here. If some other library/program/application is using trollius along with oslo.messaging doesn\u0027t this break that other user?","commit_id":"af2111ed23c4350ec92f9bed54191165d373a0d1"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"0adb090586928c2d3707a7b1eb5619d6acb8cd2a","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def start(self):"},{"line_number":59,"context_line":"        # check that the event loop is an aioeventlet event loop"},{"line_number":60,"context_line":"        loop \u003d trollius.get_event_loop()"},{"line_number":61,"context_line":"        if not isinstance(loop, aioeventlet.EventLoop):"},{"line_number":62,"context_line":"            raise RuntimeError(\"need an aioeventlet event loop\")"},{"line_number":63,"context_line":"        self._loop \u003d loop"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_d8894927","line":60,"updated":"2014-12-03 19:11:28.000000000","message":"Is this the generally agreed pattern for getting an event loop vs. just taking it from the constructor as a constructor parameter?","commit_id":"ead70c48ebd6fb9822d4d9ad9867f9453cf2d8f8"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"6047f6220a693626f3a75683e174dc0145bdb594","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def start(self):"},{"line_number":59,"context_line":"        # check that the event loop is an aioeventlet event loop"},{"line_number":60,"context_line":"        loop \u003d trollius.get_event_loop()"},{"line_number":61,"context_line":"        if not isinstance(loop, aioeventlet.EventLoop):"},{"line_number":62,"context_line":"            raise RuntimeError(\"need an aioeventlet event loop\")"},{"line_number":63,"context_line":"        self._loop \u003d loop"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_f6543bff","line":60,"in_reply_to":"5a890539_d8894927","updated":"2014-12-04 08:54:22.000000000","message":"The executor may be built in a different thread than the thread used to run the executor. test_executor exactly does that. It\u0027s even worse: the thread which will run the executor does not exist yet when the executor is created.\n\nIn trollius, all functions implictly retrieve the event loop using trollius.get_event_loop() if the loop parameter is not set (which is the most common case). For example, the trollius.async() function is common and is rarely used with the loop parameter set.\n\nI prefer to store the event loop instead of calling get_event_loop() at each call to _coroutine_wrapper(). It should be more efficient, and it helps also to detect bugs when trollius is in debug mode. For example, it should raise an exception if _coroutine_wrapper() is called in the \"wrong\" thead (a thread different than the thread running the executor).","commit_id":"ead70c48ebd6fb9822d4d9ad9867f9453cf2d8f8"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"7c5d09c0a0e70bf11101c907c7ac3bcee724ca54","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def start(self):"},{"line_number":59,"context_line":"        # check that the event loop is an aioeventlet event loop"},{"line_number":60,"context_line":"        loop \u003d trollius.get_event_loop()"},{"line_number":61,"context_line":"        if not isinstance(loop, aioeventlet.EventLoop):"},{"line_number":62,"context_line":"            raise RuntimeError(\"need an aioeventlet event loop\")"},{"line_number":63,"context_line":"        self._loop \u003d loop"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_c6d5d11c","line":60,"in_reply_to":"5a890539_f6543bff","updated":"2014-12-23 13:42:33.000000000","message":"Agreed with Victor about storing even loop.","commit_id":"ead70c48ebd6fb9822d4d9ad9867f9453cf2d8f8"}],"requirements.txt":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"b9a6920142a531d754baacefd8f9f7d7a9ac32cd","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# for the futures based executor"},{"line_number":31,"context_line":"futures\u003e\u003d2.1.6"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# needed by the aioeventlet exeuctor"},{"line_number":34,"context_line":"aioeventlet\u003e\u003d0.4"},{"line_number":35,"context_line":"trollius\u003e\u003d1.0"}],"source_content_type":"text/plain","patch_set":10,"id":"3a961159_ef3ad932","line":33,"updated":"2015-01-15 09:55:52.000000000","message":"nit: executor","commit_id":"52909a3c867fb42b5d2840c87adf3f368b9d2e07"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"aa2aaa89e40bbfd9cf0d9180a102dd4fc9eaa18f","unresolved":false,"context_lines":[{"line_number":31,"context_line":"futures\u003e\u003d2.1.6"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# needed by the aioeventlet executor"},{"line_number":34,"context_line":"aioeventlet\u003e\u003d0.4"},{"line_number":35,"context_line":"trollius\u003e\u003d1.0"}],"source_content_type":"text/plain","patch_set":12,"id":"da86d52c_0fea9bab","line":34,"updated":"2015-02-05 15:40:54.000000000","message":"Requirement aioeventlet\u003e\u003d0.4 not in openstack/requirements\n\nWhat\u0027s the status of adding this lib into openstack/requirements ?","commit_id":"d8e68c365b86d35b3f83e8fca89c38130c93dbd2"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"5f595ec7f307d5201a7bb64c839bfd8e82398849","unresolved":false,"context_lines":[{"line_number":31,"context_line":"futures\u003e\u003d2.1.6"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# needed by the aioeventlet executor"},{"line_number":34,"context_line":"aioeventlet\u003e\u003d0.4"},{"line_number":35,"context_line":"trollius\u003e\u003d1.0"}],"source_content_type":"text/plain","patch_set":12,"id":"da86d52c_3e878fb6","line":34,"in_reply_to":"da86d52c_0fea9bab","updated":"2015-02-05 17:25:46.000000000","message":"The OpenStack technical commitee asked me to write a cross-project specification. It will be used to decide if OpenStack will experiment asyncio or not.\n\nGood news, I just sent the first draft of the spec:\nhttps://review.openstack.org/#/c/153298/","commit_id":"d8e68c365b86d35b3f83e8fca89c38130c93dbd2"}]}
