)]}'
{"oslo/messaging/_executors/base.py":[{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"b4d079dd29209342836164ac513a666f204f8a61","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import six"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"POLL_TIMEOUT \u003d 1"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"@six.add_metaclass(abc.ABCMeta)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_86fa9c41","line":19,"updated":"2014-11-27 18:33:56.000000000","message":"Might be useful to link to the kombu docs for this if u want.\n\nhttp://kombu.readthedocs.org/en/latest/reference/kombu.common.html#kombu.common.eventloop\n\nThats where they mention the \u0027best practice\u0027.\n\nMaybe in the future we should just use there eventloop (the concept of an executor and there concept of an eventloop might overlap?, or maybe that eventloop replaces the iterconsume that i\u0027ve seen in oslo.messaging, not sure... more things to cleanup maybe...).","commit_id":"16462975e8ef7fbfdcef34b044ca12687085f881"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"4aa80220b6d80c8c95cfdaffa15bfbd893cb51d4","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import six"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"POLL_TIMEOUT \u003d 1"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"@six.add_metaclass(abc.ABCMeta)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_5fc6b269","line":19,"in_reply_to":"5a890539_86fa9c41","updated":"2014-11-28 07:34:16.000000000","message":"I have added the documentation link.\n\nI think the eventloop cannot replace the executor it self, but it can replace the consume and iterconsume methods of the rabbit driver.","commit_id":"16462975e8ef7fbfdcef34b044ca12687085f881"}],"oslo/messaging/_executors/impl_blocking.py":[{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"b4d079dd29209342836164ac513a666f204f8a61","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def start(self):"},{"line_number":37,"context_line":"        self._running \u003d True"},{"line_number":38,"context_line":"        while self._running:"},{"line_number":39,"context_line":"            incoming \u003d self.listener.poll(timeout\u003dbase.POLL_TIMEOUT)"},{"line_number":40,"context_line":"            if incoming is not None:"},{"line_number":41,"context_line":"                with self.dispatcher(incoming) as callback:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_06d06cc8","line":38,"updated":"2014-11-27 18:33:56.000000000","message":"So the functional difference here is that this one compared to the eventlet doesn\u0027t retry on exceptions (the eventlet one is wrapped in a retry forever decorator). Did u want it to?\n\nThats why I put a trry/except which logs in https://review.openstack.org/#/c/137467/ to at least be more like the eventlet one; maybe not needed though, idk.","commit_id":"16462975e8ef7fbfdcef34b044ca12687085f881"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"4aa80220b6d80c8c95cfdaffa15bfbd893cb51d4","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def start(self):"},{"line_number":37,"context_line":"        self._running \u003d True"},{"line_number":38,"context_line":"        while self._running:"},{"line_number":39,"context_line":"            incoming \u003d self.listener.poll(timeout\u003dbase.POLL_TIMEOUT)"},{"line_number":40,"context_line":"            if incoming is not None:"},{"line_number":41,"context_line":"                with self.dispatcher(incoming) as callback:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_3fe2c601","line":38,"in_reply_to":"5a890539_06d06cc8","updated":"2014-11-28 07:34:16.000000000","message":"Yes, we should catch the exception here too, I have added that.","commit_id":"16462975e8ef7fbfdcef34b044ca12687085f881"}]}
