)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3b27f9b7f91317ba4ef66ab385cde0674c41215c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Rabbit: iterconsume must honor timeout"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The iterconsume method of the rabbit driver must"},{"line_number":10,"context_line":"honor timeout paramenter even reconnection to the broker"},{"line_number":11,"context_line":"occurs."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I666d818449750c6bae9dde02f519842687a8e4fa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a890539_06157e48","line":10,"updated":"2014-12-02 07:45:20.000000000","message":"Do you mean \"... parameter when ...\"?","commit_id":"5ee2c309ea20b6f0ca8a95043cd6e98cf5a1ed4e"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"87feeb1f4afa74398d88e8b033d7b12a0cf0e3f2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Rabbit: iterconsume must honor timeout"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The iterconsume method of the rabbit driver must"},{"line_number":10,"context_line":"honor timeout paramenter even reconnection to the broker"},{"line_number":11,"context_line":"occurs."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I666d818449750c6bae9dde02f519842687a8e4fa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a890539_71f19e94","line":10,"in_reply_to":"5a890539_06157e48","updated":"2014-12-02 08:12:12.000000000","message":"\"when or even\", both works, currently timeout is honored only if we don\u0027t loose the connection to the broker, so.","commit_id":"5ee2c309ea20b6f0ca8a95043cd6e98cf5a1ed4e"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"bba980fbaeaf632ddad549a635a4ce94d5cfa1fd","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Rabbit: iterconsume must honor timeout"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The iterconsume method of the rabbit driver must"},{"line_number":10,"context_line":"honor timeout paramenter even reconnection to the broker"},{"line_number":11,"context_line":"occurs."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I666d818449750c6bae9dde02f519842687a8e4fa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a890539_b41a0f7a","line":10,"in_reply_to":"5a890539_14404334","updated":"2014-12-02 13:30:40.000000000","message":"done.","commit_id":"5ee2c309ea20b6f0ca8a95043cd6e98cf5a1ed4e"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"f131cf275dde0a6a42e150247e6d193f8f72be0b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Rabbit: iterconsume must honor timeout"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The iterconsume method of the rabbit driver must"},{"line_number":10,"context_line":"honor timeout paramenter even reconnection to the broker"},{"line_number":11,"context_line":"occurs."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I666d818449750c6bae9dde02f519842687a8e4fa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a890539_14404334","line":10,"in_reply_to":"5a890539_71f19e94","updated":"2014-12-02 11:09:36.000000000","message":"You wrote paramenter :)","commit_id":"5ee2c309ea20b6f0ca8a95043cd6e98cf5a1ed4e"}],"tests/drivers/test_impl_rabbit.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3b27f9b7f91317ba4ef66ab385cde0674c41215c","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                except driver_common.Timeout:"},{"line_number":68,"context_line":"                    pass"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        self.assertEqual(0, int(deadline - time.time()))"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"class TestRabbitTransportURL(test_utils.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_86296e9d","line":70,"updated":"2014-12-02 07:45:20.000000000","message":"Can\u0027t this lead to sporadic failures when the test runs on a loaded machine, when some time elapses between the test and the assert due to scheduling? Maybe you want to be more conservative here and allow for an interval of 1s? Note that time.time() is a float and at least on my system seems to increase with microsecond resolution.","commit_id":"5ee2c309ea20b6f0ca8a95043cd6e98cf5a1ed4e"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b19865b21e92757e17b919b4fb71acef4caed2c6","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                except driver_common.Timeout:"},{"line_number":68,"context_line":"                    pass"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        self.assertEqual(0, int(deadline - time.time()))"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"class TestRabbitTransportURL(test_utils.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_4cf2459c","line":70,"in_reply_to":"5a890539_71c35e38","updated":"2014-12-02 08:46:48.000000000","message":"Ah, o.k., int() truncates towards zero from both directions, that should be fine, then.","commit_id":"5ee2c309ea20b6f0ca8a95043cd6e98cf5a1ed4e"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"87feeb1f4afa74398d88e8b033d7b12a0cf0e3f2","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                except driver_common.Timeout:"},{"line_number":68,"context_line":"                    pass"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        self.assertEqual(0, int(deadline - time.time()))"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"class TestRabbitTransportURL(test_utils.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_71c35e38","line":70,"in_reply_to":"5a890539_86296e9d","updated":"2014-12-02 08:12:12.000000000","message":"This is why I cast the float to int to ensure I have ~ 0.","commit_id":"5ee2c309ea20b6f0ca8a95043cd6e98cf5a1ed4e"}]}