)]}'
{"oslo/messaging/_executors/impl_eventlet.py":[{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"e6eefb9654c051b858e1b80cc39762953a9b4624","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import sys"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import eventlet"},{"line_number":20,"context_line":"from eventlet.green import threading"},{"line_number":21,"context_line":"from eventlet import greenpool"},{"line_number":22,"context_line":"import greenlet"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_25d6fdc5","line":20,"updated":"2014-12-10 12:01:26.000000000","message":"I would import that as a \"greenthreading\". It takes time to understand that\n\"threading.local\" in line 85 actually means eventlet.green.threading.local.","commit_id":"6baef6f9c871b5789312bab60c84285de0fb6ebc"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"dccc50b184cf7209113ecfe7a8833f6b09872032","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import sys"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import eventlet"},{"line_number":20,"context_line":"from eventlet.green import threading"},{"line_number":21,"context_line":"from eventlet import greenpool"},{"line_number":22,"context_line":"import greenlet"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_601c6c14","line":20,"in_reply_to":"3a961159_25d6fdc5","updated":"2014-12-10 15:03:47.000000000","message":"Done","commit_id":"6baef6f9c871b5789312bab60c84285de0fb6ebc"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"93d03857a440244c92e31788b23bfd5795edc9a1","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        self._running \u003d False"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        if not isinstance(localcontext._STORE, threading.local):"},{"line_number":86,"context_line":"            LOG.warning(\u0027eventlet executor in use but the threading module \u0027"},{"line_number":87,"context_line":"                        \u0027have not been monkeypatched or have been \u0027"},{"line_number":88,"context_line":"                        \u0027monkeypatched after the oslo.messaging library \u0027"},{"line_number":89,"context_line":"                        \u0027have been loaded. This will results to unpredictable \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_c35e1112","line":86,"updated":"2014-12-10 12:21:18.000000000","message":"This message is directed at developers, and the problem isn\u0027t something the deployer can do anything about. We should use debug() instead of warning().","commit_id":"6baef6f9c871b5789312bab60c84285de0fb6ebc"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"dccc50b184cf7209113ecfe7a8833f6b09872032","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        self._running \u003d False"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        if not isinstance(localcontext._STORE, threading.local):"},{"line_number":86,"context_line":"            LOG.warning(\u0027eventlet executor in use but the threading module \u0027"},{"line_number":87,"context_line":"                        \u0027have not been monkeypatched or have been \u0027"},{"line_number":88,"context_line":"                        \u0027monkeypatched after the oslo.messaging library \u0027"},{"line_number":89,"context_line":"                        \u0027have been loaded. This will results to unpredictable \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_e0d77c21","line":86,"in_reply_to":"3a961159_c35e1112","updated":"2014-12-10 15:03:47.000000000","message":"Done","commit_id":"6baef6f9c871b5789312bab60c84285de0fb6ebc"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"93d03857a440244c92e31788b23bfd5795edc9a1","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        if not isinstance(localcontext._STORE, threading.local):"},{"line_number":86,"context_line":"            LOG.warning(\u0027eventlet executor in use but the threading module \u0027"},{"line_number":87,"context_line":"                        \u0027have not been monkeypatched or have been \u0027"},{"line_number":88,"context_line":"                        \u0027monkeypatched after the oslo.messaging library \u0027"},{"line_number":89,"context_line":"                        \u0027have been loaded. This will results to unpredictable \u0027"},{"line_number":90,"context_line":"                        \u0027behavior.\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_83ab29d5","line":87,"updated":"2014-12-10 12:21:18.000000000","message":"\"have not\" -\u003e \"has not\" and \"have been\" -\u003e \"has been\"","commit_id":"6baef6f9c871b5789312bab60c84285de0fb6ebc"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"dccc50b184cf7209113ecfe7a8833f6b09872032","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        if not isinstance(localcontext._STORE, threading.local):"},{"line_number":86,"context_line":"            LOG.warning(\u0027eventlet executor in use but the threading module \u0027"},{"line_number":87,"context_line":"                        \u0027have not been monkeypatched or have been \u0027"},{"line_number":88,"context_line":"                        \u0027monkeypatched after the oslo.messaging library \u0027"},{"line_number":89,"context_line":"                        \u0027have been loaded. This will results to unpredictable \u0027"},{"line_number":90,"context_line":"                        \u0027behavior.\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_c0d44022","line":87,"in_reply_to":"3a961159_83ab29d5","updated":"2014-12-10 15:03:47.000000000","message":"Done","commit_id":"6baef6f9c871b5789312bab60c84285de0fb6ebc"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"93d03857a440244c92e31788b23bfd5795edc9a1","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            LOG.warning(\u0027eventlet executor in use but the threading module \u0027"},{"line_number":87,"context_line":"                        \u0027have not been monkeypatched or have been \u0027"},{"line_number":88,"context_line":"                        \u0027monkeypatched after the oslo.messaging library \u0027"},{"line_number":89,"context_line":"                        \u0027have been loaded. This will results to unpredictable \u0027"},{"line_number":90,"context_line":"                        \u0027behavior.\u0027)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def start(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_237ef56b","line":89,"updated":"2014-12-10 12:21:18.000000000","message":"\"results to\" -\u003e \"result in\"","commit_id":"6baef6f9c871b5789312bab60c84285de0fb6ebc"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"dccc50b184cf7209113ecfe7a8833f6b09872032","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            LOG.warning(\u0027eventlet executor in use but the threading module \u0027"},{"line_number":87,"context_line":"                        \u0027have not been monkeypatched or have been \u0027"},{"line_number":88,"context_line":"                        \u0027monkeypatched after the oslo.messaging library \u0027"},{"line_number":89,"context_line":"                        \u0027have been loaded. This will results to unpredictable \u0027"},{"line_number":90,"context_line":"                        \u0027behavior.\u0027)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def start(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_40e850e2","line":89,"in_reply_to":"3a961159_237ef56b","updated":"2014-12-10 15:03:47.000000000","message":"Done","commit_id":"6baef6f9c871b5789312bab60c84285de0fb6ebc"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"e6eefb9654c051b858e1b80cc39762953a9b4624","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                        \u0027have not been monkeypatched or have been \u0027"},{"line_number":88,"context_line":"                        \u0027monkeypatched after the oslo.messaging library \u0027"},{"line_number":89,"context_line":"                        \u0027have been loaded. This will results to unpredictable \u0027"},{"line_number":90,"context_line":"                        \u0027behavior.\u0027)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def start(self):"},{"line_number":93,"context_line":"        if self._thread is not None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_857891f3","line":90,"updated":"2014-12-10 12:01:26.000000000","message":"Can you,please, throe an exception here. If I understand your message correctly there is no reason to continue.\n\nEventually, It fails in clear_local_context with AttributeError so end it here with meaningful error message and exception will be better.","commit_id":"6baef6f9c871b5789312bab60c84285de0fb6ebc"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"dccc50b184cf7209113ecfe7a8833f6b09872032","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                        \u0027have not been monkeypatched or have been \u0027"},{"line_number":88,"context_line":"                        \u0027monkeypatched after the oslo.messaging library \u0027"},{"line_number":89,"context_line":"                        \u0027have been loaded. This will results to unpredictable \u0027"},{"line_number":90,"context_line":"                        \u0027behavior.\u0027)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def start(self):"},{"line_number":93,"context_line":"        if self._thread is not None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_40cf707f","line":90,"in_reply_to":"3a961159_08eaf874","updated":"2014-12-10 15:03:47.000000000","message":"I have completed the message that in the future we will raise a `RuntimeException` exception.","commit_id":"6baef6f9c871b5789312bab60c84285de0fb6ebc"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"290295d1ae68bfcda6210f4403fab09f35c4dbc8","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                        \u0027have not been monkeypatched or have been \u0027"},{"line_number":88,"context_line":"                        \u0027monkeypatched after the oslo.messaging library \u0027"},{"line_number":89,"context_line":"                        \u0027have been loaded. This will results to unpredictable \u0027"},{"line_number":90,"context_line":"                        \u0027behavior.\u0027)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def start(self):"},{"line_number":93,"context_line":"        if self._thread is not None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_08eaf874","line":90,"in_reply_to":"3a961159_857891f3","updated":"2014-12-10 12:07:58.000000000","message":"I don\u0027t think we can throw an exception just yet. While I agree with you on the fact that stopping execution would probably be better, I think throwing an exception in this patch could break other consumers of the library.\n\nWhat I\u0027m saying is that we could warn the user and also mention that in the future, this will raise a `RuntimeException` instead.","commit_id":"6baef6f9c871b5789312bab60c84285de0fb6ebc"}]}