)]}'
{"oslo/messaging/_executors/impl_eventlet.py":[{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"5455e6538484b8bbdbb06124eb9a2f1059060acf","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                        callback \u003d self.dispatcher(incoming)"},{"line_number":74,"context_line":"                        callback.prepare()"},{"line_number":75,"context_line":"                        thread \u003d self._greenpool.spawn(callback.run)"},{"line_number":76,"context_line":"                        thread.link(lambda t: callback.done())"},{"line_number":77,"context_line":"            except greenlet.GreenletExit:"},{"line_number":78,"context_line":"                return"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_af2ee3f8","line":76,"updated":"2014-12-12 21:13:21.000000000","message":"So this part confuses me a little.\n\nI think u stated that \u0027done()\u0027 \u0027Should be runned in the main executor thread\u0027\n\nYet the greenthread docs say the following:\n\nhttp://eventlet.net/doc/modules/greenthread.html#eventlet.greenthread.GreenThread.link\n\n\"Note that func is called within execution context of the GreenThread, so it is possible to interfere with other linked functions by doing things like switching explicitly to another greenthread.\"\n\nFrom a test @ http://paste.ubuntu.com/9493980/ that linked() item doesn\u0027t even seem to be running in the main executor thread, which seems to match what the greenthread docs say.\n\nSo I\u0027m confused, has this ever been working? :-P","commit_id":"74d4dea1b8f92d8e15c2fd39d8643211ef86a15e"}],"oslo_messaging/_executors/impl_blocking.py":[{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"8525534807bd3a2cee9646cb9c0320a1e871a5f7","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    def __init__(self, conf, listener, dispatcher):"},{"line_number":38,"context_line":"        super(BlockingExecutor, self).__init__(conf, listener, dispatcher)"},{"line_number":39,"context_line":"        self._running \u003d False"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def start(self):"},{"line_number":42,"context_line":"        self._running \u003d True"},{"line_number":43,"context_line":"        while self._running:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_92821850","line":40,"updated":"2015-01-16 20:44:42.000000000","message":"Pretty sure this whole thing can get removed to ;)\n\nhttp://docs.openstack.org/developer/taskflow/types.html#taskflow.types.futures.SynchronousExecutor","commit_id":"1b0765dc13cfaf030dfd6675691617ee7a6bad2e"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"34bdb965a48f3ee3e226e66006f5e371aaded6ae","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    def __init__(self, conf, listener, dispatcher):"},{"line_number":38,"context_line":"        super(BlockingExecutor, self).__init__(conf, listener, dispatcher)"},{"line_number":39,"context_line":"        self._running \u003d False"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def start(self):"},{"line_number":42,"context_line":"        self._running \u003d True"},{"line_number":43,"context_line":"        while self._running:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_8081cdfb","line":40,"in_reply_to":"3a961159_92821850","updated":"2015-01-19 08:59:34.000000000","message":"Done","commit_id":"1b0765dc13cfaf030dfd6675691617ee7a6bad2e"}],"oslo_messaging/_executors/impl_pooledexecutor.py":[{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"7eb1754af6d918e70ec04ee24f081e1055a1f326","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                incomplete_fs \u003d list(self._incomplete)"},{"line_number":109,"context_line":"                self._incomplete.clear()"},{"line_number":110,"context_line":"            if incomplete_fs:"},{"line_number":111,"context_line":"                futures.wait(incomplete_fs, return_when\u003dfutures.ALL_COMPLETED)"},{"line_number":112,"context_line":"            self._executor \u003d None"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba3cc151_4d854157","line":111,"updated":"2015-07-07 00:41:21.000000000","message":"So this will need https://review.openstack.org/#/c/196269/ if a green executor will be used (the internals of `futures.wait` use a \u0027threading\u0027 event, and if \u0027threading\u0027 is not monkey-patched out and a green executor and green future are used here this will lock up as to wait on green futures a green event needs to be used instead). For cases where everything is monkey-patched this will be ok, something to consider.","commit_id":"e804f37e8c848516aa006625516bb9667c664dc3"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"950e6a0e88e1238b49d3d81714270968a7aeb259","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                incomplete_fs \u003d list(self._incomplete)"},{"line_number":109,"context_line":"                self._incomplete.clear()"},{"line_number":110,"context_line":"            if incomplete_fs:"},{"line_number":111,"context_line":"                futures.wait(incomplete_fs, return_when\u003dfutures.ALL_COMPLETED)"},{"line_number":112,"context_line":"            self._executor \u003d None"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba3cc151_bcf72858","line":111,"in_reply_to":"ba3cc151_4d854157","updated":"2015-07-07 22:14:24.000000000","message":"For now, this is OK for oslo.messaging, because many other place will not work if threading is not monkey patched when eventlet executor is used. The eventlet executor already do some logging if the consumer application doesn\u0027t monkey patch threading.","commit_id":"e804f37e8c848516aa006625516bb9667c664dc3"}],"oslo_messaging/_executors/impl_thread.py":[{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"756818e211712059609032068a2537a4e8ecc961","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    def __init__(self, conf, listener, dispatcher):"},{"line_number":44,"context_line":"        super(ThreadExecutor, self).__init__(conf, listener, dispatcher)"},{"line_number":45,"context_line":"        self._poller \u003d None"},{"line_number":46,"context_line":"        self._executor \u003d None"},{"line_number":47,"context_line":"        self._tombstone \u003d threading.Event()"},{"line_number":48,"context_line":"        self._incomplete \u003d collections.deque()"},{"line_number":49,"context_line":"        self._mutator \u003d threading.Lock()"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_98bfa15f","line":46,"updated":"2015-01-16 17:46:05.000000000","message":"These will likely need to be class specified types as well (At least for the event and lock types); since you don\u0027t want an eventlet executor using normal threading events and locks...\n\nProbably just add new class variables like:\n\n  _event_cls\n  _lock_cls\n\nAnd then use them to create locks/events here...","commit_id":"1b0765dc13cfaf030dfd6675691617ee7a6bad2e"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"34bdb965a48f3ee3e226e66006f5e371aaded6ae","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    def __init__(self, conf, listener, dispatcher):"},{"line_number":44,"context_line":"        super(ThreadExecutor, self).__init__(conf, listener, dispatcher)"},{"line_number":45,"context_line":"        self._poller \u003d None"},{"line_number":46,"context_line":"        self._executor \u003d None"},{"line_number":47,"context_line":"        self._tombstone \u003d threading.Event()"},{"line_number":48,"context_line":"        self._incomplete \u003d collections.deque()"},{"line_number":49,"context_line":"        self._mutator \u003d threading.Lock()"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_a07b2927","line":46,"in_reply_to":"3a961159_98bfa15f","updated":"2015-01-19 08:59:34.000000000","message":"Done","commit_id":"1b0765dc13cfaf030dfd6675691617ee7a6bad2e"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"5b48e971606971276fe5cfffbc8daccc76acb006","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            self._executor \u003d self._executor_cls(self.conf.rpc_thread_pool_size)"},{"line_number":78,"context_line":"        self._tombstone.clear()"},{"line_number":79,"context_line":"        if self._poller is None or not self._poller.is_alive():"},{"line_number":80,"context_line":"            self._poller \u003d threading.Thread(target\u003dself._runner)"},{"line_number":81,"context_line":"            self._poller.daemon \u003d True"},{"line_number":82,"context_line":"            self._poller.start()"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_9e98691c","line":80,"updated":"2015-01-16 18:42:47.000000000","message":"Another question is what do u want to do about this thread here? Maybe it\u0027s fine, not sure... But it does seem odd to have a eventlet executor spin up its own thread to do the polling... Something to think about I guess...","commit_id":"1b0765dc13cfaf030dfd6675691617ee7a6bad2e"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"34bdb965a48f3ee3e226e66006f5e371aaded6ae","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            self._executor \u003d self._executor_cls(self.conf.rpc_thread_pool_size)"},{"line_number":78,"context_line":"        self._tombstone.clear()"},{"line_number":79,"context_line":"        if self._poller is None or not self._poller.is_alive():"},{"line_number":80,"context_line":"            self._poller \u003d threading.Thread(target\u003dself._runner)"},{"line_number":81,"context_line":"            self._poller.daemon \u003d True"},{"line_number":82,"context_line":"            self._poller.start()"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_e0e0d198","line":80,"in_reply_to":"3a961159_9e98691c","updated":"2015-01-19 08:59:34.000000000","message":"eventlet already do the polling into a different greenlet. I have replaced it by  eventlet.green.threading.Thread for eventlet executor to continue to run it into a greenlet.","commit_id":"1b0765dc13cfaf030dfd6675691617ee7a6bad2e"},{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"40e6388f35761118bb726f5c2a65e6027dee5a64","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from oslo_messaging._executors import impl_pooledexecutor"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class ThreadExecutor(impl_pooledexecutor.PooledExecutor):"},{"line_number":23,"context_line":"    \"\"\"A message executor which integrates with threads."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    A message process that polls for messages from a dispatching thread and"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_b1ba6409","line":22,"updated":"2015-01-20 16:27:02.000000000","message":"Why do we need to leave this executor? Can we just make use of PooledExecutor directly?","commit_id":"9d5d7048b8bc3979f9352ff73859d92466652211"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"ddfe312b23322b0d052997970ae4e48f23bb76a9","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from oslo_messaging._executors import impl_pooledexecutor"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class ThreadExecutor(impl_pooledexecutor.PooledExecutor):"},{"line_number":23,"context_line":"    \"\"\"A message executor which integrates with threads."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    A message process that polls for messages from a dispatching thread and"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_e9d96429","line":22,"in_reply_to":"3a961159_b1ba6409","updated":"2015-01-20 17:37:13.000000000","message":"Did this executor go out in a release? If not then sure remove it; if so, then likely it needs a depreciation release?","commit_id":"9d5d7048b8bc3979f9352ff73859d92466652211"},{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"40e6388f35761118bb726f5c2a65e6027dee5a64","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    on reception of an incoming message places the message to be processed in"},{"line_number":27,"context_line":"    a thread pool to be executed at a later time."},{"line_number":28,"context_line":"    \"\"\""},{"line_number":29,"context_line":"    _executor_cls \u003d futures.ThreadPoolExecutor"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_f1286c38","line":29,"updated":"2015-01-20 16:27:02.000000000","message":"Moreover this is already done in base class.","commit_id":"9d5d7048b8bc3979f9352ff73859d92466652211"}],"oslo_messaging/_executors/taskflow_timing.py":[{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"d83b1eabc8027699e5339e956e442785366b464e","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        return r"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"class StopWatch(object):"},{"line_number":78,"context_line":"    \"\"\"A simple timer/stopwatch helper class."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    Inspired by: apache-commons-lang java stopwatch."}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_891e2073","line":77,"updated":"2015-01-20 17:44:44.000000000","message":"Think I\u0027ll try to move this to oslo.utils soon...\n\nThis can likely replace (or be used as the base class of the existing class DecayingTimer(object) that exists here in oslo.messaging).","commit_id":"9d5d7048b8bc3979f9352ff73859d92466652211"}],"oslo_messaging/_utils.py":[{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"5fed329ed2b47b45e2907f0a144bdcfa740359b8","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    def done(self):"},{"line_number":100,"context_line":"        \"\"\"Callback after the incoming message have been dispathed"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        Should be runned in the main executor thread/greenlet/corotine"},{"line_number":103,"context_line":"        \"\"\""},{"line_number":104,"context_line":"        if self._post is not None:"},{"line_number":105,"context_line":"            self._post(self._incoming, self._result)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_5247d04b","line":102,"updated":"2015-01-16 20:43:29.000000000","message":"Sooo I\u0027m not sure this comment is valid ;)\n\nMaybe the statement @ https://docs.python.org/dev/library/concurrent.futures.html#concurrent.futures.Future.add_done_callback should be used?\n\n\u0027\u0027Added callables are called in the order that they were added and are always called in a thread belonging to the process that added them.\u0027\u0027","commit_id":"1b0765dc13cfaf030dfd6675691617ee7a6bad2e"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"34bdb965a48f3ee3e226e66006f5e371aaded6ae","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    def done(self):"},{"line_number":100,"context_line":"        \"\"\"Callback after the incoming message have been dispathed"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        Should be runned in the main executor thread/greenlet/corotine"},{"line_number":103,"context_line":"        \"\"\""},{"line_number":104,"context_line":"        if self._post is not None:"},{"line_number":105,"context_line":"            self._post(self._incoming, self._result)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_db8e66d0","line":102,"in_reply_to":"3a961159_5247d04b","updated":"2015-01-19 08:59:34.000000000","message":"Yes, this statement are currently wrong, but I \u0027m worried about that one, because I\u0027m not sure the drivers are really thread safe. I guess that works because drain_events() only read the kombu connection socket and basic_ack() only write to the socket. So greenlet doesn\u0027t complains about multiple greenlet that use the same socket.","commit_id":"1b0765dc13cfaf030dfd6675691617ee7a6bad2e"}],"tests/rpc/test_dispatcher.py":[{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"23f7a6ad4fd3d947aa8fd0df61915003eb28584c","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        incoming \u003d mock.Mock(ctxt\u003dself.ctxt, message\u003dself.msg)"},{"line_number":121,"context_line":"        incoming.reply.side_effect \u003d check_reply"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        callback \u003d dispatcher(incoming)"},{"line_number":124,"context_line":"        callback.prepare()"},{"line_number":125,"context_line":"        callback.run()"},{"line_number":126,"context_line":"        callback.done()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_0156e305","line":123,"updated":"2014-12-23 14:08:45.000000000","message":"Introduce new method to unite prepare-run-done call chain in one method inside dispatcher.","commit_id":"74d4dea1b8f92d8e15c2fd39d8643211ef86a15e"}]}
