)]}'
{"tests/test_amqp_driver.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"688c494d292cb9888ac397033a484ce2cf0a8b31","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        notifications \u003d [(messaging.Target(topic\u003d\"topic-1\"), \u0027info\u0027),"},{"line_number":261,"context_line":"                         (messaging.Target(topic\u003d\"topic-1\"), \u0027error\u0027),"},{"line_number":262,"context_line":"                         (messaging.Target(topic\u003d\"topic-2\"), \u0027debug\u0027)]"},{"line_number":263,"context_line":"        nl \u003d driver.listen_for_notifications(notifications, pool\u003dNone)"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        listener \u003d _ListenerThread(nl, 3)"},{"line_number":266,"context_line":"        targets \u003d [\u0027topic-1.info\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_8d763a0b","line":263,"updated":"2015-01-12 13:28:48.000000000","message":"As i can see, pool is required argument, according too [1]. But i can\u0027t get why it was passed here as positional arg?\n\n\n\n[1] https://github.com/openstack/oslo.messaging/blob/master/oslo/messaging/_drivers/amqpdriver.py#L438","commit_id":"cbcc88c5ec2784c7a234c33ef6ceae1c4d323731"},{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"d47c94ded5cee0bd41daa8f4f0a968c1e4f1b336","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        notifications \u003d [(messaging.Target(topic\u003d\"topic-1\"), \u0027info\u0027),"},{"line_number":261,"context_line":"                         (messaging.Target(topic\u003d\"topic-1\"), \u0027error\u0027),"},{"line_number":262,"context_line":"                         (messaging.Target(topic\u003d\"topic-2\"), \u0027debug\u0027)]"},{"line_number":263,"context_line":"        nl \u003d driver.listen_for_notifications(notifications, pool\u003dNone)"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        listener \u003d _ListenerThread(nl, 3)"},{"line_number":266,"context_line":"        targets \u003d [\u0027topic-1.info\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_18821852","line":263,"in_reply_to":"3a961159_8d763a0b","updated":"2015-01-15 01:39:52.000000000","message":"I\u0027ve removed the \u0027pool\u003d\u0027, None will be passed without the keyword.","commit_id":"cbcc88c5ec2784c7a234c33ef6ceae1c4d323731"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"688c494d292cb9888ac397033a484ce2cf0a8b31","unresolved":false,"context_lines":[{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    def setUp(self):"},{"line_number":289,"context_line":"        super(TestAuthentication, self).setUp()"},{"line_number":290,"context_line":"        LOG.info(\"Starting Authentication Test\")"},{"line_number":291,"context_line":"        # for simplicity, encode the credentials as they would appear \u0027on the"},{"line_number":292,"context_line":"        # wire\u0027 in a SASL frame - username and password prefixed by zero."},{"line_number":293,"context_line":"        user_credentials \u003d [\"\\0joe\\0secret\"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_cd412265","line":290,"updated":"2015-01-12 13:28:48.000000000","message":"I like the approach of logging level consolidation, but if you are doing such - please make it global (iterate over all existing modules, but not making an exception - changing logging levels in one module).","commit_id":"cbcc88c5ec2784c7a234c33ef6ceae1c4d323731"},{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"d47c94ded5cee0bd41daa8f4f0a968c1e4f1b336","unresolved":false,"context_lines":[{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    def setUp(self):"},{"line_number":289,"context_line":"        super(TestAuthentication, self).setUp()"},{"line_number":290,"context_line":"        LOG.info(\"Starting Authentication Test\")"},{"line_number":291,"context_line":"        # for simplicity, encode the credentials as they would appear \u0027on the"},{"line_number":292,"context_line":"        # wire\u0027 in a SASL frame - username and password prefixed by zero."},{"line_number":293,"context_line":"        user_credentials \u003d [\"\\0joe\\0secret\"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_38d51443","line":290,"in_reply_to":"3a961159_cd412265","updated":"2015-01-15 01:39:52.000000000","message":"This change is much smaller scope - I accidentally checked in debug code: these 2 log messages should not be error-level, I had bumped them up to error while debugging a problem and accidentally checked that in.","commit_id":"cbcc88c5ec2784c7a234c33ef6ceae1c4d323731"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"6a5da9ee7080f352403690cc451ffd7c6a7eb31b","unresolved":false,"context_lines":[{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    def setUp(self):"},{"line_number":289,"context_line":"        super(TestAuthentication, self).setUp()"},{"line_number":290,"context_line":"        LOG.info(\"Starting Authentication Test\")"},{"line_number":291,"context_line":"        # for simplicity, encode the credentials as they would appear \u0027on the"},{"line_number":292,"context_line":"        # wire\u0027 in a SASL frame - username and password prefixed by zero."},{"line_number":293,"context_line":"        user_credentials \u003d [\"\\0joe\\0secret\"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_399be2ca","line":290,"updated":"2015-01-21 08:09:49.000000000","message":"sorry for nitpicking but I\u0027d probably just remove these logging lines. We probably don\u0027t need logging in our tests as the test runner should be smart enough to tell us when a test is starting.","commit_id":"f69ad0056fba6b1b203fff228545e0f3eb5a660b"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"6a6e443e52f5982bbac1c1a58832c55e6b5c814a","unresolved":false,"context_lines":[{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    def setUp(self):"},{"line_number":289,"context_line":"        super(TestAuthentication, self).setUp()"},{"line_number":290,"context_line":"        LOG.info(\"Starting Authentication Test\")"},{"line_number":291,"context_line":"        # for simplicity, encode the credentials as they would appear \u0027on the"},{"line_number":292,"context_line":"        # wire\u0027 in a SASL frame - username and password prefixed by zero."},{"line_number":293,"context_line":"        user_credentials \u003d [\"\\0joe\\0secret\"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_75880123","line":290,"in_reply_to":"1a930d6b_399be2ca","updated":"2015-01-21 14:53:25.000000000","message":"+1","commit_id":"f69ad0056fba6b1b203fff228545e0f3eb5a660b"},{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"de0e9db1a537ac4f635d51fab75aa61171451bd7","unresolved":false,"context_lines":[{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    def setUp(self):"},{"line_number":289,"context_line":"        super(TestAuthentication, self).setUp()"},{"line_number":290,"context_line":"        LOG.info(\"Starting Authentication Test\")"},{"line_number":291,"context_line":"        # for simplicity, encode the credentials as they would appear \u0027on the"},{"line_number":292,"context_line":"        # wire\u0027 in a SASL frame - username and password prefixed by zero."},{"line_number":293,"context_line":"        user_credentials \u003d [\"\\0joe\\0secret\"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_408a9b64","line":290,"in_reply_to":"1a930d6b_399be2ca","updated":"2015-01-27 17:00:51.000000000","message":"Done","commit_id":"f69ad0056fba6b1b203fff228545e0f3eb5a660b"}]}