)]}'
{"oslo/messaging/notify/_impl_messaging.py":[{"author":{"_account_id":6601,"name":"James Carey","email":"jecarey@yerac.com","username":"jecarey"},"change_message_id":"d7e2bad4d72c9dacf3014c7c70491e47173dd6b3","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                LOG.exception(_LE(\"Could not send notification\""},{"line_number":52,"context_line":"                                  \" to %(topic)s. Payload\u003d%(message)s. \""},{"line_number":53,"context_line":"                                  \"Caused by original exception: %(e)s.\"),"},{"line_number":54,"context_line":"                              dict(topic\u003dtopic, message\u003dmessage, e\u003de))"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"class MessagingV2Driver(MessagingDriver):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_69ad7432","line":54,"updated":"2015-01-12 19:49:17.000000000","message":"LOG.exception includes the stack trace, so you shouldn\u0027t include the exception in the message.","commit_id":"d966567657f06eb32095a5f90475211f5ebfd61c"}],"oslo/messaging/notify/dispatcher.py":[{"author":{"_account_id":6601,"name":"James Carey","email":"jecarey@yerac.com","username":"jecarey"},"change_message_id":"d7e2bad4d72c9dacf3014c7c70491e47173dd6b3","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        except Exception:"},{"line_number":92,"context_line":"            # sys.exc_info() is deleted by LOG.exception()."},{"line_number":93,"context_line":"            exc_info \u003d sys.exc_info()"},{"line_number":94,"context_line":"            LOG.error(_LE(\u0027Exception during message handling.\u0027),"},{"line_number":95,"context_line":"                      exc_info\u003dexc_info)"},{"line_number":96,"context_line":"            return NotificationResult.HANDLED"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_c952e834","line":94,"updated":"2015-01-12 19:49:17.000000000","message":"Separate logging cleanup commit?\n\nShould be LOG.exception instead of LOG.error, since that indicates that exc_info\u003dexc_info which is clearer than adding it explicitly.","commit_id":"d966567657f06eb32095a5f90475211f5ebfd61c"}],"oslo/messaging/notify/notifier.py":[{"author":{"_account_id":6601,"name":"James Carey","email":"jecarey@yerac.com","username":"jecarey"},"change_message_id":"d7e2bad4d72c9dacf3014c7c70491e47173dd6b3","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            except Exception as e:"},{"line_number":180,"context_line":"                _LOG.exception(_LE(\"Problem \u0027%(e)s\u0027 attempting to send to \""},{"line_number":181,"context_line":"                              \"notification system. Payload\u003d%(payload)s.\"),"},{"line_number":182,"context_line":"                              dict(e\u003de, payload\u003dpayload))"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        if self._driver_mgr.extensions:"},{"line_number":185,"context_line":"            self._driver_mgr.map(do_notify)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_891f0070","line":182,"updated":"2015-01-12 19:49:17.000000000","message":"Second logging cleanup commit?\n\nShouldn\u0027t include the exception in the message because LOG.exception includes the stack trace and exception information in the log already.\n\n    _LOG.exception(_LE(\"Problem attempting to send to notification system.   Payload\u003d%(payload)s.\"), dict(payload\u003dpayload))","commit_id":"d966567657f06eb32095a5f90475211f5ebfd61c"}],"oslo/messaging/rpc/dispatcher.py":[{"author":{"_account_id":6601,"name":"James Carey","email":"jecarey@yerac.com","username":"jecarey"},"change_message_id":"d7e2bad4d72c9dacf3014c7c70491e47173dd6b3","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        except Exception as e:"},{"line_number":148,"context_line":"            # sys.exc_info() is deleted by LOG.exception()."},{"line_number":149,"context_line":"            exc_info \u003d sys.exc_info()"},{"line_number":150,"context_line":"            LOG.error(_LE(\u0027Exception during message handling: %(e)s. \u0027"},{"line_number":151,"context_line":"                          \u0027Exception info: %(exc_info)s\u0027),"},{"line_number":152,"context_line":"                      str(e), exc_info\u003dexc_info)"},{"line_number":153,"context_line":"            incoming.reply(failure\u003dexc_info)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_c9002805","line":150,"updated":"2015-01-12 19:49:17.000000000","message":"Second logging cleanup commit?\n\nShould use LOG.exception and then not explicitly include the exception info, and don\u0027t specify exc_info\u003dexc_info.","commit_id":"d966567657f06eb32095a5f90475211f5ebfd61c"}]}
