)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"e3d9e1d585b4437b833d7f88d444456b938f4f23","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix notifications broken with ZMQ driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The notification message did not contain a method keyword,"},{"line_number":10,"context_line":"so it was ignored by consumers. Another in dispatch, the"},{"line_number":11,"context_line":"notification msg confilict with other method."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa81d914_0fe870b3","line":9,"updated":"2015-01-28 19:52:54.000000000","message":"it seems like you have to fix project\u0027s code that emmits such notification, instead of changing driver.","commit_id":"e8c6637d9eee4bc956344c3a8fe0d125b2eaf88a"},{"author":{"_account_id":13979,"name":"qiaojian","email":"qiaojian@awcloud.com","username":"joyce"},"change_message_id":"c423692db7424c18ddb90d5ea19a516e4c544fa8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix notifications broken with ZMQ driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The notification message did not contain a method keyword,"},{"line_number":10,"context_line":"so it was ignored by consumers. Another in dispatch, the"},{"line_number":11,"context_line":"notification msg confilict with other method."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa81d914_e6909097","line":9,"in_reply_to":"fa81d914_0fe870b3","updated":"2015-01-30 11:31:57.000000000","message":"The method keyword is not needed by all the other drivers indeed, because drivers will never care what the message is, just transport. Zmq_driver break the rule, so i can not agree to do this by other projects.","commit_id":"e8c6637d9eee4bc956344c3a8fe0d125b2eaf88a"},{"author":{"_account_id":13979,"name":"qiaojian","email":"qiaojian@awcloud.com","username":"joyce"},"change_message_id":"bf6e2edd7e42cdddcfe3bcb8084f4842132dd6d1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix notifications broken with ZMQ driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The notification message did not contain a method keyword,"},{"line_number":10,"context_line":"so it was ignored by consumers. Another in dispatch, the"},{"line_number":11,"context_line":"notification msg confilict with other method."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa81d914_777b2c28","line":9,"in_reply_to":"fa81d914_3111c45d","updated":"2015-01-30 13:39:56.000000000","message":"Back to the code, zmq driver recreate the message, cause ceilometer-notification service could not parse the new message. \n-------------------------------------\nclass ZmqListener(base.Listener):\n\n    def __init__(self, driver):\n        super(ZmqListener, self).__init__(driver)\n        self.incoming_queue \u003d moves.queue.Queue()\n\n    def dispatch(self, ctxt, version, method, namespace, **kwargs):\n        message \u003d {\n            \u0027method\u0027: method,\n            \u0027args\u0027: kwargs\n        }\n        if version:\n            message[\u0027version\u0027] \u003d version\n        if namespace:\n            message[\u0027namespace\u0027] \u003d namespace\n\n        incoming \u003d ZmqIncomingMessage(self,\n                                      ctxt.to_dict(),\n                                      message)\n------------------------------------------","commit_id":"e8c6637d9eee4bc956344c3a8fe0d125b2eaf88a"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"d04f5e18e05a504ee2ba4e5156339c4b01417f63","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix notifications broken with ZMQ driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The notification message did not contain a method keyword,"},{"line_number":10,"context_line":"so it was ignored by consumers. Another in dispatch, the"},{"line_number":11,"context_line":"notification msg confilict with other method."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa81d914_3111c45d","line":9,"in_reply_to":"fa81d914_e6909097","updated":"2015-01-30 12:25:42.000000000","message":"Could you please provide specific references about what you\u0027re saying?","commit_id":"e8c6637d9eee4bc956344c3a8fe0d125b2eaf88a"}],"oslo_messaging/_drivers/impl_zmq.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"e3d9e1d585b4437b833d7f88d444456b938f4f23","unresolved":false,"context_lines":[{"line_number":836,"context_line":""},{"line_number":837,"context_line":"    def dispatch(self, ctxt, version, method, namespace, **kwargs):"},{"line_number":838,"context_line":"        if method \u003d\u003d \"notification\":"},{"line_number":839,"context_line":"            message \u003d kwargs"},{"line_number":840,"context_line":"        else:"},{"line_number":841,"context_line":"            message \u003d {"},{"line_number":842,"context_line":"                \u0027method\u0027: method,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_afc5a45c","line":839,"updated":"2015-01-28 19:52:54.000000000","message":"i completely confused by such change, why do yo mix message and args? could you please explain it.","commit_id":"e8c6637d9eee4bc956344c3a8fe0d125b2eaf88a"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"d04f5e18e05a504ee2ba4e5156339c4b01417f63","unresolved":false,"context_lines":[{"line_number":836,"context_line":""},{"line_number":837,"context_line":"    def dispatch(self, ctxt, version, method, namespace, **kwargs):"},{"line_number":838,"context_line":"        if method \u003d\u003d \"notification\":"},{"line_number":839,"context_line":"            message \u003d kwargs"},{"line_number":840,"context_line":"        else:"},{"line_number":841,"context_line":"            message \u003d {"},{"line_number":842,"context_line":"                \u0027method\u0027: method,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_d1014807","line":839,"in_reply_to":"fa81d914_1d8faecd","updated":"2015-01-30 12:25:42.000000000","message":"I\u0027d prefer to see 2nd solution, instead of doing this.","commit_id":"e8c6637d9eee4bc956344c3a8fe0d125b2eaf88a"},{"author":{"_account_id":13979,"name":"qiaojian","email":"qiaojian@awcloud.com","username":"joyce"},"change_message_id":"c423692db7424c18ddb90d5ea19a516e4c544fa8","unresolved":false,"context_lines":[{"line_number":836,"context_line":""},{"line_number":837,"context_line":"    def dispatch(self, ctxt, version, method, namespace, **kwargs):"},{"line_number":838,"context_line":"        if method \u003d\u003d \"notification\":"},{"line_number":839,"context_line":"            message \u003d kwargs"},{"line_number":840,"context_line":"        else:"},{"line_number":841,"context_line":"            message \u003d {"},{"line_number":842,"context_line":"                \u0027method\u0027: method,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_1d8faecd","line":839,"in_reply_to":"fa81d914_afc5a45c","updated":"2015-01-30 11:31:57.000000000","message":"I thought that it might have dispute here. this commit can transmitting the correct message to sub-consumer, maybe not very suitable, but it is limited to the zmq_driver self.\nAnother way to solve this bug, rewrite the dispatch function, do not parse and recreate the message keyword, this need test","commit_id":"e8c6637d9eee4bc956344c3a8fe0d125b2eaf88a"}]}