)]}'
{"oslo_messaging/rpc/client.py":[{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"ea53318aa43107b830e179471bc1bd89da3fc68e","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"_client_opts \u003d ["},{"line_number":35,"context_line":"    cfg.IntOpt(\u0027rpc_response_timeout\u0027,"},{"line_number":36,"context_line":"               default\u003d120,"},{"line_number":37,"context_line":"               help\u003d\u0027Seconds to wait for a response from a call.\u0027),"},{"line_number":38,"context_line":"]"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_a402a4b1","line":36,"updated":"2015-02-05 09:33:56.000000000","message":"Can you explain why 120? And if this value could be substituted with a value from a conf file, should we care about the default value? I think it should be customer responsibility. If customer can\u0027t change it due to an application purposes and requirements then we have bad interface but not the wrong timeout value.  Furthermore this value can\u0027t be a constant for all possible deployments, because it depends from hardware and current load at any given moment.","commit_id":"3eb54eb45a6d2ad5902886319a4ffe628fcbb663"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"d1ffd7b99ede0e3a2085ffe0d5520ca4a6c234fa","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"_client_opts \u003d ["},{"line_number":35,"context_line":"    cfg.IntOpt(\u0027rpc_response_timeout\u0027,"},{"line_number":36,"context_line":"               default\u003d120,"},{"line_number":37,"context_line":"               help\u003d\u0027Seconds to wait for a response from a call.\u0027),"},{"line_number":38,"context_line":"]"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_d49d2f5b","line":36,"in_reply_to":"da86d52c_a402a4b1","updated":"2015-02-08 13:14:24.000000000","message":"Hi Ilya, thanks for your review. Actually this is also what I thought about.\n\nFirstly, I\u0027m not sure why this value is set to 60 by default. Is it stable and verified by different scenarios? In our deployments, from 100 to 500 scale, 60 seconds is always not enough due to slow response of mq cluster with high workload.\n\nMaybe tuning mq cluster is straightforward, but a feasible response timeout value is also important.\n\nEven if it is the customer\u0027s responsiblity, I think double default value definitely can increase the stability of deployments, especially for those who is not familiar with message queue system.","commit_id":"3eb54eb45a6d2ad5902886319a4ffe628fcbb663"},{"author":{"_account_id":9631,"name":"sajuptpm","email":"sajuptpm@gmail.com","username":"sajuptpm"},"change_message_id":"94b2f6ea8a433904f4ad118a3f1307f3e2e461a1","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"_client_opts \u003d ["},{"line_number":35,"context_line":"    cfg.IntOpt(\u0027rpc_response_timeout\u0027,"},{"line_number":36,"context_line":"               default\u003d120,"},{"line_number":37,"context_line":"               help\u003d\u0027Seconds to wait for a response from a call.\u0027),"},{"line_number":38,"context_line":"]"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_98d46521","line":36,"in_reply_to":"da86d52c_d49d2f5b","updated":"2015-03-02 19:32:03.000000000","message":"It is clearly mentioned in the documentation that we can increase the timeout via the config option \"rpc_response_timeout\".","commit_id":"3eb54eb45a6d2ad5902886319a4ffe628fcbb663"}]}