)]}'
{"tests/drivers/test_impl_zmq.py":[{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"9d2b2e01698211012bd5e5945957e6d5f8d9cb02","unresolved":false,"context_lines":[{"line_number":21,"context_line":"import testtools"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"try:"},{"line_number":24,"context_line":"    import zmq"},{"line_number":25,"context_line":"except ImportError:"},{"line_number":26,"context_line":"    zmq \u003d None"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_ef2e8cf9","line":24,"updated":"2015-02-10 12:50:52.000000000","message":"Why to check import and not just let it fail?","commit_id":"4c0ef9b09ec4b7493677e862f15b72dcd1c9d845"},{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"467eadba12eaa284bcb934103f59adb7b1468683","unresolved":false,"context_lines":[{"line_number":21,"context_line":"import testtools"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"try:"},{"line_number":24,"context_line":"    import zmq"},{"line_number":25,"context_line":"except ImportError:"},{"line_number":26,"context_line":"    zmq \u003d None"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_41b0488b","line":24,"in_reply_to":"da86d52c_6502bd3f","updated":"2015-02-10 15:21:08.000000000","message":"Ok, I got it.","commit_id":"4c0ef9b09ec4b7493677e862f15b72dcd1c9d845"},{"author":{"_account_id":935,"name":"James Page","email":"ringo.page@gmail.com","username":"james-page"},"change_message_id":"db727cb646ac5c8bbd0168b33647159085f2b45e","unresolved":false,"context_lines":[{"line_number":21,"context_line":"import testtools"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"try:"},{"line_number":24,"context_line":"    import zmq"},{"line_number":25,"context_line":"except ImportError:"},{"line_number":26,"context_line":"    zmq \u003d None"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_6502bd3f","line":24,"in_reply_to":"da86d52c_6fab7c1e","updated":"2015-02-10 13:44:06.000000000","message":"By checking the import and then using it in the skipIf below, we support correct execution of the tests under python2 (where zmq + eventlet is OK) and py3 where eventlet support is not complete yet.\n\nIf we ignore the import failure, we\u0027ll make all tests fail - this just ensures that we run the zmq test cases where it should be supported.","commit_id":"4c0ef9b09ec4b7493677e862f15b72dcd1c9d845"},{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"766b44bb7bb16cbf1a96043e0270cd5894a11023","unresolved":false,"context_lines":[{"line_number":21,"context_line":"import testtools"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"try:"},{"line_number":24,"context_line":"    import zmq"},{"line_number":25,"context_line":"except ImportError:"},{"line_number":26,"context_line":"    zmq \u003d None"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_6fab7c1e","line":24,"in_reply_to":"da86d52c_ef2e8cf9","updated":"2015-02-10 12:55:52.000000000","message":"If we run tests without zmq imported would it be correct? They should definitely fail a bit later but for the same reason - no import. Potential bugs would be still hidden and reason of test failure become not obvious.","commit_id":"4c0ef9b09ec4b7493677e862f15b72dcd1c9d845"}]}
