)]}'
{"oslo_messaging/_drivers/impl_rabbit.py":[{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"43bcec1c584bdb5d2af65fdbff510f733f3ab4c7","unresolved":false,"context_lines":[{"line_number":597,"context_line":"                # We might want to allow variations in the"},{"line_number":598,"context_line":"                # future with this?"},{"line_number":599,"context_line":"                ssl_params[\u0027cert_reqs\u0027] \u003d ssl.CERT_REQUIRED"},{"line_number":600,"context_line":"            return ssl_params or True"},{"line_number":601,"context_line":"        return False"},{"line_number":602,"context_line":""},{"line_number":603,"context_line":"    def ensure(self, error_callback, method, retry\u003dNone,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_0f104000","line":600,"updated":"2015-02-10 12:45:36.000000000","message":"This expr will always return ssl_params, because we initialised it with dict() earlier.","commit_id":"4fde86d97e3023414302532535fa7bc688d38c58"},{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"a09f6ed528a8c8a3d614a031cd89a256540a14cb","unresolved":false,"context_lines":[{"line_number":597,"context_line":"                # We might want to allow variations in the"},{"line_number":598,"context_line":"                # future with this?"},{"line_number":599,"context_line":"                ssl_params[\u0027cert_reqs\u0027] \u003d ssl.CERT_REQUIRED"},{"line_number":600,"context_line":"            return ssl_params or True"},{"line_number":601,"context_line":"        return False"},{"line_number":602,"context_line":""},{"line_number":603,"context_line":"    def ensure(self, error_callback, method, retry\u003dNone,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_4f7cf820","line":600,"in_reply_to":"da86d52c_0f104000","updated":"2015-02-10 12:49:24.000000000","message":"I misunderstood that we check the dictionary is empty(), my fault... Still don\u0027t understand why we use boolean for result?","commit_id":"4fde86d97e3023414302532535fa7bc688d38c58"},{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"43bcec1c584bdb5d2af65fdbff510f733f3ab4c7","unresolved":false,"context_lines":[{"line_number":598,"context_line":"                # future with this?"},{"line_number":599,"context_line":"                ssl_params[\u0027cert_reqs\u0027] \u003d ssl.CERT_REQUIRED"},{"line_number":600,"context_line":"            return ssl_params or True"},{"line_number":601,"context_line":"        return False"},{"line_number":602,"context_line":""},{"line_number":603,"context_line":"    def ensure(self, error_callback, method, retry\u003dNone,"},{"line_number":604,"context_line":"               timeout_is_error\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_4ff958c7","line":601,"updated":"2015-02-10 12:45:36.000000000","message":"Why return boolean value? None is more appropriate for object","commit_id":"4fde86d97e3023414302532535fa7bc688d38c58"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"bb8c4435f51f2d91da083f6afd31590d3771c3b4","unresolved":false,"context_lines":[{"line_number":598,"context_line":"                # future with this?"},{"line_number":599,"context_line":"                ssl_params[\u0027cert_reqs\u0027] \u003d ssl.CERT_REQUIRED"},{"line_number":600,"context_line":"            return ssl_params or True"},{"line_number":601,"context_line":"        return False"},{"line_number":602,"context_line":""},{"line_number":603,"context_line":"    def ensure(self, error_callback, method, retry\u003dNone,"},{"line_number":604,"context_line":"               timeout_is_error\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_5376553f","line":601,"in_reply_to":"da86d52c_4ff958c7","updated":"2015-02-10 19:02:45.000000000","message":"seems ok. http://kombu.readthedocs.org/en/latest/reference/kombu.connection.html#kombu.connection.Connection","commit_id":"4fde86d97e3023414302532535fa7bc688d38c58"}]}