)]}'
{"oslo_messaging/_drivers/impl_rabbit.py":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"e70d8602456929fb4e009cd860a93aa74570a4e9","unresolved":false,"context_lines":[{"line_number":610,"context_line":"            LOG.warn(\"Deprecated: fake_rabbit option is deprecated, set \""},{"line_number":611,"context_line":"                     \"rpc_backend to kombu+memory or use the fake \""},{"line_number":612,"context_line":"                     \"driver instead.\")"},{"line_number":613,"context_line":"            self._url \u003d \u0027memory://%s/\u0027 % self._parse_url_hostname(virtual_host)"},{"line_number":614,"context_line":"        elif url.hosts:"},{"line_number":615,"context_line":"            if url.transport.startswith(\u0027kombu+\u0027):"},{"line_number":616,"context_line":"                LOG.warn(_LW(\u0027Selecting the kombu transport through the \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_9c5d104b","line":613,"updated":"2015-03-19 15:18:18.000000000","message":"Virtual host doesn\u0027t need this.","commit_id":"4e3bdaca46798f6033d30d5fa4f2bc80dc83fb0a"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"e70d8602456929fb4e009cd860a93aa74570a4e9","unresolved":false,"context_lines":[{"line_number":633,"context_line":"            transport \u003d url.transport.replace(\u0027kombu+\u0027, \u0027\u0027)"},{"line_number":634,"context_line":"            self._url \u003d \"%s://%s\" % ("},{"line_number":635,"context_line":"                transport,"},{"line_number":636,"context_line":"                self._parse_url_hostname(virtual_host))"},{"line_number":637,"context_line":"        else:"},{"line_number":638,"context_line":"            for adr in self.driver_conf.rabbit_hosts:"},{"line_number":639,"context_line":"                hostname, port \u003d netutils.parse_host_port("}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_bc5ad44d","line":636,"updated":"2015-03-19 15:18:18.000000000","message":"same here.","commit_id":"4e3bdaca46798f6033d30d5fa4f2bc80dc83fb0a"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"882a1eea91e20aadab70c349ba70ff45e7fa4c2c","unresolved":false,"context_lines":[{"line_number":735,"context_line":"        parsed_host \u003d \u0027\u0027"},{"line_number":736,"context_line":"        try:"},{"line_number":737,"context_line":"            ip \u003d netaddr.IPAddress(hostname)"},{"line_number":738,"context_line":"            if ip.version \u003d\u003d 6:"},{"line_number":739,"context_line":"                parsed_host \u003d \u0027[%s]\u0027 % ip.format()"},{"line_number":740,"context_line":"            else:"},{"line_number":741,"context_line":"                parsed_host \u003d ip.format()"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_281762a4","line":738,"updated":"2015-03-20 06:51:44.000000000","message":"If using netaddr is not compatible with python2.6, so just do:\n\n   return \u0027[%s]\u0027 % hostname if \u0027:\u0027 in hostname else hostname\n\nlike other part of oslo.messaging already does for detecting ipv6.","commit_id":"07e7e709dbf36e5d3a9976b47c7e56ed9fc90159"},{"author":{"_account_id":11166,"name":"Lukas Bezdicka","email":"social@v3.sk","username":"xbezdick"},"change_message_id":"c86baf9261aa364a710e1500780878d8563942c1","unresolved":false,"context_lines":[{"line_number":735,"context_line":"        parsed_host \u003d \u0027\u0027"},{"line_number":736,"context_line":"        try:"},{"line_number":737,"context_line":"            ip \u003d netaddr.IPAddress(hostname)"},{"line_number":738,"context_line":"            if ip.version \u003d\u003d 6:"},{"line_number":739,"context_line":"                parsed_host \u003d \u0027[%s]\u0027 % ip.format()"},{"line_number":740,"context_line":"            else:"},{"line_number":741,"context_line":"                parsed_host \u003d ip.format()"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_d22cadae","line":738,"in_reply_to":"9a80dd14_281762a4","updated":"2015-03-20 10:08:43.000000000","message":"It\u0027s not netaddr being incompatible in python2.6 but kombu uses url parse and in python 2.6 it fails to parse ipv6 address in brackets in python\u0027s urlparse library. So this change would only save dependency and I\u0027m pretty sure we should use netaddr in oslo bit more for checking.","commit_id":"07e7e709dbf36e5d3a9976b47c7e56ed9fc90159"}]}