)]}'
{"oslo_messaging/conffixture.py":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"40c1528b7ea826798bc309bc1e3e755a30aaf027","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        self.conf.set_override(\u0027rpc_response_timeout\u0027, value)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    @property"},{"line_number":87,"context_line":"    def notification_driver(self):"},{"line_number":88,"context_line":"        return self.conf.notification_driver"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @notification_driver.setter"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_c792659f","line":87,"updated":"2015-03-31 10:16:18.000000000","message":"This fixture is an helper for people that want change configuration of oslo.messaging in their tests, not for the oslo.messaging tests themself.\n\nBut anyway, that make sense to propose this two options outside.","commit_id":"7bf6b9d068eec825ac37d6b92f9444ea1cff2096"},{"author":{"_account_id":1678,"name":"Tiantian Gao","email":"gtt116@gmail.com","username":"gtt116"},"change_message_id":"7e91dc559e92fbae2219d9597aa6d7290d63b00e","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        self.conf.set_override(\u0027rpc_response_timeout\u0027, value)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    @property"},{"line_number":87,"context_line":"    def notification_driver(self):"},{"line_number":88,"context_line":"        return self.conf.notification_driver"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @notification_driver.setter"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_d76d5299","line":87,"in_reply_to":"da9b358b_c792659f","updated":"2015-04-01 02:19:09.000000000","message":"I removed these property function out. Instead, directly setting these two config in testcase like what class SkipIfNoTransportURL do.","commit_id":"7bf6b9d068eec825ac37d6b92f9444ea1cff2096"}],"oslo_messaging/tests/functional/notify/test_logger.py":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"40c1528b7ea826798bc309bc1e3e755a30aaf027","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def test_logging(self):"},{"line_number":51,"context_line":"        if self.url.startswith(\"amqp:\"):"},{"line_number":52,"context_line":"            self.skipTest(\"QPID-6307\")"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        # NOTE(gtt): Using different topic to make tests run in parallel"},{"line_number":55,"context_line":"        topic \u003d \u0027test_logging_%s_driver_%s\u0027 % (self.priority, self.driver)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_87ffbda9","line":52,"updated":"2015-03-31 10:16:18.000000000","message":"Hum, this should works with \"amqp:\", from what I understand, this bug occurs only when you have multiple listeners listening on the same topic, this test use only 1, why do you skip it ?","commit_id":"7bf6b9d068eec825ac37d6b92f9444ea1cff2096"},{"author":{"_account_id":1678,"name":"Tiantian Gao","email":"gtt116@gmail.com","username":"gtt116"},"change_message_id":"7e91dc559e92fbae2219d9597aa6d7290d63b00e","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def test_logging(self):"},{"line_number":51,"context_line":"        if self.url.startswith(\"amqp:\"):"},{"line_number":52,"context_line":"            self.skipTest(\"QPID-6307\")"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        # NOTE(gtt): Using different topic to make tests run in parallel"},{"line_number":55,"context_line":"        topic \u003d \u0027test_logging_%s_driver_%s\u0027 % (self.priority, self.driver)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_173cdac6","line":52,"in_reply_to":"da9b358b_0993b650","updated":"2015-04-01 02:19:09.000000000","message":"Thanks Ken,  I will tag \u0027#1438742\u0027 in the skip explain message.","commit_id":"7bf6b9d068eec825ac37d6b92f9444ea1cff2096"},{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"127cf9eee0267098a6f089a5f83624cdddb2e267","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def test_logging(self):"},{"line_number":51,"context_line":"        if self.url.startswith(\"amqp:\"):"},{"line_number":52,"context_line":"            self.skipTest(\"QPID-6307\")"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        # NOTE(gtt): Using different topic to make tests run in parallel"},{"line_number":55,"context_line":"        topic \u003d \u0027test_logging_%s_driver_%s\u0027 % (self.priority, self.driver)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_0993b650","line":52,"in_reply_to":"da9b358b_416d1c97","updated":"2015-03-31 15:00:29.000000000","message":"I\u0027ve confirmed this is a problem with the AMQP 1.0 driver:\n\nhttps://bugs.launchpad.net/oslo.messaging/+bug/1438742\n\nI\u0027ll post a fix shortly.","commit_id":"7bf6b9d068eec825ac37d6b92f9444ea1cff2096"},{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"78b5596029ed15644e9556479f54e0f046717591","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def test_logging(self):"},{"line_number":51,"context_line":"        if self.url.startswith(\"amqp:\"):"},{"line_number":52,"context_line":"            self.skipTest(\"QPID-6307\")"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        # NOTE(gtt): Using different topic to make tests run in parallel"},{"line_number":55,"context_line":"        topic \u003d \u0027test_logging_%s_driver_%s\u0027 % (self.priority, self.driver)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_416d1c97","line":52,"in_reply_to":"da9b358b_87ffbda9","updated":"2015-03-31 13:24:11.000000000","message":"Interesting:  I just tried this patch against amqp1 and it does in fact fail.  The tests that fail involve the messagingv2 driver.  The tests that use the messaging driver do in fact pass (I commented out the messagingv2 entry in the driver list).\n\nI\u0027ll have to investigate this a bit further.  Until I can root cause this, it\u0027s best to leave that skipTest in for amqp:.","commit_id":"7bf6b9d068eec825ac37d6b92f9444ea1cff2096"}]}
