)]}'
{"oslo_messaging/_drivers/impl_rabbit.py":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"3f7cfce47327533960886d746ab35f31645ad730","unresolved":false,"context_lines":[{"line_number":390,"context_line":"            # AMQP TTL is in milliseconds when set in the property."},{"line_number":391,"context_line":"            # Details: http://www.rabbitmq.com/ttl.html#per-message-ttl"},{"line_number":392,"context_line":"            #"},{"line_number":393,"context_line":"            self.producer.publish(msg, expiration\u003dstr(timeout * 1000))"},{"line_number":394,"context_line":"        else:"},{"line_number":395,"context_line":"            self.producer.publish(msg)"},{"line_number":396,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a0c5dc1_13c7cf13","line":393,"updated":"2015-05-12 08:24:39.000000000","message":"looks like it should be a int","commit_id":"2b2e19a3e7fc9cd04eeb9c03afe69e4422cd64cb"}],"oslo_messaging/tests/drivers/test_impl_rabbit.py":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"3533c75a8e25dcb49970160cafb7df26290f6dab","unresolved":false,"context_lines":[{"line_number":897,"context_line":"                                            \u0027exchange\u0027,"},{"line_number":898,"context_line":"                                            \u0027routing_key\u0027)"},{"line_number":899,"context_line":"        publisher.send(\u0027msg\u0027, 1)"},{"line_number":900,"context_line":"        fake_publish.assert_called_with(\u0027msg\u0027, expiration\u003d\u00271000\u0027)"},{"line_number":901,"context_line":""},{"line_number":902,"context_line":"    @mock.patch(\u0027kombu.messaging.Producer.publish\u0027)"},{"line_number":903,"context_line":"    @mock.patch(\u0027kombu.messaging.Exchange.declare\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ab451fb_d40c9244","line":900,"updated":"2015-04-17 08:57:35.000000000","message":"That mock what we want to test..., this doesn\u0027t test that the expiration works.","commit_id":"7db0f6f25d0b38bb76e3a2a7c472508c0bdfaa7c"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"0e4bd7611213fcdbba8c95bda1621ae8869b09f5","unresolved":false,"context_lines":[{"line_number":897,"context_line":"                                            \u0027exchange\u0027,"},{"line_number":898,"context_line":"                                            \u0027routing_key\u0027)"},{"line_number":899,"context_line":"        publisher.send(\u0027msg\u0027, 1)"},{"line_number":900,"context_line":"        fake_publish.assert_called_with(\u0027msg\u0027, expiration\u003d\u00271000\u0027)"},{"line_number":901,"context_line":""},{"line_number":902,"context_line":"    @mock.patch(\u0027kombu.messaging.Producer.publish\u0027)"},{"line_number":903,"context_line":"    @mock.patch(\u0027kombu.messaging.Exchange.declare\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ad0253b_c8ee1bec","line":900,"in_reply_to":"3ab451fb_281d9973","updated":"2015-04-29 11:51:07.000000000","message":"We already have a functionnal test that tests the timeout from the public API PoV, \nthe code works, but the unused message stay on the queue for rabbit.","commit_id":"7db0f6f25d0b38bb76e3a2a7c472508c0bdfaa7c"},{"author":{"_account_id":1678,"name":"Tiantian Gao","email":"gtt116@gmail.com","username":"gtt116"},"change_message_id":"05eb80d3b20906bd62819a983edddf41edb9e972","unresolved":false,"context_lines":[{"line_number":897,"context_line":"                                            \u0027exchange\u0027,"},{"line_number":898,"context_line":"                                            \u0027routing_key\u0027)"},{"line_number":899,"context_line":"        publisher.send(\u0027msg\u0027, 1)"},{"line_number":900,"context_line":"        fake_publish.assert_called_with(\u0027msg\u0027, expiration\u003d\u00271000\u0027)"},{"line_number":901,"context_line":""},{"line_number":902,"context_line":"    @mock.patch(\u0027kombu.messaging.Producer.publish\u0027)"},{"line_number":903,"context_line":"    @mock.patch(\u0027kombu.messaging.Exchange.declare\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ab451fb_281d9973","line":900,"in_reply_to":"3ab451fb_d40c9244","updated":"2015-04-17 10:52:13.000000000","message":"So we should add a function test?","commit_id":"7db0f6f25d0b38bb76e3a2a7c472508c0bdfaa7c"}]}