)]}'
{"oslo_messaging/_drivers/impl_rabbit.py":[{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"58ef6d0f3bbd1baa39b2e8f2146ef8a2045d76fa","unresolved":false,"context_lines":[{"line_number":836,"context_line":"        # NOTE(sileht): they are some case where the heartbeat check"},{"line_number":837,"context_line":"        # or the producer.send return only when the system socket"},{"line_number":838,"context_line":"        # timeout if reach. kombu doesn\u0027t allow use to customise this"},{"line_number":839,"context_line":"        # timeout so for py-amqp we tweak ourself"},{"line_number":840,"context_line":"        sock \u003d getattr(self.connection.transport, \u0027sock\u0027, None)"},{"line_number":841,"context_line":"        if sock:"},{"line_number":842,"context_line":"            orig_timeout \u003d sock.gettimeout()"}],"source_content_type":"text/x-python","patch_set":8,"id":"1aca2d91_ca2f2aa0","line":839,"updated":"2015-05-06 21:58:58.000000000","message":"Should there be an attempt to make a github issue to get this done in a more offical manner (via having an option to set it in kombu?), maybe u already opened one? Seems like this hack would be nice to have a upstream request to fix (and then remove the hack when the fix happens and is released).","commit_id":"651903bd435e1fecc8bcaca854e8ab5673142e4d"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"52f951187eae676b8f64a4d77493eabae22d8a09","unresolved":false,"context_lines":[{"line_number":836,"context_line":"        # NOTE(sileht): they are some case where the heartbeat check"},{"line_number":837,"context_line":"        # or the producer.send return only when the system socket"},{"line_number":838,"context_line":"        # timeout if reach. kombu doesn\u0027t allow use to customise this"},{"line_number":839,"context_line":"        # timeout so for py-amqp we tweak ourself"},{"line_number":840,"context_line":"        sock \u003d getattr(self.connection.transport, \u0027sock\u0027, None)"},{"line_number":841,"context_line":"        if sock:"},{"line_number":842,"context_line":"            orig_timeout \u003d sock.gettimeout()"}],"source_content_type":"text/x-python","patch_set":8,"id":"1aca2d91_88ddb044","line":839,"in_reply_to":"1aca2d91_ca2f2aa0","updated":"2015-05-07 07:03:41.000000000","message":"They are GH issues open about that. They start to write some code to set default timeout to a socket. \n\n  The issue: https://github.com/celery/kombu/issues/463\n  My PoC of fix: https://github.com/celery/py-amqp/pull/65\n  The fix that have good chance to be merge once it will be finish: https://github.com/celery/py-amqp/pull/64\n\nMy hack is a bit smarter because it use the application timeout, to returns earlier. But in most case this is not used by application, so this is perhaps a wrong optimization.\n\nIf kombu release a version before Liberty and people agree to depends to the latest kombu/amqp (this can be hard, if dist don\u0027t want to package the new versions).\n\nAll the timeout issue in oslo.messaging is a so hot subject, that I think we should have it for L and use the kombu fix later.","commit_id":"651903bd435e1fecc8bcaca854e8ab5673142e4d"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"66b9453ba81dbc2bc5c511897e4dfd6314bcb605","unresolved":false,"context_lines":[{"line_number":839,"context_line":"        # NOTE(sileht): they are some case where the heartbeat check"},{"line_number":840,"context_line":"        # or the producer.send return only when the system socket"},{"line_number":841,"context_line":"        # timeout if reach. kombu doesn\u0027t allow use to customise this"},{"line_number":842,"context_line":"        # timeout so for py-amqp we tweak ourself"},{"line_number":843,"context_line":"        sock \u003d getattr(self.connection.transport, \u0027sock\u0027, None)"},{"line_number":844,"context_line":"        if sock:"},{"line_number":845,"context_line":"            orig_timeout \u003d sock.gettimeout()"}],"source_content_type":"text/x-python","patch_set":9,"id":"1aca2d91_19679426","line":842,"updated":"2015-05-07 19:30:01.000000000","message":"So all those PR requests and issues u just mentioned (in the last comments on the prior commit/tweak), it\u0027d be nice to put a TODO here with those links, so that people can know right? And they can see that this code may not be needed if py-ampq or kombu allow us to do this differently...","commit_id":"1c71e92de83deff3478dd7edf5ab6089c616d0e4"}]}