)]}'
{"oslo_messaging/_drivers/impl_rabbit.py":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"ab95e144621ba22111cbab3ac878d1c6b3d0fd77","unresolved":false,"context_lines":[{"line_number":545,"context_line":"            return ssl_params or True"},{"line_number":546,"context_line":"        return False"},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"    def _on_connection_blocked(self, reason):"},{"line_number":549,"context_line":"        LOG.warn(_LW(\"The broker have blocked the connection: %s\", reason))"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"    def _on_connection_unblocked(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_aefdf43c","line":548,"updated":"2015-05-27 14:29:54.000000000","message":"I think that error level is more appropriate. After all getting this message means that all messages will not be delivered. I think the operator would really like to know this so that he can go unblock his rabbit server :)","commit_id":"0e7be0e96fb09cfc8d9f0ea477c0468d062a1d2e"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"34f2f61d55c2c6fc588a9b3e65894399388361bc","unresolved":false,"context_lines":[{"line_number":545,"context_line":"            return ssl_params or True"},{"line_number":546,"context_line":"        return False"},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"    def _on_connection_blocked(self, reason):"},{"line_number":549,"context_line":"        LOG.warn(_LW(\"The broker have blocked the connection: %s\", reason))"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"    def _on_connection_unblocked(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_49079a81","line":548,"in_reply_to":"7a016987_aefdf43c","updated":"2015-05-27 14:43:16.000000000","message":"Yep your right :), done","commit_id":"0e7be0e96fb09cfc8d9f0ea477c0468d062a1d2e"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"c7e9e90f3d93342cf71d54b4fbbce55a4fc5ce35","unresolved":false,"context_lines":[{"line_number":546,"context_line":"            return ssl_params or True"},{"line_number":547,"context_line":"        return False"},{"line_number":548,"context_line":""},{"line_number":549,"context_line":"    def _on_connection_blocked(self, reason):"},{"line_number":550,"context_line":"        LOG.error(_LE(\"The broker have blocked the connection: %s\"), reason)"},{"line_number":551,"context_line":""},{"line_number":552,"context_line":"    def _on_connection_unblocked(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_f4e484a8","line":549,"updated":"2015-05-29 13:30:30.000000000","message":"just a question - do we really need to add these functions as a class methods?","commit_id":"26bc58f677c571da1caf18b55b75d6c6677d1570"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"85f9b61b24ea44ad630ec0fc3326bfd0977c6dc8","unresolved":false,"context_lines":[{"line_number":546,"context_line":"            return ssl_params or True"},{"line_number":547,"context_line":"        return False"},{"line_number":548,"context_line":""},{"line_number":549,"context_line":"    def _on_connection_blocked(self, reason):"},{"line_number":550,"context_line":"        LOG.error(_LE(\"The broker have blocked the connection: %s\"), reason)"},{"line_number":551,"context_line":""},{"line_number":552,"context_line":"    def _on_connection_unblocked(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_04612b39","line":549,"in_reply_to":"7a016987_f4e484a8","updated":"2015-05-29 14:49:20.000000000","message":"Move as static method.","commit_id":"26bc58f677c571da1caf18b55b75d6c6677d1570"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"468d0f103f0c800766ab709af962e00f772c9163","unresolved":false,"context_lines":[{"line_number":547,"context_line":"        return False"},{"line_number":548,"context_line":""},{"line_number":549,"context_line":"    def _on_connection_blocked(self, reason):"},{"line_number":550,"context_line":"        LOG.error(_LE(\"The broker have blocked the connection: %s\"), reason)"},{"line_number":551,"context_line":""},{"line_number":552,"context_line":"    def _on_connection_unblocked(self):"},{"line_number":553,"context_line":"        LOG.info(_LI(\"The broker have unblocked the connection\"))"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_2378d6c3","line":550,"updated":"2015-05-28 10:20:20.000000000","message":"s/have/has/","commit_id":"26bc58f677c571da1caf18b55b75d6c6677d1570"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"85f9b61b24ea44ad630ec0fc3326bfd0977c6dc8","unresolved":false,"context_lines":[{"line_number":547,"context_line":"        return False"},{"line_number":548,"context_line":""},{"line_number":549,"context_line":"    def _on_connection_blocked(self, reason):"},{"line_number":550,"context_line":"        LOG.error(_LE(\"The broker have blocked the connection: %s\"), reason)"},{"line_number":551,"context_line":""},{"line_number":552,"context_line":"    def _on_connection_unblocked(self):"},{"line_number":553,"context_line":"        LOG.info(_LI(\"The broker have unblocked the connection\"))"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_c456735d","line":550,"in_reply_to":"7a016987_2378d6c3","updated":"2015-05-29 14:49:20.000000000","message":"Done","commit_id":"26bc58f677c571da1caf18b55b75d6c6677d1570"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"468d0f103f0c800766ab709af962e00f772c9163","unresolved":false,"context_lines":[{"line_number":550,"context_line":"        LOG.error(_LE(\"The broker have blocked the connection: %s\"), reason)"},{"line_number":551,"context_line":""},{"line_number":552,"context_line":"    def _on_connection_unblocked(self):"},{"line_number":553,"context_line":"        LOG.info(_LI(\"The broker have unblocked the connection\"))"},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"    def ensure_connection(self):"},{"line_number":556,"context_line":"        self.ensure(method\u003dlambda: True)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_c37c62b7","line":553,"updated":"2015-05-28 10:20:20.000000000","message":"Ditto","commit_id":"26bc58f677c571da1caf18b55b75d6c6677d1570"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"85f9b61b24ea44ad630ec0fc3326bfd0977c6dc8","unresolved":false,"context_lines":[{"line_number":550,"context_line":"        LOG.error(_LE(\"The broker have blocked the connection: %s\"), reason)"},{"line_number":551,"context_line":""},{"line_number":552,"context_line":"    def _on_connection_unblocked(self):"},{"line_number":553,"context_line":"        LOG.info(_LI(\"The broker have unblocked the connection\"))"},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"    def ensure_connection(self):"},{"line_number":556,"context_line":"        self.ensure(method\u003dlambda: True)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_444ba3b1","line":553,"in_reply_to":"7a016987_c37c62b7","updated":"2015-05-29 14:49:20.000000000","message":"Done","commit_id":"26bc58f677c571da1caf18b55b75d6c6677d1570"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"3231903c99bc342d08a44f8d5770b4e29442ea11","unresolved":false,"context_lines":[{"line_number":552,"context_line":"        LOG.error(_LE(\"The broker has blocked the connection: %s\"), reason)"},{"line_number":553,"context_line":""},{"line_number":554,"context_line":"    @staticmethod"},{"line_number":555,"context_line":"    def _on_connection_unblocked(s):"},{"line_number":556,"context_line":"        LOG.info(_LI(\"The broker has unblocked the connection\"))"},{"line_number":557,"context_line":""},{"line_number":558,"context_line":"    def ensure_connection(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a016987_daee4e21","line":555,"updated":"2015-05-29 15:24:07.000000000","message":"Mehdi, Does not look like this method takes a parameter\n\nhttps://github.com/celery/py-amqp/blob/master/amqp/connection.py#L527","commit_id":"bd80bb60959e6ec2777c0d286bd0b682d7a63303"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"b21b8b9e6792b196e2e66e61a5c0426778511f14","unresolved":false,"context_lines":[{"line_number":552,"context_line":"        LOG.error(_LE(\"The broker has blocked the connection: %s\"), reason)"},{"line_number":553,"context_line":""},{"line_number":554,"context_line":"    @staticmethod"},{"line_number":555,"context_line":"    def _on_connection_unblocked(s):"},{"line_number":556,"context_line":"        LOG.info(_LI(\"The broker has unblocked the connection\"))"},{"line_number":557,"context_line":""},{"line_number":558,"context_line":"    def ensure_connection(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3afb71cf_05d73b24","line":555,"in_reply_to":"7a016987_daee4e21","updated":"2015-06-08 12:28:15.000000000","message":"Done","commit_id":"bd80bb60959e6ec2777c0d286bd0b682d7a63303"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"e59fc1c36d06d6ed635c93a9786a935285800a5e","unresolved":false,"context_lines":[{"line_number":552,"context_line":"        LOG.error(_LE(\"The broker has blocked the connection: %s\"), reason)"},{"line_number":553,"context_line":""},{"line_number":554,"context_line":"    @staticmethod"},{"line_number":555,"context_line":"    def _on_connection_unblocked(s):"},{"line_number":556,"context_line":"        LOG.info(_LI(\"The broker has unblocked the connection\"))"},{"line_number":557,"context_line":""},{"line_number":558,"context_line":"    def ensure_connection(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5afe65bd_ee033375","line":555,"in_reply_to":"7a016987_daee4e21","updated":"2015-06-01 16:50:41.000000000","message":"It looks strange for me, that unit tests didn\u0027t show this error. Should we test this as well?","commit_id":"bd80bb60959e6ec2777c0d286bd0b682d7a63303"}],"oslo_messaging/tests/drivers/test_impl_rabbit.py":[{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"c10fff7b5e9cf5b594f2efec3876c744084238b2","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        connection_klass.assert_called_once_with("},{"line_number":172,"context_line":"            \u0027memory:///\u0027, transport_options\u003d{\u0027confirm_publish\u0027: True,"},{"line_number":173,"context_line":"                                             \u0027on_blocked\u0027: mock.ANY,"},{"line_number":174,"context_line":"                                             \u0027on_unblocked\u0027: mock.ANY},"},{"line_number":175,"context_line":"            ssl\u003dself.expected, login_method\u003d\u0027AMQPLAIN\u0027,"},{"line_number":176,"context_line":"            heartbeat\u003d0, failover_strategy\u003d\"shuffle\")"},{"line_number":177,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3afb71cf_f9a4c6b9","line":174,"updated":"2015-06-08 14:01:20.000000000","message":"what do you think about something like this - \n\n $ git diff\n diff --git a/oslo_messaging/tests/drivers/test_impl_rabbit.py b/oslo_messaging/tests/drivers/test_impl_rabbit.py\n index 1e7f38c..6551215 100644\n --- a/oslo_messaging/tests/drivers/test_impl_rabbit.py\n +++ b/oslo_messaging/tests/drivers/test_impl_rabbit.py\n @@ -167,11 +167,12 @@ class TestRabbitDriverLoadSSL(test_utils.BaseTestCase):\n                                                   \u0027kombu+memory:////\u0027)\n          self.addCleanup(transport.cleanup)\n  \n -        transport._driver._get_connection()\n +        conn \u003d transport._driver._get_connection()\n +\n          connection_klass.assert_called_once_with(\n              \u0027memory:///\u0027, transport_options\u003d{\u0027confirm_publish\u0027: True,\n -                                             \u0027on_blocked\u0027: mock.ANY,\n -                                             \u0027on_unblocked\u0027: mock.ANY},\n +                                             \u0027on_blocked\u0027: conn.connection._on_connection_blocked,\n +                                             \u0027on_unblocked\u0027: conn.connection._on_connection_unblocked},\n              ssl\u003dself.expected, login_method\u003d\u0027AMQPLAIN\u0027,\n              heartbeat\u003d0, failover_strategy\u003d\"shuffle\")","commit_id":"178c4070b70b0affda19233d4759806781d9e12e"}]}
