)]}'
{"oslo_messaging/tests/functional/gate/post_test_hook.sh":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"3ceaa271c18a3ab2c6176406599fbfb8b68f9c49","unresolved":false,"context_lines":[{"line_number":47,"context_line":"\tif [ -x \"$(command -v yum)\" ]; then"},{"line_number":48,"context_line":"\t    sudo yum install -y qpid-cpp-server qpid-proton-c-devel python-qpid-proton cyrus-sasl-lib cyrus-sasl-plain libuuid-devel swig"},{"line_number":49,"context_line":"\telse"},{"line_number":50,"context_line":"\t    apt-get install -y uuid-devel swig"},{"line_number":51,"context_line":"\tfi"},{"line_number":52,"context_line":"        ;;"},{"line_number":53,"context_line":"    rabbit)"}],"source_content_type":"text/x-sh","patch_set":11,"id":"fa32b979_bb5e99e7","line":50,"updated":"2015-06-15 14:31:45.000000000","message":"If you plan to move the amqp1 job to ubuntu vm instead of fedora, you pehaps need to add \u0027qpidd\u0027 and \u0027sasl2-bin\u0027","commit_id":"8516e8ded9f07d740ed9021d2d80dc2f2a26391b"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"ac6cd0bb04d0103c79fb792f8ad070ff715489c1","unresolved":false,"context_lines":[{"line_number":47,"context_line":"\tif [ -x \"$(command -v yum)\" ]; then"},{"line_number":48,"context_line":"\t    sudo yum install -y qpid-cpp-server qpid-proton-c-devel python-qpid-proton cyrus-sasl-lib cyrus-sasl-plain libuuid-devel swig"},{"line_number":49,"context_line":"\telse"},{"line_number":50,"context_line":"\t    apt-get install -y uuid-devel swig"},{"line_number":51,"context_line":"\tfi"},{"line_number":52,"context_line":"        ;;"},{"line_number":53,"context_line":"    rabbit)"}],"source_content_type":"text/x-sh","patch_set":11,"id":"fa32b979_a63afc34","line":50,"in_reply_to":"fa32b979_bb5e99e7","updated":"2015-06-15 14:52:13.000000000","message":"yeah, I\u0027ll do that when that change actually happens.","commit_id":"8516e8ded9f07d740ed9021d2d80dc2f2a26391b"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"6a5d09d1a4cab35e794c4072ecc83f336823ac28","unresolved":false,"context_lines":[{"line_number":36,"context_line":"if [ -x \"$(command -v yum)\" ]; then"},{"line_number":37,"context_line":"    sudo yum install -y libuuid-devel swig"},{"line_number":38,"context_line":"else"},{"line_number":39,"context_line":"    apt-get install -y uuid-devel swig"},{"line_number":40,"context_line":"fi"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# Install required packages"}],"source_content_type":"text/x-sh","patch_set":12,"id":"fa32b979_f39f655d","line":39,"updated":"2015-06-15 15:23:16.000000000","message":"it\u0027s uuid-dev on ubuntu","commit_id":"08cd8e25ffdbe35b5f3f93308ef613cebab1fa49"}],"setup-test-env-amqp1_0.sh":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"b9011eb5010160c9e33bef3264ec75d808faa477","unresolved":false,"context_lines":[{"line_number":52,"context_line":"[ -x \"$(which qpid-config)\" ] \u0026\u0026 qpid-config -b stackqpid/secretqpid@localhost:65123"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"if [ -x \"$(command -v yum)\" ]; then"},{"line_number":55,"context_line":"    yum install -y libuuid-devel swig"},{"line_number":56,"context_line":"else"},{"line_number":57,"context_line":"    apt-get install -y uuid-devel swig"},{"line_number":58,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":10,"id":"fa32b979_cf1ddebe","line":55,"updated":"2015-06-15 12:25:35.000000000","message":"This script doesn\u0027t run as root and must work locally, I think you should move that in oslo_messaging/tests/functional/gate/post_test_hook.sh","commit_id":"eec6c0654c1414945b0605fd41845badd206c7ae"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"b9011eb5010160c9e33bef3264ec75d808faa477","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    apt-get install -y uuid-devel swig"},{"line_number":58,"context_line":"fi"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"pip install pyngus"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"$*"}],"source_content_type":"text/x-sh","patch_set":10,"id":"fa32b979_ef6d4233","line":60,"updated":"2015-06-15 12:25:35.000000000","message":"Should be in tox.ini\n\nIf we do this two changes, we can keep the same script for qpid/amqp1.0 target.","commit_id":"eec6c0654c1414945b0605fd41845badd206c7ae"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"59b1811707d6a30d50c8c24992ac93c45d786db4","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    apt-get install -y uuid-devel swig"},{"line_number":58,"context_line":"fi"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"pip install pyngus"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"$*"}],"source_content_type":"text/x-sh","patch_set":10,"id":"fa32b979_ac40a557","line":60,"in_reply_to":"fa32b979_ef6d4233","updated":"2015-06-15 13:20:27.000000000","message":"I agree!","commit_id":"eec6c0654c1414945b0605fd41845badd206c7ae"}],"tests/test_amqp_driver.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"5c42cea099685151bb22f6cfafac7e41bfdbf71f","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        return msgs"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"@testtools.skipUnless(six.PY2, \"No Py3K support yet\")"},{"line_number":74,"context_line":"class TestProtonDriverLoad(test_utils.BaseTestCase):"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa32b979_035ff3e5","line":73,"updated":"2015-06-16 08:55:52.000000000","message":"\"PY3K\", so 2000.","commit_id":"f06b19628fbb11a32797f1095eba7c07b6343433"}],"tox.ini":[{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"61a50eb27979235355e554c198b5b6095ec2c44d","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"[testenv:py27-func-amqp1]"},{"line_number":39,"context_line":"setenv \u003d TRANSPORT_URL\u003damqp://stackqpid:secretqpid@127.0.0.1//"},{"line_number":40,"context_line":"# NOTE(sileht): This gate job run in fedora21 because proton libs are not"},{"line_number":41,"context_line":"# available on ubuntu yet,"},{"line_number":42,"context_line":"commands \u003d python setup.py testr --slowest --testr-args\u003d\u0027oslo_messaging.tests.(functional|test_amqp_driver)\u0027"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-properties","patch_set":7,"id":"1af86dd1_d6db4e1a","line":40,"updated":"2015-06-12 17:24:59.000000000","message":"Hey Flavio - does this patch obviate the need for this comment?","commit_id":"66c0506bae88c6c4a7e91332b98efb4955443f9e"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"656d2f2996f871168f4c11962341d335f3144acf","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"[testenv:py27-func-amqp1]"},{"line_number":39,"context_line":"setenv \u003d TRANSPORT_URL\u003damqp://stackqpid:secretqpid@127.0.0.1//"},{"line_number":40,"context_line":"# NOTE(sileht): This gate job run in fedora21 because proton libs are not"},{"line_number":41,"context_line":"# available on ubuntu yet,"},{"line_number":42,"context_line":"commands \u003d python setup.py testr --slowest --testr-args\u003d\u0027oslo_messaging.tests.(functional|test_amqp_driver)\u0027"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-properties","patch_set":7,"id":"fa32b979_df48548a","line":40,"in_reply_to":"1af86dd1_d6db4e1a","updated":"2015-06-13 10:33:14.000000000","message":"Not really because functional tests still run just on fedora. :(\n\nI guess I could update it with something inherent to functional tests only.","commit_id":"66c0506bae88c6c4a7e91332b98efb4955443f9e"},{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"53f7f3aea4dc5ee7ae4ba584bb775e536825f291","unresolved":false,"context_lines":[{"line_number":39,"context_line":"setenv \u003d TRANSPORT_URL\u003damqp://stackqpid:secretqpid@127.0.0.1//"},{"line_number":40,"context_line":"# NOTE(sileht): This gate job run in fedora21 because proton libs are not"},{"line_number":41,"context_line":"# available on ubuntu yet,"},{"line_number":42,"context_line":"commands \u003d python setup.py testr --slowest --testr-args\u003d\u0027oslo_messaging.tests.(functional|test_amqp_driver)\u0027"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"[testenv:py27-func-zeromq]"},{"line_number":45,"context_line":"setenv \u003d TRANSPORT_URL\u003dzmq://"}],"source_content_type":"text/x-properties","patch_set":7,"id":"1af86dd1_9048395d","line":42,"updated":"2015-06-12 18:18:53.000000000","message":"Hmmm...\n\nThere a two sets of tests for the AMQP 1.0 driver: 1) a set of isolated (eg. no broker required) unit tests in test_amqp_driver, and 2) the functional tests which require a broker to run.\n\nSo... with this change, does that mean *everyone* can run the isolated unit tests?   If so, can test_amqp_driver be run by default for \u0027tox\u0027?   Note: it\u0027s still pending py3 support, so maybe the answer is \u0027not yet\u0027\n\nIf it becomes the case that test_amqp_driver can be run on all env\u0027s, we can remove the test_amqp_driver from the py27-func-amqp1 target and just leave the functional tests.","commit_id":"66c0506bae88c6c4a7e91332b98efb4955443f9e"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"656d2f2996f871168f4c11962341d335f3144acf","unresolved":false,"context_lines":[{"line_number":39,"context_line":"setenv \u003d TRANSPORT_URL\u003damqp://stackqpid:secretqpid@127.0.0.1//"},{"line_number":40,"context_line":"# NOTE(sileht): This gate job run in fedora21 because proton libs are not"},{"line_number":41,"context_line":"# available on ubuntu yet,"},{"line_number":42,"context_line":"commands \u003d python setup.py testr --slowest --testr-args\u003d\u0027oslo_messaging.tests.(functional|test_amqp_driver)\u0027"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"[testenv:py27-func-zeromq]"},{"line_number":45,"context_line":"setenv \u003d TRANSPORT_URL\u003dzmq://"}],"source_content_type":"text/x-properties","patch_set":7,"id":"fa32b979_9f5bac54","line":42,"in_reply_to":"1af86dd1_9048395d","updated":"2015-06-13 10:33:14.000000000","message":"it is actually being run by default in tox already because the test is skipped *just* if pyngus is not installed.\n\nI can/should remove test_amqp_driver to make this line equal to the rest of the drivers since the unittests are already tested in the python jobs.\n\nConsider it done!","commit_id":"66c0506bae88c6c4a7e91332b98efb4955443f9e"}]}
