)]}'
{"oslo_messaging/_drivers/impl_qpid.py":[{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"169ced4d1c6aebb08ef87a84265bdc6d71874f47","unresolved":false,"context_lines":[{"line_number":768,"context_line":"    \"\"\"qpidd Driver"},{"line_number":769,"context_line":""},{"line_number":770,"context_line":"    \"\"\""},{"line_number":771,"context_line":""},{"line_number":772,"context_line":"    def __init__(self, conf, url,"},{"line_number":773,"context_line":"                 default_exchange\u003dNone, allowed_remote_exmods\u003dNone):"},{"line_number":774,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_f94af426","line":771,"updated":"2015-06-20 14:51:50.000000000","message":"Hmmm, I\u0027m still thinking http://docs.openstack.org/developer/debtcollector/api.html#debtcollector.removals.remove makes more sense, just put it on the class?","commit_id":"0f1c4c9922bdc4de07076b7ec2b7ef8c22228758"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"3ca4983cd1108eff2149f846f7bf1a18de81fa0d","unresolved":false,"context_lines":[{"line_number":768,"context_line":"    \"\"\"qpidd Driver"},{"line_number":769,"context_line":""},{"line_number":770,"context_line":"    \"\"\""},{"line_number":771,"context_line":""},{"line_number":772,"context_line":"    def __init__(self, conf, url,"},{"line_number":773,"context_line":"                 default_exchange\u003dNone, allowed_remote_exmods\u003dNone):"},{"line_number":774,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_e0beacd3","line":771,"in_reply_to":"fa32b979_2031f4ec","updated":"2015-06-21 17:14:47.000000000","message":"Let me try with an example (feel free to try it yourself):\n\nhttp://paste.openstack.org/show/311036/\n\nSo the benefits of \u0027why\u0027 that I think,\n\n* Correctly uses the stacklevel param to show the user where there code that is using this class is (that\u0027s missing here).\n* More pythonic IMHO (?) since users can avoid looking into __init__ to figure out this class is deprecated. The decorator on-top of the class makes that pretty obvious.\n* Same format of the rest of the debtcollector messages, making the message formats more \u0027standardized\u0027.\n* World peace.\n\nAlso this should probably use/add: http://sphinx-doc.org/markup/para.html#directive-deprecated (which debtcollector can actually automatically add on in a future version).","commit_id":"0f1c4c9922bdc4de07076b7ec2b7ef8c22228758"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"36b8d78b822ca970382f8a44752577eb3ec7202f","unresolved":false,"context_lines":[{"line_number":768,"context_line":"    \"\"\"qpidd Driver"},{"line_number":769,"context_line":""},{"line_number":770,"context_line":"    \"\"\""},{"line_number":771,"context_line":""},{"line_number":772,"context_line":"    def __init__(self, conf, url,"},{"line_number":773,"context_line":"                 default_exchange\u003dNone, allowed_remote_exmods\u003dNone):"},{"line_number":774,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_14a8a4da","line":771,"in_reply_to":"fa32b979_a0b424d1","updated":"2015-06-22 12:03:23.000000000","message":"I went with a simple warning because, although all the things Josh mentioned are great, I thought that adding a dependency just for this case wouldn\u0027t be worth.\n\nOr better, we\u0027d add this dependency, then remove qpid and then? Remove the dependency? Leave it there?\n\nAs it is now, I\u0027d probably stick with the simple warning. If we use debtcollator I\u0027d probably advocate to just keep the dependency there.","commit_id":"0f1c4c9922bdc4de07076b7ec2b7ef8c22228758"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"ef52f1952713b5587f7368c1a4fa9eb906eafd32","unresolved":false,"context_lines":[{"line_number":768,"context_line":"    \"\"\"qpidd Driver"},{"line_number":769,"context_line":""},{"line_number":770,"context_line":"    \"\"\""},{"line_number":771,"context_line":""},{"line_number":772,"context_line":"    def __init__(self, conf, url,"},{"line_number":773,"context_line":"                 default_exchange\u003dNone, allowed_remote_exmods\u003dNone):"},{"line_number":774,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_a0b424d1","line":771,"in_reply_to":"fa32b979_e0930c4e","updated":"2015-06-21 17:45:42.000000000","message":"U guys decide, I do know it\u0027s not a lot of code either way.","commit_id":"0f1c4c9922bdc4de07076b7ec2b7ef8c22228758"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"ded911861e026aa2e960f898e89fd7ce3189a660","unresolved":false,"context_lines":[{"line_number":768,"context_line":"    \"\"\"qpidd Driver"},{"line_number":769,"context_line":""},{"line_number":770,"context_line":"    \"\"\""},{"line_number":771,"context_line":""},{"line_number":772,"context_line":"    def __init__(self, conf, url,"},{"line_number":773,"context_line":"                 default_exchange\u003dNone, allowed_remote_exmods\u003dNone):"},{"line_number":774,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_e0930c4e","line":771,"in_reply_to":"fa32b979_e0beacd3","updated":"2015-06-21 17:35:41.000000000","message":"Thanks Josh, that does sound awesome!","commit_id":"0f1c4c9922bdc4de07076b7ec2b7ef8c22228758"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"a28321fd5e6b74e5f50784114364d8914d17eeac","unresolved":false,"context_lines":[{"line_number":768,"context_line":"    \"\"\"qpidd Driver"},{"line_number":769,"context_line":""},{"line_number":770,"context_line":"    \"\"\""},{"line_number":771,"context_line":""},{"line_number":772,"context_line":"    def __init__(self, conf, url,"},{"line_number":773,"context_line":"                 default_exchange\u003dNone, allowed_remote_exmods\u003dNone):"},{"line_number":774,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_2031f4ec","line":771,"in_reply_to":"fa32b979_f94af426","updated":"2015-06-21 16:29:49.000000000","message":"Josh, you explain _that_ you think we should, but not why. The bit below is _very_ tiny and will only warn when the driver is loaded. So I\u0027m really confused why that needs to be any easier.","commit_id":"0f1c4c9922bdc4de07076b7ec2b7ef8c22228758"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"a28321fd5e6b74e5f50784114364d8914d17eeac","unresolved":false,"context_lines":[{"line_number":772,"context_line":"    def __init__(self, conf, url,"},{"line_number":773,"context_line":"                 default_exchange\u003dNone, allowed_remote_exmods\u003dNone):"},{"line_number":774,"context_line":""},{"line_number":775,"context_line":"        warnings.warn(_(\u0027The Qpid driver has been deprecated and it. \u0027"},{"line_number":776,"context_line":"                        \u0027The driver will be removed during the `M` \u0027"},{"line_number":777,"context_line":"                        \u0027development cycle.\u0027), DeprecationWarning)"},{"line_number":778,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_c04cc878","line":775,"updated":"2015-06-21 16:29:49.000000000","message":"s/ and it//","commit_id":"0f1c4c9922bdc4de07076b7ec2b7ef8c22228758"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"36b8d78b822ca970382f8a44752577eb3ec7202f","unresolved":false,"context_lines":[{"line_number":772,"context_line":"    def __init__(self, conf, url,"},{"line_number":773,"context_line":"                 default_exchange\u003dNone, allowed_remote_exmods\u003dNone):"},{"line_number":774,"context_line":""},{"line_number":775,"context_line":"        warnings.warn(_(\u0027The Qpid driver has been deprecated and it. \u0027"},{"line_number":776,"context_line":"                        \u0027The driver will be removed during the `M` \u0027"},{"line_number":777,"context_line":"                        \u0027development cycle.\u0027), DeprecationWarning)"},{"line_number":778,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_948b5468","line":775,"in_reply_to":"fa32b979_c04cc878","updated":"2015-06-22 12:03:23.000000000","message":"ops, ninja-editing","commit_id":"0f1c4c9922bdc4de07076b7ec2b7ef8c22228758"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"a28321fd5e6b74e5f50784114364d8914d17eeac","unresolved":false,"context_lines":[{"line_number":773,"context_line":"                 default_exchange\u003dNone, allowed_remote_exmods\u003dNone):"},{"line_number":774,"context_line":""},{"line_number":775,"context_line":"        warnings.warn(_(\u0027The Qpid driver has been deprecated and it. \u0027"},{"line_number":776,"context_line":"                        \u0027The driver will be removed during the `M` \u0027"},{"line_number":777,"context_line":"                        \u0027development cycle.\u0027), DeprecationWarning)"},{"line_number":778,"context_line":""},{"line_number":779,"context_line":"        opt_group \u003d cfg.OptGroup(name\u003d\u0027oslo_messaging_qpid\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_004b905a","line":776,"updated":"2015-06-21 16:29:49.000000000","message":"We could say \"The driver is planned to be removed\" .. \"will\" implies it cannot be changed, but saying it is planned just makes it clear \"The clock is ticking.\" Anyway, I like it as-is just fine.","commit_id":"0f1c4c9922bdc4de07076b7ec2b7ef8c22228758"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"36b8d78b822ca970382f8a44752577eb3ec7202f","unresolved":false,"context_lines":[{"line_number":773,"context_line":"                 default_exchange\u003dNone, allowed_remote_exmods\u003dNone):"},{"line_number":774,"context_line":""},{"line_number":775,"context_line":"        warnings.warn(_(\u0027The Qpid driver has been deprecated and it. \u0027"},{"line_number":776,"context_line":"                        \u0027The driver will be removed during the `M` \u0027"},{"line_number":777,"context_line":"                        \u0027development cycle.\u0027), DeprecationWarning)"},{"line_number":778,"context_line":""},{"line_number":779,"context_line":"        opt_group \u003d cfg.OptGroup(name\u003d\u0027oslo_messaging_qpid\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_74e7b040","line":776,"in_reply_to":"fa32b979_004b905a","updated":"2015-06-22 12:03:23.000000000","message":"ah good advice...\n\nflaper\u0027s-english++","commit_id":"0f1c4c9922bdc4de07076b7ec2b7ef8c22228758"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"39f57ece135131251420d74839c6177de4652fef","unresolved":false,"context_lines":[{"line_number":775,"context_line":"        warnings.warn(_(\u0027The Qpid driver has been deprecated. \u0027"},{"line_number":776,"context_line":"                        \u0027The driver is planned to be removed during the `M` \u0027"},{"line_number":777,"context_line":"                        \u0027development cycle.\u0027), DeprecationWarning)"},{"line_number":778,"context_line":""},{"line_number":779,"context_line":"        opt_group \u003d cfg.OptGroup(name\u003d\u0027oslo_messaging_qpid\u0027,"},{"line_number":780,"context_line":"                                 title\u003d\u0027QPID driver options\u0027)"},{"line_number":781,"context_line":"        conf.register_group(opt_group)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_11a428b7","line":778,"updated":"2015-06-22 15:51:09.000000000","message":"Use the \u0027stacklevel\u0027, also add http://sphinx-doc.org/markup/para.html#directive-deprecated to the class docstring, and otherwise looks ok to me :)","commit_id":"ba66f88ed402ef36a14288bf72a46e8e10a75b86"}]}