)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"83a42c023084419109baf8d1e95be7e62af22662","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"futures recommands to use functools.partial instead lambda."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Closes-bug: # 1474943"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ib69bf2b032cb4b5892c39d0b8d7ae00b9780452f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a41bdd9_7f6dc2ca","line":11,"updated":"2015-07-15 17:02:42.000000000","message":"typo here: remove space after #\n\nExcept of that, the patch looks good to me.","commit_id":"81a91e28487b95e164a73361ab30d4b35d7bd45a"}],"oslo_messaging/_executors/impl_pooledexecutor.py":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"d3071e49512113ffefe63dc3a4a5d3c6517e5c3d","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                    self._incomplete.append(fut)"},{"line_number":88,"context_line":"                # Run the other post processing of the callback when done..."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"                def done_wrapper(f, callback):"},{"line_number":91,"context_line":"                    callback.done()"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"                fut.add_done_callback(functools.partial(done_wrapper,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_049f8f5f","line":90,"updated":"2015-07-15 16:53:21.000000000","message":"It looks like parameters are defined in the wrong order. No?\n\nfunctools.partial(func, arg1)(args2) calls func(arg1, arg2).\n\ncallback should be the first parameter, and you should ignore the second parameter.","commit_id":"c58dc59c7c5f42fd08bd2ee2613402c0f5c3490e"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"89ff497e0c7620f9eeadd946d7273face29b5bc5","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                    self._incomplete.append(fut)"},{"line_number":88,"context_line":"                # Run the other post processing of the callback when done..."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"                def done_wrapper(f, callback):"},{"line_number":91,"context_line":"                    callback.done()"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"                fut.add_done_callback(functools.partial(done_wrapper,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_24d653f1","line":90,"in_reply_to":"9a41bdd9_049f8f5f","updated":"2015-07-15 16:55:09.000000000","message":"Done","commit_id":"c58dc59c7c5f42fd08bd2ee2613402c0f5c3490e"}]}
