)]}'
{"oslo_messaging/tests/drivers/test_impl_rabbit.py":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"b994be961947876270dbcb567c11a8f4c643d164","unresolved":false,"context_lines":[{"line_number":474,"context_line":"            # NOTE(sileht) all reply fail, first take"},{"line_number":475,"context_line":"            # kombu_reconnect_timeout seconds to fail"},{"line_number":476,"context_line":"            # next immediatly fail"},{"line_number":477,"context_line":"            self.assertAlmostEqual(0.54, time.time() - start, 1)"},{"line_number":478,"context_line":""},{"line_number":479,"context_line":"        self.assertEqual(len(senders), len(replies))"},{"line_number":480,"context_line":"        for i, reply in enumerate(replies):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_d8ffe8a8","line":477,"updated":"2015-07-17 09:03:14.000000000","message":"I don\u0027t like the assertAlmostEqual(), it\u0027s too complex for my little brain. I would prefer something more explicit:\n\ndt \u003d time.time() - start\nself.assertTrue(0.5 \u003c\u003d dt \u003c 0.6, dt)\n\nWould it be possible to use kombu_reconnect_timeout in the test?\n\ntimeout \u003d self.config.kombu_reconnect_timeout # not sure for the syntax\n\nself.assertTrue(timeout \u003c\u003d dt \u003c (timeout + 0.100), dt)\n\nBy the way, why only 0.6? Why not allowing up to 1 second for very slow VM?","commit_id":"22caf95949ef91e5def7afddfc4957d7af214988"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"4b69a343d778228c30d72def9c061080c2fb51f2","unresolved":false,"context_lines":[{"line_number":474,"context_line":"            # NOTE(sileht) all reply fail, first take"},{"line_number":475,"context_line":"            # kombu_reconnect_timeout seconds to fail"},{"line_number":476,"context_line":"            # next immediatly fail"},{"line_number":477,"context_line":"            self.assertAlmostEqual(0.54, time.time() - start, 1)"},{"line_number":478,"context_line":""},{"line_number":479,"context_line":"        self.assertEqual(len(senders), len(replies))"},{"line_number":480,"context_line":"        for i, reply in enumerate(replies):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_58ebd8b0","line":477,"in_reply_to":"9a41bdd9_d8ffe8a8","updated":"2015-07-17 09:09:58.000000000","message":"Done\n\n1 sec is too big, perhaps it can be 2x the kombu_reconnect_timeout.\nI guess 0.6 is safe, each times I have seen the gate job failing it was ~0.55","commit_id":"22caf95949ef91e5def7afddfc4957d7af214988"}]}