)]}'
{"oslo_messaging/_drivers/protocols/amqp/controller.py":[{"author":{"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},"change_message_id":"484a153d8a0b0ab87bcbe775c8e7c1e3ca009f1d","unresolved":false,"context_lines":[{"line_number":608,"context_line":"            if not self._reconnecting:"},{"line_number":609,"context_line":"                self._reconnecting \u003d True"},{"line_number":610,"context_line":"                self._replies \u003d None"},{"line_number":611,"context_line":"                d \u003d self._delay"},{"line_number":612,"context_line":"                LOG.info(\"delaying reconnect attempt for %d seconds\", d)"},{"line_number":613,"context_line":"                self.processor.schedule(lambda: self._do_reconnect(), d)"},{"line_number":614,"context_line":"                self._delay \u003d 1 if self._delay \u003d\u003d 0 else min(d * 2, 60)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_c5d514e5","line":611,"updated":"2015-08-31 19:06:05.000000000","message":"Why do we need \u0027d\u0027 variable ?","commit_id":"992c7ec5b0d27e6a188d8b320e6d9ad46d92ebfa"},{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"db7d9312135a3734359da27e1f119e54fcd0efa7","unresolved":false,"context_lines":[{"line_number":608,"context_line":"            if not self._reconnecting:"},{"line_number":609,"context_line":"                self._reconnecting \u003d True"},{"line_number":610,"context_line":"                self._replies \u003d None"},{"line_number":611,"context_line":"                d \u003d self._delay"},{"line_number":612,"context_line":"                LOG.info(\"delaying reconnect attempt for %d seconds\", d)"},{"line_number":613,"context_line":"                self.processor.schedule(lambda: self._do_reconnect(), d)"},{"line_number":614,"context_line":"                self._delay \u003d 1 if self._delay \u003d\u003d 0 else min(d * 2, 60)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_eb1acc16","line":611,"in_reply_to":"da20952f_c5d514e5","updated":"2015-09-03 13:07:04.000000000","message":"good catch - we don\u0027t.\n\nI\u0027ll fix this as part of https://review.openstack.org/#/c/204696 or sooner if I have to update this patch.","commit_id":"992c7ec5b0d27e6a188d8b320e6d9ad46d92ebfa"},{"author":{"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},"change_message_id":"fbba600aabece2e47b49cace7bb42e1206fada86","unresolved":false,"context_lines":[{"line_number":608,"context_line":"            if not self._reconnecting:"},{"line_number":609,"context_line":"                self._reconnecting \u003d True"},{"line_number":610,"context_line":"                self._replies \u003d None"},{"line_number":611,"context_line":"                d \u003d self._delay"},{"line_number":612,"context_line":"                LOG.info(\"delaying reconnect attempt for %d seconds\", d)"},{"line_number":613,"context_line":"                self.processor.schedule(lambda: self._do_reconnect(), d)"},{"line_number":614,"context_line":"                self._delay \u003d 1 if self._delay \u003d\u003d 0 else min(d * 2, 60)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_6b355c44","line":611,"in_reply_to":"da20952f_eb1acc16","updated":"2015-09-03 13:09:48.000000000","message":"Thank you","commit_id":"992c7ec5b0d27e6a188d8b320e6d9ad46d92ebfa"}],"oslo_messaging/_drivers/protocols/amqp/eventloop.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"2f5e2bdc9ea66d3f61de0a8fcf14040af8ccf575","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                return rc"},{"line_number":89,"context_line":"            except (socket.timeout, socket.error) as e:"},{"line_number":90,"context_line":"                # pyngus handles EAGAIN/EWOULDBLOCK and EINTER"},{"line_number":91,"context_line":"                self.connection.close_output()"},{"line_number":92,"context_line":"                self.connection.close()"},{"line_number":93,"context_line":"                self._handler.socket_error(str(e))"},{"line_number":94,"context_line":"                return pyngus.Connection.EOS"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_b079a5fe","line":91,"updated":"2015-09-03 12:50:43.000000000","message":"Looks like the connection could be a context manager and this could be handled there. Enhancements for a follow-up patch, I guess.","commit_id":"992c7ec5b0d27e6a188d8b320e6d9ad46d92ebfa"},{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"db7d9312135a3734359da27e1f119e54fcd0efa7","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                return rc"},{"line_number":89,"context_line":"            except (socket.timeout, socket.error) as e:"},{"line_number":90,"context_line":"                # pyngus handles EAGAIN/EWOULDBLOCK and EINTER"},{"line_number":91,"context_line":"                self.connection.close_output()"},{"line_number":92,"context_line":"                self.connection.close()"},{"line_number":93,"context_line":"                self._handler.socket_error(str(e))"},{"line_number":94,"context_line":"                return pyngus.Connection.EOS"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_0b5140d8","line":91,"in_reply_to":"da20952f_b079a5fe","updated":"2015-09-03 13:07:04.000000000","message":"This code was cut \u0026 pasta\u0027ed from the pyngus examples, which I\u0027ve previously verified against proton 0.10.   Having said that, sure - I\u0027d like to discuss this with you further.","commit_id":"992c7ec5b0d27e6a188d8b320e6d9ad46d92ebfa"}],"tox.ini":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"2f5e2bdc9ea66d3f61de0a8fcf14040af8ccf575","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"[testenv:py27-func-qpid]"},{"line_number":28,"context_line":"setenv \u003d TRANSPORT_URL\u003dqpid://stackqpid:secretqpid@127.0.0.1:65123//"},{"line_number":29,"context_line":"commands \u003d {toxinidir}/setup-test-env-qpid.sh 0-10 python setup.py testr --slowest --testr-args\u003d\u0027oslo_messaging.tests.functional\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"[testenv:py27-func-rabbit]"},{"line_number":32,"context_line":"commands \u003d {toxinidir}/setup-test-env-rabbit.sh python setup.py testr --slowest --testr-args\u003d\u0027oslo_messaging.tests.functional\u0027"}],"source_content_type":"text/x-properties","patch_set":2,"id":"da20952f_30035544","line":29,"updated":"2015-09-03 12:50:43.000000000","message":"why not 0.10 ? :P","commit_id":"992c7ec5b0d27e6a188d8b320e6d9ad46d92ebfa"},{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"db7d9312135a3734359da27e1f119e54fcd0efa7","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"[testenv:py27-func-qpid]"},{"line_number":28,"context_line":"setenv \u003d TRANSPORT_URL\u003dqpid://stackqpid:secretqpid@127.0.0.1:65123//"},{"line_number":29,"context_line":"commands \u003d {toxinidir}/setup-test-env-qpid.sh 0-10 python setup.py testr --slowest --testr-args\u003d\u0027oslo_messaging.tests.functional\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"[testenv:py27-func-rabbit]"},{"line_number":32,"context_line":"commands \u003d {toxinidir}/setup-test-env-rabbit.sh python setup.py testr --slowest --testr-args\u003d\u0027oslo_messaging.tests.functional\u0027"}],"source_content_type":"text/x-properties","patch_set":2,"id":"da20952f_4babb8d6","line":29,"in_reply_to":"da20952f_30035544","updated":"2015-09-03 13:07:04.000000000","message":"The old \"official\" standard never referred to it as \"0.10\"\n\n0-10 is the designation used by the standard\n\nBut the setup-test-env-qpid.sh will also accept \"0.10\" for those of us that prefer \u0027.\u0027 to \u0027-\u0027\n\n:)","commit_id":"992c7ec5b0d27e6a188d8b320e6d9ad46d92ebfa"}]}