)]}'
{"oslo_messaging/_drivers/common.py":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"35491549c3d081f3bc44c9cff77d6fe56304b223","unresolved":false,"context_lines":[{"line_number":290,"context_line":"    msg \u003d {_VERSION_KEY: _RPC_ENVELOPE_VERSION,"},{"line_number":291,"context_line":"           _MESSAGE_KEY: jsonutils.dumps(raw_msg)}"},{"line_number":292,"context_line":"    if hmac_key:"},{"line_number":293,"context_line":"        computed_mac \u003d hmac.new(hmac_key, msg[_MESSAGE_KEY])"},{"line_number":294,"context_line":"        msg[_MESSAGE_HMAC_KEY] \u003d computed_mac.hexdigest()"},{"line_number":295,"context_line":"    return msg"},{"line_number":296,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_a9af657c","line":293,"updated":"2015-10-13 10:54:18.000000000","message":"hmac.new() without no explicit digest module will raise an error on Python 3.6.\n\nhmac.new() uses MD5 digest by default. Is it safe? RFC 6151 suggests to stop using it for new protocols:\n\n   MD5 is no longer acceptable where collision resistance is required\n   such as digital signatures.  It is not urgent to stop using MD5 in\n   other ways, such as HMAC-MD5; however, since MD5 must not be used for\n   digital signatures, new protocol designs should not employ HMAC-MD5.\n\nhttps://tools.ietf.org/html/rfc6151","commit_id":"9b36b85173b5c6434479d0d35bdf4503f4748801"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"35491549c3d081f3bc44c9cff77d6fe56304b223","unresolved":false,"context_lines":[{"line_number":337,"context_line":""},{"line_number":338,"context_line":"    if hmac_key:"},{"line_number":339,"context_line":"        if _MESSAGE_HMAC_KEY not in msg:"},{"line_number":340,"context_line":"            raise HMacInvalidError()"},{"line_number":341,"context_line":"        provided_mac \u003d msg[_MESSAGE_HMAC_KEY]"},{"line_number":342,"context_line":"        computed_mac \u003d hmac.new(hmac_key, msg[_MESSAGE_KEY])"},{"line_number":343,"context_line":"        if not hmac.compare_digest(computed_mac.hexdigest(), provided_mac):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_a95765c9","line":340,"updated":"2015-10-13 10:54:18.000000000","message":"It may help debug to use a different error message if the HMAC key is missing and if the HMAC digest mismatch.","commit_id":"9b36b85173b5c6434479d0d35bdf4503f4748801"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"35491549c3d081f3bc44c9cff77d6fe56304b223","unresolved":false,"context_lines":[{"line_number":340,"context_line":"            raise HMacInvalidError()"},{"line_number":341,"context_line":"        provided_mac \u003d msg[_MESSAGE_HMAC_KEY]"},{"line_number":342,"context_line":"        computed_mac \u003d hmac.new(hmac_key, msg[_MESSAGE_KEY])"},{"line_number":343,"context_line":"        if not hmac.compare_digest(computed_mac.hexdigest(), provided_mac):"},{"line_number":344,"context_line":"            raise HMacInvalidError()"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"    raw_msg \u003d jsonutils.loads(msg[_MESSAGE_KEY])"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_295595c5","line":343,"updated":"2015-10-13 10:54:18.000000000","message":"This function is not available on Python older than Python 2.7.7.\n\nWe may have to wait for the change Ia603202a065d5b345608e712f63f7af21fd74dea.\n\nOpenStack Infra still rely on Ubuntu Trusty which only provides Python 2.7.6 (you may have to double check).","commit_id":"9b36b85173b5c6434479d0d35bdf4503f4748801"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"763ee98a968d806e8797e86771bf4243c55251d2","unresolved":false,"context_lines":[{"line_number":291,"context_line":"    msg \u003d {_VERSION_KEY: _RPC_ENVELOPE_VERSION,"},{"line_number":292,"context_line":"           _MESSAGE_KEY: jsonutils.dumps(raw_msg)}"},{"line_number":293,"context_line":"    if hmac_key:"},{"line_number":294,"context_line":"        computed_mac \u003d hmac.new(hmac_key, msg[_MESSAGE_KEY])"},{"line_number":295,"context_line":"        msg[_MESSAGE_HMAC_KEY] \u003d computed_mac.hexdigest()"},{"line_number":296,"context_line":"    return msg"},{"line_number":297,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_aa6d1e9a","line":294,"updated":"2016-02-22 05:00:11.000000000","message":"Avoid using MD5 which is the default for hmac. Better options are SHA256 or better.","commit_id":"cc1c9a08b4709d4ef60e369bf041044210c622ab"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"e3b0c05969b99b6c30415a9a4e7d43272d9861c4","unresolved":false,"context_lines":[{"line_number":341,"context_line":"            raise HMacInvalidError()"},{"line_number":342,"context_line":"        provided_mac \u003d msg[_MESSAGE_HMAC_KEY]"},{"line_number":343,"context_line":"        computed_mac \u003d hmac.new(hmac_key, msg[_MESSAGE_KEY])"},{"line_number":344,"context_line":"        if not hmac.compare_digest(computed_mac.hexdigest(), provided_mac):"},{"line_number":345,"context_line":"            raise HMacInvalidError()"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"    raw_msg \u003d jsonutils.loads(msg[_MESSAGE_KEY])"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_ecd0b221","line":344,"range":{"start_line":344,"start_character":20,"end_line":344,"end_character":34},"updated":"2016-02-29 09:18:13.000000000","message":"This need Python 2.7.7. Use oslo_utils.secretutils ?","commit_id":"cc1c9a08b4709d4ef60e369bf041044210c622ab"}]}
