)]}'
{"oslo_messaging/tests/notify/test_notifier.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3750d15aec81c44eca6def9883e8df3e25f38881","unresolved":false,"context_lines":[{"line_number":324,"context_line":"        logger \u003d mock.MagicMock()"},{"line_number":325,"context_line":"        logger.info \u003d mock.MagicMock()"},{"line_number":326,"context_line":"        message \u003d {\u0027password\u0027: \u0027passw0rd\u0027, \u0027event_type\u0027: \u0027foo\u0027}"},{"line_number":327,"context_line":"        json_str \u003d \u0027{\"password\": \"passw0rd\"}\u0027"},{"line_number":328,"context_line":"        mask_str \u003d json_str.replace(\u0027passw0rd\u0027, \u0027***\u0027)"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_66b9b0cb","line":327,"updated":"2015-08-20 22:14:40.000000000","message":"The event_type stuff should be in this right?\n\nSince you have jsonutils, just use it:\n\njson_str \u003d jsonutils.dumps(message)","commit_id":"c571ddc0b722fa900e4b2db644ef40bda18dcbd9"},{"author":{"_account_id":11803,"name":"Ryan Rossiter","email":"rlrossit@us.ibm.com","username":"rlrossiter"},"change_message_id":"c3dab88bcb8d64e47754927fec142a90a0dc2c89","unresolved":false,"context_lines":[{"line_number":324,"context_line":"        logger \u003d mock.MagicMock()"},{"line_number":325,"context_line":"        logger.info \u003d mock.MagicMock()"},{"line_number":326,"context_line":"        message \u003d {\u0027password\u0027: \u0027passw0rd\u0027, \u0027event_type\u0027: \u0027foo\u0027}"},{"line_number":327,"context_line":"        json_str \u003d \u0027{\"password\": \"passw0rd\"}\u0027"},{"line_number":328,"context_line":"        mask_str \u003d json_str.replace(\u0027passw0rd\u0027, \u0027***\u0027)"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_8b725d10","line":327,"in_reply_to":"fa1b9901_66b9b0cb","updated":"2015-08-24 13:13:58.000000000","message":"Done","commit_id":"c571ddc0b722fa900e4b2db644ef40bda18dcbd9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3750d15aec81c44eca6def9883e8df3e25f38881","unresolved":false,"context_lines":[{"line_number":325,"context_line":"        logger.info \u003d mock.MagicMock()"},{"line_number":326,"context_line":"        message \u003d {\u0027password\u0027: \u0027passw0rd\u0027, \u0027event_type\u0027: \u0027foo\u0027}"},{"line_number":327,"context_line":"        json_str \u003d \u0027{\"password\": \"passw0rd\"}\u0027"},{"line_number":328,"context_line":"        mask_str \u003d json_str.replace(\u0027passw0rd\u0027, \u0027***\u0027)"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"        with mock.patch.object(logging, \u0027getLogger\u0027) as gl:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_26fdf86d","line":328,"updated":"2015-08-20 22:14:40.000000000","message":"I think you can probably avoid the mock on strutils.mask_password, again, it\u0027s a pretty bare utility and I worry about false positives here when mocking out these utilities in the unit tests.","commit_id":"c571ddc0b722fa900e4b2db644ef40bda18dcbd9"},{"author":{"_account_id":11803,"name":"Ryan Rossiter","email":"rlrossit@us.ibm.com","username":"rlrossiter"},"change_message_id":"c3dab88bcb8d64e47754927fec142a90a0dc2c89","unresolved":false,"context_lines":[{"line_number":325,"context_line":"        logger.info \u003d mock.MagicMock()"},{"line_number":326,"context_line":"        message \u003d {\u0027password\u0027: \u0027passw0rd\u0027, \u0027event_type\u0027: \u0027foo\u0027}"},{"line_number":327,"context_line":"        json_str \u003d \u0027{\"password\": \"passw0rd\"}\u0027"},{"line_number":328,"context_line":"        mask_str \u003d json_str.replace(\u0027passw0rd\u0027, \u0027***\u0027)"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"        with mock.patch.object(logging, \u0027getLogger\u0027) as gl:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_0b5ded78","line":328,"in_reply_to":"fa1b9901_26fdf86d","updated":"2015-08-24 13:13:58.000000000","message":"Done","commit_id":"c571ddc0b722fa900e4b2db644ef40bda18dcbd9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3750d15aec81c44eca6def9883e8df3e25f38881","unresolved":false,"context_lines":[{"line_number":329,"context_line":""},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"        with mock.patch.object(logging, \u0027getLogger\u0027) as gl:"},{"line_number":332,"context_line":"            with mock.patch.object(jsonutils, \u0027dumps\u0027) as mock_dump:"},{"line_number":333,"context_line":"                with mock.patch.object(strutils, \u0027mask_password\u0027) as mask:"},{"line_number":334,"context_line":"                    mock_dump.return_value \u003d json_str"},{"line_number":335,"context_line":"                    mask.return_value \u003d mask_str"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_06c9d458","line":332,"updated":"2015-08-20 22:14:40.000000000","message":"Shouldn\u0027t need to mock this out, it\u0027s a pretty bare utility.","commit_id":"c571ddc0b722fa900e4b2db644ef40bda18dcbd9"},{"author":{"_account_id":11803,"name":"Ryan Rossiter","email":"rlrossit@us.ibm.com","username":"rlrossiter"},"change_message_id":"c3dab88bcb8d64e47754927fec142a90a0dc2c89","unresolved":false,"context_lines":[{"line_number":329,"context_line":""},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"        with mock.patch.object(logging, \u0027getLogger\u0027) as gl:"},{"line_number":332,"context_line":"            with mock.patch.object(jsonutils, \u0027dumps\u0027) as mock_dump:"},{"line_number":333,"context_line":"                with mock.patch.object(strutils, \u0027mask_password\u0027) as mask:"},{"line_number":334,"context_line":"                    mock_dump.return_value \u003d json_str"},{"line_number":335,"context_line":"                    mask.return_value \u003d mask_str"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_ab540154","line":332,"in_reply_to":"fa1b9901_06c9d458","updated":"2015-08-24 13:13:58.000000000","message":"Done","commit_id":"c571ddc0b722fa900e4b2db644ef40bda18dcbd9"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"698d4ac914b76ad5f37ee9333ff22df1a323be8f","unresolved":false,"context_lines":[{"line_number":322,"context_line":"        # Ensure that passwords are masked with notifications"},{"line_number":323,"context_line":"        driver \u003d _impl_log.LogDriver(None, None, None)"},{"line_number":324,"context_line":"        logger \u003d mock.MagicMock()"},{"line_number":325,"context_line":"        logger.info \u003d mock.MagicMock()"},{"line_number":326,"context_line":"        message \u003d {\u0027password\u0027: \u0027passw0rd\u0027, \u0027event_type\u0027: \u0027foo\u0027}"},{"line_number":327,"context_line":"        json_str \u003d jsonutils.dumps(message)"},{"line_number":328,"context_line":"        mask_str \u003d strutils.mask_password(json_str)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_cccaa84f","line":325,"updated":"2015-08-24 14:50:52.000000000","message":"nit: This seconds Magic.Mock() is useless","commit_id":"c990ee02faa9f88e07a27af12eae397e7e8097dc"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"c3254cecc6ac6bbe64dcbb0bf450569cae553669","unresolved":false,"context_lines":[{"line_number":322,"context_line":"        # Ensure that passwords are masked with notifications"},{"line_number":323,"context_line":"        driver \u003d _impl_log.LogDriver(None, None, None)"},{"line_number":324,"context_line":"        logger \u003d mock.MagicMock()"},{"line_number":325,"context_line":"        logger.info \u003d mock.MagicMock()"},{"line_number":326,"context_line":"        message \u003d {\u0027password\u0027: \u0027passw0rd\u0027, \u0027event_type\u0027: \u0027foo\u0027}"},{"line_number":327,"context_line":"        json_str \u003d jsonutils.dumps(message)"},{"line_number":328,"context_line":"        mask_str \u003d strutils.mask_password(json_str)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_ac7c14b6","line":325,"in_reply_to":"fa1b9901_cccaa84f","updated":"2015-08-24 14:57:10.000000000","message":"No need to block on this, if a new PS is required, that\u0027s fine.","commit_id":"c990ee02faa9f88e07a27af12eae397e7e8097dc"}]}
