)]}'
{"oslo_messaging/_drivers/amqpdriver.py":[{"author":{"_account_id":7109,"name":"Dmitry Mescheryakov (dmitryme)","email":"dmescheryakov@mirantis.com","username":"dmitryme"},"change_message_id":"eedb7f9efaa19ca15b615a90015f4a15aed0d29f","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                          \" %(msg_id)s reply queue: %(reply_q)s\" % {"},{"line_number":76,"context_line":"                              \u0027msg_id\u0027: self.msg_id,"},{"line_number":77,"context_line":"                              \u0027unique_id\u0027: unique_id,"},{"line_number":78,"context_line":"                              \u0027reply_q\u0027: self.reply_q})"},{"line_number":79,"context_line":"                conn.direct_send(self.reply_q, rpc_common.serialize_msg(msg))"},{"line_number":80,"context_line":"            except rpc_amqp.AMQPDestinationNotFound:"},{"line_number":81,"context_line":"                self._obsolete_reply_queues.add(self.reply_q, self.msg_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_94fce73f","line":78,"updated":"2015-09-14 12:35:49.000000000","message":"Right now two messages could be sent for a single reply and both are logged here. IMO we are not interested in both, we just need to know if the last one is sent, meaning that server ended processing the request. So I suggest to log a message only if ending \u003d\u003d True.\n\nIn case when a single message is sent, \u0027ending\u0027 will be True for that message. In case when two messages are sent, only the second message will have this flag set to true.","commit_id":"83ebb8ad5821980f25ca47c17569d03a06b5b6eb"},{"author":{"_account_id":7109,"name":"Dmitry Mescheryakov (dmitryme)","email":"dmescheryakov@mirantis.com","username":"dmitryme"},"change_message_id":"eedb7f9efaa19ca15b615a90015f4a15aed0d29f","unresolved":false,"context_lines":[{"line_number":288,"context_line":"    def __call__(self, message):"},{"line_number":289,"context_line":"        message.acknowledge()"},{"line_number":290,"context_line":"        incoming_msg_id \u003d message.pop(\u0027_msg_id\u0027, None)"},{"line_number":291,"context_line":"        LOG.debug(\"received reply msg_id: %s\" % incoming_msg_id)"},{"line_number":292,"context_line":"        self.waiters.put(incoming_msg_id, message)"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    def listen(self, msg_id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_1bd6c2c5","line":291,"updated":"2015-09-14 12:35:49.000000000","message":"If you agree with reasoning above, here it also makes sense to log only messages having \u0027ending\u0027 set to true.","commit_id":"83ebb8ad5821980f25ca47c17569d03a06b5b6eb"},{"author":{"_account_id":7109,"name":"Dmitry Mescheryakov (dmitryme)","email":"dmescheryakov@mirantis.com","username":"dmitryme"},"change_message_id":"eedb7f9efaa19ca15b615a90015f4a15aed0d29f","unresolved":false,"context_lines":[{"line_number":417,"context_line":"            self._waiter.listen(msg_id)"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"        log_msg \u003d \"CALL msg_id: %s \" % msg_id if wait_for_reply else \"CAST \""},{"line_number":420,"context_line":"        log_msg +\u003d \"unique_id: %s \" % unique_id"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"        try:"},{"line_number":423,"context_line":"            with self._get_connection(rpc_amqp.PURPOSE_SEND) as conn:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_dbffea32","line":420,"updated":"2015-09-14 12:35:49.000000000","message":"I suggest to avoid sending unique_id for call operations: msg_id is enough for them. We need unique_id only for casts, where there is no msg_id.","commit_id":"83ebb8ad5821980f25ca47c17569d03a06b5b6eb"},{"author":{"_account_id":7109,"name":"Dmitry Mescheryakov (dmitryme)","email":"dmescheryakov@mirantis.com","username":"dmitryme"},"change_message_id":"eedb7f9efaa19ca15b615a90015f4a15aed0d29f","unresolved":false,"context_lines":[{"line_number":439,"context_line":"                    exchange \u003d self._get_exchange(target)"},{"line_number":440,"context_line":"                    if target.server:"},{"line_number":441,"context_line":"                        topic \u003d \u0027%s.%s\u0027 % (target.topic, target.server)"},{"line_number":442,"context_line":"                    log_msg +\u003d \"NOTIFY exchange \u0027%(exchange)s\u0027\" \\"},{"line_number":443,"context_line":"                               \" topic \u0027%(topic)s\u0027\" % {"},{"line_number":444,"context_line":"                                   \u0027exchange\u0027: exchange,"},{"line_number":445,"context_line":"                                   \u0027topic\u0027: target.topic}"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_7b76de3f","line":442,"updated":"2015-09-14 12:35:49.000000000","message":"That message is the same as in case when notify \u003d\u003d True. Can we make it different? Specifically, output something else instead of \u0027NOTIFY\u0027?","commit_id":"83ebb8ad5821980f25ca47c17569d03a06b5b6eb"},{"author":{"_account_id":7109,"name":"Dmitry Mescheryakov (dmitryme)","email":"dmescheryakov@mirantis.com","username":"dmitryme"},"change_message_id":"c94e7c87f6fab9859897c938e7af8a15277e229c","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        if ctxt.reply_q:"},{"line_number":192,"context_line":"            log_msg +\u003d \"reply to %(queue)s msg_id: %(msg_id)s\" % {"},{"line_number":193,"context_line":"                \u0027queue\u0027: ctxt.reply_q, \u0027msg_id\u0027: ctxt.msg_id}"},{"line_number":194,"context_line":"        LOG.debug(log_msg)"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        self.incoming.append(AMQPIncomingMessage(self,"},{"line_number":197,"context_line":"                                                 ctxt.to_dict(),"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_e0f52fcb","line":194,"updated":"2015-09-15 10:11:45.000000000","message":"Lets completely split call and cast cases here like in other places:\n * For call we need only msg_id and reply_q. No unique_id is required, it only confuses.\n * For cast we need only unique_id","commit_id":"15c671408794fd2aa1e5cf0e7a5a7b5733369667"},{"author":{"_account_id":7109,"name":"Dmitry Mescheryakov (dmitryme)","email":"dmescheryakov@mirantis.com","username":"dmitryme"},"change_message_id":"c94e7c87f6fab9859897c938e7af8a15277e229c","unresolved":false,"context_lines":[{"line_number":416,"context_line":""},{"line_number":417,"context_line":"        if wait_for_reply:"},{"line_number":418,"context_line":"            self._waiter.listen(msg_id)"},{"line_number":419,"context_line":"            log_msg \u003d \"CALL msg_id: %s \" % msg_id if wait_for_reply else \"CAST \""},{"line_number":420,"context_line":"        else:"},{"line_number":421,"context_line":"            log_msg \u003d \"CAST unique_id: %s \" % unique_id"},{"line_number":422,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_7d77883a","line":419,"updated":"2015-09-15 10:11:45.000000000","message":"There is no need for\n\n  if wait_for_reply else \"CAST \"\n\nhere :-)","commit_id":"15c671408794fd2aa1e5cf0e7a5a7b5733369667"}]}
