)]}'
{"oslo_messaging/rpc/dispatcher.py":[{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"ac950be8b112baa889a6161e9fda5205735f9818","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        return self.serializer.serialize_entity(ctxt, result)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def __call__(self, incoming, executor_callback\u003dNone):"},{"line_number":135,"context_line":"        if self.ack_then_process:"},{"line_number":136,"context_line":"            incoming.acknowledge()"},{"line_number":137,"context_line":"        return utils.DispatcherExecutorContext("},{"line_number":138,"context_line":"            incoming, self._dispatch_and_reply,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_015e23e9","line":135,"updated":"2015-11-23 14:49:07.000000000","message":"Why we need to keep the old behavior: ack after dispatch? Is it really needed?","commit_id":"db340d62562100a8015110f430745c9554506de4"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"72d9edcdb6c63f487cae6c05410ed86440bbbc7b","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        return self.serializer.serialize_entity(ctxt, result)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def __call__(self, incoming, executor_callback\u003dNone):"},{"line_number":135,"context_line":"        if self.ack_then_process:"},{"line_number":136,"context_line":"            incoming.acknowledge()"},{"line_number":137,"context_line":"        return utils.DispatcherExecutorContext("},{"line_number":138,"context_line":"            incoming, self._dispatch_and_reply,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_971b311c","line":135,"in_reply_to":"ba8a016a_015e23e9","updated":"2015-11-23 15:16:42.000000000","message":"Keeping backwards compatibility perhaps","commit_id":"db340d62562100a8015110f430745c9554506de4"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"108386c27683db0071c2ae9086938b09852cbf7f","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        return self.serializer.serialize_entity(ctxt, result)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def __call__(self, incoming, executor_callback\u003dNone):"},{"line_number":135,"context_line":"        if self.ack_then_process:"},{"line_number":136,"context_line":"            incoming.acknowledge()"},{"line_number":137,"context_line":"        return utils.DispatcherExecutorContext("},{"line_number":138,"context_line":"            incoming, self._dispatch_and_reply,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_09d45d45","line":135,"in_reply_to":"ba8a016a_971b311c","updated":"2015-11-30 14:30:01.000000000","message":"Right, the timeout behaviors of the applications already using oslo.messaging may be changed with the behavior change. Keeping the flag set to use the current behavior lets applications opt in to using the new behavior in a way that can be tested before it goes live.","commit_id":"db340d62562100a8015110f430745c9554506de4"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"108386c27683db0071c2ae9086938b09852cbf7f","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        except ExpectedException as e:"},{"line_number":150,"context_line":"            LOG.debug(u\u0027Expected exception during message handling (%s)\u0027,"},{"line_number":151,"context_line":"                      e.exc_info[1])"},{"line_number":152,"context_line":"            if not self.ack_then_process:"},{"line_number":153,"context_line":"                incoming.acknowledge()"},{"line_number":154,"context_line":"            incoming.reply(failure\u003de.exc_info, log_failure\u003dFalse)"},{"line_number":155,"context_line":"        except Exception as e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_891ccd14","line":152,"updated":"2015-11-30 14:30:01.000000000","message":"I assume it\u0027s safe to potentially ack the same message multiple times? It might be clearer if lines 142-145 were wrapped in a (nested) try:finally that had the ack in the finally clause so it only appeared one time.","commit_id":"db340d62562100a8015110f430745c9554506de4"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"2ed43945471f8c78400d5532c7da5c264519cd5c","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        except ExpectedException as e:"},{"line_number":150,"context_line":"            LOG.debug(u\u0027Expected exception during message handling (%s)\u0027,"},{"line_number":151,"context_line":"                      e.exc_info[1])"},{"line_number":152,"context_line":"            if not self.ack_then_process:"},{"line_number":153,"context_line":"                incoming.acknowledge()"},{"line_number":154,"context_line":"            incoming.reply(failure\u003de.exc_info, log_failure\u003dFalse)"},{"line_number":155,"context_line":"        except Exception as e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_fb999ad1","line":152,"in_reply_to":"9a8ffd7b_891ccd14","updated":"2015-11-30 15:14:51.000000000","message":"IIUC, at least one ack would be issued here. While by default it would be at most once ack. I assumed the __call__ is expected to be run once, and the executor_callback is being async called.\n\nSo that would be absolutely natural to expect the app side will take care for duplicates then asking for the at least once delivery mode.","commit_id":"db340d62562100a8015110f430745c9554506de4"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"2803c3d42bb7dfee231fae52533dba8508438dc0","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        except ExpectedException as e:"},{"line_number":150,"context_line":"            LOG.debug(u\u0027Expected exception during message handling (%s)\u0027,"},{"line_number":151,"context_line":"                      e.exc_info[1])"},{"line_number":152,"context_line":"            if not self.ack_then_process:"},{"line_number":153,"context_line":"                incoming.acknowledge()"},{"line_number":154,"context_line":"            incoming.reply(failure\u003de.exc_info, log_failure\u003dFalse)"},{"line_number":155,"context_line":"        except Exception as e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_3b764207","line":152,"in_reply_to":"9a8ffd7b_fb999ad1","updated":"2015-11-30 15:18:53.000000000","message":"Um, I mean the self._dispatch. Is it non blocking? And incoming.reply will block the caller until dispatched? Correct?","commit_id":"db340d62562100a8015110f430745c9554506de4"}]}
