)]}'
{"oslo_messaging/_drivers/zmq_driver/matchmaker/base.py":[{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"3818c6755cfa8a748cf4de2712790813ffcb7713","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            full_timeout \u003d 0"},{"line_number":82,"context_line":"            retry_timeout \u003d 0"},{"line_number":83,"context_line":"        else:"},{"line_number":84,"context_line":"            if not isinstance(timeout, int):"},{"line_number":85,"context_line":"                raise ValueError("},{"line_number":86,"context_line":"                    \"timeout must be integer, not {0}\".format(type(timeout)))"},{"line_number":87,"context_line":"            retry_timeout \u003d timeout * 1000"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a2fa921_c5cccf37","line":84,"updated":"2015-10-06 16:33:14.000000000","message":"Probably this check is going to happen before all things?","commit_id":"857f34caab90f1256e449a6ed5b82f690ef83273"},{"author":{"_account_id":18654,"name":"Alexey Yelistratov","email":"ayelistratov@mirantis.com","username":"rohanion"},"change_message_id":"d5a63321d122dcd9adb7a8fe352aca0d91d9b6b6","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            full_timeout \u003d 0"},{"line_number":82,"context_line":"            retry_timeout \u003d 0"},{"line_number":83,"context_line":"        else:"},{"line_number":84,"context_line":"            if not isinstance(timeout, int):"},{"line_number":85,"context_line":"                raise ValueError("},{"line_number":86,"context_line":"                    \"timeout must be integer, not {0}\".format(type(timeout)))"},{"line_number":87,"context_line":"            retry_timeout \u003d timeout * 1000"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a2fa921_4800d634","line":84,"in_reply_to":"7a2fa921_c5cccf37","updated":"2015-10-06 16:56:25.000000000","message":"will fix in PS5","commit_id":"857f34caab90f1256e449a6ed5b82f690ef83273"},{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"3818c6755cfa8a748cf4de2712790813ffcb7713","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            if retry is None or retry \u003c 0:"},{"line_number":90,"context_line":"                full_timeout \u003d None"},{"line_number":91,"context_line":"            else:"},{"line_number":92,"context_line":"                if not isinstance(retry, int):"},{"line_number":93,"context_line":"                    raise ValueError("},{"line_number":94,"context_line":"                        \"retry must be integer, not {0}\".format(type(retry)))"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a2fa921_a59513e5","line":92,"updated":"2015-10-06 16:33:14.000000000","message":"The same as above, we can perform type check before any other processing.","commit_id":"857f34caab90f1256e449a6ed5b82f690ef83273"},{"author":{"_account_id":18654,"name":"Alexey Yelistratov","email":"ayelistratov@mirantis.com","username":"rohanion"},"change_message_id":"d5a63321d122dcd9adb7a8fe352aca0d91d9b6b6","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            if retry is None or retry \u003c 0:"},{"line_number":90,"context_line":"                full_timeout \u003d None"},{"line_number":91,"context_line":"            else:"},{"line_number":92,"context_line":"                if not isinstance(retry, int):"},{"line_number":93,"context_line":"                    raise ValueError("},{"line_number":94,"context_line":"                        \"retry must be integer, not {0}\".format(type(retry)))"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a2fa921_c89aa614","line":92,"in_reply_to":"7a2fa921_a59513e5","updated":"2015-10-06 16:56:25.000000000","message":"will fix in PS5","commit_id":"857f34caab90f1256e449a6ed5b82f690ef83273"},{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"3818c6755cfa8a748cf4de2712790813ffcb7713","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                    raise ValueError("},{"line_number":94,"context_line":"                        \"retry must be integer, not {0}\".format(type(retry)))"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"                full_timeout \u003d retry * retry_timeout"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        _retry \u003d retrying.retry(stop_max_delay\u003dfull_timeout,"},{"line_number":99,"context_line":"                                wait_fixed\u003dretry_timeout)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a2fa921_0575e7f7","line":96,"updated":"2015-10-06 16:33:14.000000000","message":"What happens here if retry\u003d0 but timeout \u003e 0? this will result in full_timeout \u003d 0 which is not correct for that case","commit_id":"857f34caab90f1256e449a6ed5b82f690ef83273"},{"author":{"_account_id":18654,"name":"Alexey Yelistratov","email":"ayelistratov@mirantis.com","username":"rohanion"},"change_message_id":"d5a63321d122dcd9adb7a8fe352aca0d91d9b6b6","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                    raise ValueError("},{"line_number":94,"context_line":"                        \"retry must be integer, not {0}\".format(type(retry)))"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"                full_timeout \u003d retry * retry_timeout"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        _retry \u003d retrying.retry(stop_max_delay\u003dfull_timeout,"},{"line_number":99,"context_line":"                                wait_fixed\u003dretry_timeout)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a2fa921_a8ee4a89","line":96,"in_reply_to":"7a2fa921_0575e7f7","updated":"2015-10-06 16:56:25.000000000","message":"if retry \u003d 0 then full_timeout is also 0 which results in\n\nretry(stop_max_delay\u003d0,wait_fixed\u003dtimeout*1000).\n\nif stop_max_delay equals 0 then no retries will happen","commit_id":"857f34caab90f1256e449a6ed5b82f690ef83273"}]}
