)]}'
{"oslo_messaging/notify/__init__.py":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"394a71964a26a51116d8442a9ad5ced0bfdd8cc3","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"__all__ \u003d [\u0027Notifier\u0027,"},{"line_number":17,"context_line":"           \u0027LoggingNotificationHandler\u0027,"},{"line_number":18,"context_line":"           \u0027get_transport\u0027,"},{"line_number":19,"context_line":"           \u0027get_notification_listener\u0027,"},{"line_number":20,"context_line":"           \u0027NotificationResult\u0027,"},{"line_number":21,"context_line":"           \u0027NotificationFilter\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a29b11f_5d753661","line":18,"updated":"2015-10-23 12:33:32.000000000","message":"This conflicts with the get_transport in transport.py, both are import in root module of oslo_messaging. By change the notifier one is loaded first and shallowed by the transport one, so that doesn\u0027t break anything.","commit_id":"fe73612ef0162ecc34c5b45162779109eed6709d"}],"oslo_messaging/notify/notifier.py":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"394a71964a26a51116d8442a9ad5ced0bfdd8cc3","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        pass"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"def get_transport(conf, url\u003dNone, allowed_remote_exmods\u003dNone, aliases\u003dNone):"},{"line_number":84,"context_line":"    if url is None:"},{"line_number":85,"context_line":"        conf.register_opts(_notifier_opts)"},{"line_number":86,"context_line":"        url \u003d conf.notification_transport_url"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a29b11f_1df01ec8","line":83,"updated":"2015-10-23 12:33:32.000000000","message":"What do you think if we call this get_notification_transport and move this to transport.py ? Or we move the one in transport into rpc directory ? Or having a rpc_transport_url, that fallback to the transport_url too. Or moving all rpc options into a group named [oslo_messaging_rpc] and notifications options into [oslo_messaging_notification] with in both a transport_url that use the in [DEFAULT] as deprecated fallback.\n\nThis is something that the listener can use too. It\u0027s more related to notify module that just the notify.notifier module.\n\nI think if we start to have some difference between notification and rpc, we must be clear about this separation. \nWe should inform lib consumers that use the notification listener, that they should use to this new method too.\n\nAnother solution can be to introspect the Transport object in get_notification_listener to warn about usage of wrong method.\n\nAt least the doc in listener.py must use the new method.","commit_id":"fe73612ef0162ecc34c5b45162779109eed6709d"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"831511a18d76dfa270e5d925d48c0f9c55b15f56","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    Alternatively, a Notifier object can be instantiated with a specific"},{"line_number":119,"context_line":"    driver or topic::"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        notifier \u003d notifier.Notifier(RPC_TRANSPORT,"},{"line_number":122,"context_line":"                                     \u0027compute.host\u0027,"},{"line_number":123,"context_line":"                                     driver\u003d\u0027messaging\u0027,"},{"line_number":124,"context_line":"                                     topic\u003d\u0027notifications\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da85f559_76755c96","line":121,"updated":"2015-11-10 14:02:29.000000000","message":"do we want to remove all RPC references?","commit_id":"92140ec07eb8b4e24957d7aa39a379609f7a45f7"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"2301b5f38e8b00b98394ebc084925dab15fcfa31","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    Alternatively, a Notifier object can be instantiated with a specific"},{"line_number":119,"context_line":"    driver or topic::"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        notifier \u003d notifier.Notifier(RPC_TRANSPORT,"},{"line_number":122,"context_line":"                                     \u0027compute.host\u0027,"},{"line_number":123,"context_line":"                                     driver\u003d\u0027messaging\u0027,"},{"line_number":124,"context_line":"                                     topic\u003d\u0027notifications\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da85f559_ef1e2fba","line":121,"in_reply_to":"da85f559_76755c96","updated":"2015-11-11 01:40:36.000000000","message":"Done","commit_id":"92140ec07eb8b4e24957d7aa39a379609f7a45f7"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"831511a18d76dfa270e5d925d48c0f9c55b15f56","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                      0 means no retry"},{"line_number":153,"context_line":"                      N means N retries"},{"line_number":154,"context_line":"        :type retry: int"},{"line_number":155,"context_line":"        \"\"\""},{"line_number":156,"context_line":"        transport.conf.register_opts(_notifier_opts)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        self.transport \u003d transport"}],"source_content_type":"text/x-python","patch_set":5,"id":"da85f559_36103401","line":155,"updated":"2015-11-10 14:02:29.000000000","message":"i think this will attempt to load _notifier_opts twice","commit_id":"92140ec07eb8b4e24957d7aa39a379609f7a45f7"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"2301b5f38e8b00b98394ebc084925dab15fcfa31","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                      0 means no retry"},{"line_number":153,"context_line":"                      N means N retries"},{"line_number":154,"context_line":"        :type retry: int"},{"line_number":155,"context_line":"        \"\"\""},{"line_number":156,"context_line":"        transport.conf.register_opts(_notifier_opts)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        self.transport \u003d transport"}],"source_content_type":"text/x-python","patch_set":5,"id":"da85f559_0fe1339a","line":155,"in_reply_to":"da85f559_36103401","updated":"2015-11-11 01:40:36.000000000","message":"y should be fine i think. we can\u0027t be sure whether it was intialized or not.","commit_id":"92140ec07eb8b4e24957d7aa39a379609f7a45f7"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"d7fe2283551b5d334ce392163b7ce65537e666bf","unresolved":false,"context_lines":[{"line_number":153,"context_line":"                      0 means no retry"},{"line_number":154,"context_line":"                      N means N retries"},{"line_number":155,"context_line":"        :type retry: int"},{"line_number":156,"context_line":"        \"\"\""},{"line_number":157,"context_line":"        transport.conf.register_opts(_notifier_opts)"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        self.transport \u003d transport"}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_c92230a3","line":156,"updated":"2015-11-11 13:57:13.000000000","message":"i\u0027m still worried about this. doesn\u0027t it raise DuplicateOptError if we try to register opt twice? it seems like if we don\u0027t use url to create transport, it will definitely register twice.","commit_id":"6621b9010e6c46cfff72be4ce0f7f5c2cad81b45"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"d74b483bada3708712c3ac8f0c0bbac23bdbaf7b","unresolved":false,"context_lines":[{"line_number":153,"context_line":"                      0 means no retry"},{"line_number":154,"context_line":"                      N means N retries"},{"line_number":155,"context_line":"        :type retry: int"},{"line_number":156,"context_line":"        \"\"\""},{"line_number":157,"context_line":"        transport.conf.register_opts(_notifier_opts)"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        self.transport \u003d transport"}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_dfef4285","line":156,"in_reply_to":"da85f559_c92230a3","updated":"2015-11-11 14:45:17.000000000","message":"seems to be working fine? http://paste.openstack.org/show/478558/","commit_id":"6621b9010e6c46cfff72be4ce0f7f5c2cad81b45"}]}
