)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"231e92e2a311a1804e5bc7b9b06cc30db3ae735e","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The oslo_config library provides new type PortOpt to validate the"},{"line_number":10,"context_line":"range of port now."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Icac28141bcb09e2b894662de1a6497766351919d"},{"line_number":13,"context_line":"ref: https://github.com/openstack/oslo.config/blob/2.6.0/oslo_config/cfg.py#L1114"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a8ffd7b_8a26c3cc","line":11,"updated":"2015-11-25 11:15:25.000000000","message":"Closes-Bug: #1518256","commit_id":"9f132771af5c077fbd71da761f53321d47ac1770"}],"oslo_messaging/_drivers/impl_zmq.py":[{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"ceb573b26ba17ead4bd9466b677405e9f39318e0","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                default\u003d49152,"},{"line_number":86,"context_line":"                help\u003d\u0027Minimal port number for random ports range.\u0027),"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    cfg.IntOpt(\u0027rpc_zmq_max_port\u0027,"},{"line_number":89,"context_line":"               default\u003d65536,"},{"line_number":90,"context_line":"               help\u003d\u0027Maximal port number for random ports range.\u0027),"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_4a4f7bbd","line":88,"updated":"2015-11-25 11:13:19.000000000","message":"What about this one?","commit_id":"9f132771af5c077fbd71da761f53321d47ac1770"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"c852cec77915bd1f4d8031339a57051c361a6cd0","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                default\u003d49152,"},{"line_number":86,"context_line":"                help\u003d\u0027Minimal port number for random ports range.\u0027),"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    cfg.IntOpt(\u0027rpc_zmq_max_port\u0027,"},{"line_number":89,"context_line":"               default\u003d65536,"},{"line_number":90,"context_line":"               help\u003d\u0027Maximal port number for random ports range.\u0027),"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_8d21fd4f","line":88,"in_reply_to":"9a8ffd7b_4a4f7bbd","updated":"2015-11-25 11:25:12.000000000","message":"socket max port number is exclusive, so 65536 is the right one, or can be picked. But PortOpt only accepts 1-65535, so if we want to get the benefit for automatic check, then we lose one number 65535.\n\nDecision?","commit_id":"9f132771af5c077fbd71da761f53321d47ac1770"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"5ec3ad83720cefaaffda4e58c435e4a2f2229f9f","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                default\u003d49152,"},{"line_number":86,"context_line":"                help\u003d\u0027Minimal port number for random ports range.\u0027),"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    cfg.IntOpt(\u0027rpc_zmq_max_port\u0027,"},{"line_number":89,"context_line":"               default\u003d65536,"},{"line_number":90,"context_line":"               help\u003d\u0027Maximal port number for random ports range.\u0027),"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_9054ad21","line":88,"in_reply_to":"9a8ffd7b_50596a59","updated":"2015-11-25 13:02:18.000000000","message":"will be done, sir","commit_id":"9f132771af5c077fbd71da761f53321d47ac1770"},{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"fc1f7d225f7686a329739626445bfdbb1b188f92","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                default\u003d49152,"},{"line_number":86,"context_line":"                help\u003d\u0027Minimal port number for random ports range.\u0027),"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    cfg.IntOpt(\u0027rpc_zmq_max_port\u0027,"},{"line_number":89,"context_line":"               default\u003d65536,"},{"line_number":90,"context_line":"               help\u003d\u0027Maximal port number for random ports range.\u0027),"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_50596a59","line":88,"in_reply_to":"9a8ffd7b_8d21fd4f","updated":"2015-11-25 11:53:12.000000000","message":"You are right, lets then leave the IntOpt type here. Could you please add min-max to this option? It is my fault that I didn\u0027t when added this option but lets do it in this change then. Thanks!","commit_id":"9f132771af5c077fbd71da761f53321d47ac1770"}],"oslo_messaging/_drivers/zmq_driver/matchmaker/matchmaker_redis.py":[{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"1b0825cf5e4e1435eb7943ecd9e06ed7e76cbf46","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    cfg.StrOpt(\u0027host\u0027,"},{"line_number":28,"context_line":"               default\u003d\u0027127.0.0.1\u0027,"},{"line_number":29,"context_line":"               help\u003d\u0027Host to locate redis.\u0027),"},{"line_number":30,"context_line":"    cfg.PortOpt(\u0027port\u0027,"},{"line_number":31,"context_line":"                default\u003d6379,"},{"line_number":32,"context_line":"                help\u003d\u0027Use this port to connect to redis host.\u0027),"},{"line_number":33,"context_line":"    cfg.StrOpt(\u0027password\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_37c84574","line":30,"updated":"2015-11-23 15:18:23.000000000","message":"Done in this patch https://review.openstack.org/#/c/248049/","commit_id":"243557035782ddaac65d89cc0f073715e51a3d8d"}]}
