)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"a13da8711b8255c4efb7145c4d6d20009d482348","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sungjin Yook \u003csungyook@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-16 20:33:41 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"should raise expception when rabbit broker has blocked the connection"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For the case of rabbitMQ blocks and raise error, impl_rabbit also need"},{"line_number":10,"context_line":"to raise expception to pass the err to consumer. Otherwise user of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba8a016a_c9ba87e1","line":7,"range":{"start_line":7,"start_character":13,"end_line":7,"end_character":23},"updated":"2015-11-17 16:16:17.000000000","message":"s/expception/exception/","commit_id":"143a6f7a24c80b6bbb2376ff5bec37449454a54c"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"a13da8711b8255c4efb7145c4d6d20009d482348","unresolved":false,"context_lines":[{"line_number":7,"context_line":"should raise expception when rabbit broker has blocked the connection"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For the case of rabbitMQ blocks and raise error, impl_rabbit also need"},{"line_number":10,"context_line":"to raise expception to pass the err to consumer. Otherwise user of"},{"line_number":11,"context_line":"oslo.messaging, i.e barbican, will hang forever for the msg that failed"},{"line_number":12,"context_line":"to deliver. For example, for the case like below,"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba8a016a_c98fe721","line":10,"range":{"start_line":10,"start_character":9,"end_line":10,"end_character":19},"updated":"2015-11-17 16:16:17.000000000","message":"s/expception/exception/","commit_id":"143a6f7a24c80b6bbb2376ff5bec37449454a54c"}],"oslo_messaging/_drivers/impl_rabbit.py":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"4a763c57be9b651bbe98ede0dae03d206f8e2664","unresolved":false,"context_lines":[{"line_number":570,"context_line":"    @staticmethod"},{"line_number":571,"context_line":"    def _on_connection_blocked(reason):"},{"line_number":572,"context_line":"        LOG.error(_LE(\"The broker has blocked the connection: %s\"), reason)"},{"line_number":573,"context_line":"        raise exceptions.MessageDeliveryFailure(reason)"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"    @staticmethod"},{"line_number":576,"context_line":"    def _on_connection_unblocked():"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_668028f8","line":573,"updated":"2015-11-18 15:54:12.000000000","message":"Once the rabbit server issue have been solved the connection will be unblocked, and the message should delivered...","commit_id":"31d3f4fb797191bbb44b94a9121164254a5c0dc1"},{"author":{"_account_id":14700,"name":"Sungjin Yook","email":"sungyook@us.ibm.com","username":"freelinuxer"},"change_message_id":"ca49289f4f00aa3c1baa33902f2ba4ea3e5473d9","unresolved":false,"context_lines":[{"line_number":570,"context_line":"    @staticmethod"},{"line_number":571,"context_line":"    def _on_connection_blocked(reason):"},{"line_number":572,"context_line":"        LOG.error(_LE(\"The broker has blocked the connection: %s\"), reason)"},{"line_number":573,"context_line":"        raise exceptions.MessageDeliveryFailure(reason)"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"    @staticmethod"},{"line_number":576,"context_line":"    def _on_connection_unblocked():"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_0c5e1d12","line":573,"in_reply_to":"ba8a016a_668028f8","updated":"2015-11-18 16:19:48.000000000","message":"barbican will hang waiting for this failed msg. The desired behavior would be fail immediately and let user know about rabbitMQ issue.","commit_id":"31d3f4fb797191bbb44b94a9121164254a5c0dc1"}]}
