)]}'
{"oslo_messaging/_drivers/impl_rabbit.py":[{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"7e0b24d521fa91b690e0ce9e71e35e6b927e4b59","unresolved":false,"context_lines":[{"line_number":85,"context_line":"               help\u003d\u0027How long to wait before considering a reconnect \u0027"},{"line_number":86,"context_line":"                    \u0027attempt to have failed. This value should not be \u0027"},{"line_number":87,"context_line":"                    \u0027longer than rpc_response_timeout.\u0027),"},{"line_number":88,"context_line":"    cfg.Opt(\u0027kombu_failover_strategy\u0027,"},{"line_number":89,"context_line":"            type\u003dtypes.String(choices\u003d(\u0027round-robin\u0027, \u0027shuffle\u0027)),"},{"line_number":90,"context_line":"            default\u003d\u0027round-robin\u0027,"},{"line_number":91,"context_line":"            help\u003d\u0027Determines how the next RabbitMQ node is chosen in case \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_a1cd4167","line":88,"updated":"2015-11-30 07:22:10.000000000","message":"Use cfg.StrOpt( \u0027kombu_failover_strategy\u0027,\n                         choices\u003d(\u0027round-robin\u0027, \u0027shuffle\u0027),\n                          default\u003d\u0027round-robin\u0027,\n                          help\u003d\u0027......\u0027)\n？\nyour way also works well, but exposes some implement details.","commit_id":"e49cba7e7273f1e80f3e0769412e8becb25ca5b6"},{"author":{"_account_id":7109,"name":"Dmitry Mescheryakov (dmitryme)","email":"dmescheryakov@mirantis.com","username":"dmitryme"},"change_message_id":"147e21283708e21f4c96a8b2681ae6026e815bc0","unresolved":false,"context_lines":[{"line_number":85,"context_line":"               help\u003d\u0027How long to wait before considering a reconnect \u0027"},{"line_number":86,"context_line":"                    \u0027attempt to have failed. This value should not be \u0027"},{"line_number":87,"context_line":"                    \u0027longer than rpc_response_timeout.\u0027),"},{"line_number":88,"context_line":"    cfg.Opt(\u0027kombu_failover_strategy\u0027,"},{"line_number":89,"context_line":"            type\u003dtypes.String(choices\u003d(\u0027round-robin\u0027, \u0027shuffle\u0027)),"},{"line_number":90,"context_line":"            default\u003d\u0027round-robin\u0027,"},{"line_number":91,"context_line":"            help\u003d\u0027Determines how the next RabbitMQ node is chosen in case \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_e4d58d1b","line":88,"in_reply_to":"9a8ffd7b_a1cd4167","updated":"2015-11-30 11:22:26.000000000","message":"Agree, the way you have suggested looks simpler. Done.","commit_id":"e49cba7e7273f1e80f3e0769412e8becb25ca5b6"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"df311f1695f6f0af146449698e04d8ed802745da","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                    \u0027longer than rpc_response_timeout.\u0027),"},{"line_number":88,"context_line":"    cfg.Opt(\u0027kombu_failover_strategy\u0027,"},{"line_number":89,"context_line":"            type\u003dtypes.String(choices\u003d(\u0027round-robin\u0027, \u0027shuffle\u0027)),"},{"line_number":90,"context_line":"            default\u003d\u0027round-robin\u0027,"},{"line_number":91,"context_line":"            help\u003d\u0027Determines how the next RabbitMQ node is chosen in case \u0027"},{"line_number":92,"context_line":"                 \u0027the one we are currently connected to is unavailable. \u0027"},{"line_number":93,"context_line":"                 \u0027Takes effect only if more than one RabbitMQ node is \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_aad30c03","line":90,"updated":"2015-11-27 12:37:30.000000000","message":"I guess that is we change this we should keep the same default as before.","commit_id":"e49cba7e7273f1e80f3e0769412e8becb25ca5b6"},{"author":{"_account_id":7109,"name":"Dmitry Mescheryakov (dmitryme)","email":"dmescheryakov@mirantis.com","username":"dmitryme"},"change_message_id":"147e21283708e21f4c96a8b2681ae6026e815bc0","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                    \u0027longer than rpc_response_timeout.\u0027),"},{"line_number":88,"context_line":"    cfg.Opt(\u0027kombu_failover_strategy\u0027,"},{"line_number":89,"context_line":"            type\u003dtypes.String(choices\u003d(\u0027round-robin\u0027, \u0027shuffle\u0027)),"},{"line_number":90,"context_line":"            default\u003d\u0027round-robin\u0027,"},{"line_number":91,"context_line":"            help\u003d\u0027Determines how the next RabbitMQ node is chosen in case \u0027"},{"line_number":92,"context_line":"                 \u0027the one we are currently connected to is unavailable. \u0027"},{"line_number":93,"context_line":"                 \u0027Takes effect only if more than one RabbitMQ node is \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_84ccc189","line":90,"in_reply_to":"9a8ffd7b_0100cd64","updated":"2015-11-30 11:22:26.000000000","message":"Added the flag and description. Let me know if I missed something.","commit_id":"e49cba7e7273f1e80f3e0769412e8becb25ca5b6"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"7e0b24d521fa91b690e0ce9e71e35e6b927e4b59","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                    \u0027longer than rpc_response_timeout.\u0027),"},{"line_number":88,"context_line":"    cfg.Opt(\u0027kombu_failover_strategy\u0027,"},{"line_number":89,"context_line":"            type\u003dtypes.String(choices\u003d(\u0027round-robin\u0027, \u0027shuffle\u0027)),"},{"line_number":90,"context_line":"            default\u003d\u0027round-robin\u0027,"},{"line_number":91,"context_line":"            help\u003d\u0027Determines how the next RabbitMQ node is chosen in case \u0027"},{"line_number":92,"context_line":"                 \u0027the one we are currently connected to is unavailable. \u0027"},{"line_number":93,"context_line":"                 \u0027Takes effect only if more than one RabbitMQ node is \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_0100cd64","line":90,"in_reply_to":"9a8ffd7b_57e6c4e8","updated":"2015-11-30 07:22:10.000000000","message":"At least need DocImpact flag or something in commit message , and describe the new config option and explain why we choose \u0027round-robin\u0027 for deployer.","commit_id":"e49cba7e7273f1e80f3e0769412e8becb25ca5b6"},{"author":{"_account_id":7109,"name":"Dmitry Mescheryakov (dmitryme)","email":"dmescheryakov@mirantis.com","username":"dmitryme"},"change_message_id":"7a973a3573344664c928282f53e1f152c4869a74","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                    \u0027longer than rpc_response_timeout.\u0027),"},{"line_number":88,"context_line":"    cfg.Opt(\u0027kombu_failover_strategy\u0027,"},{"line_number":89,"context_line":"            type\u003dtypes.String(choices\u003d(\u0027round-robin\u0027, \u0027shuffle\u0027)),"},{"line_number":90,"context_line":"            default\u003d\u0027round-robin\u0027,"},{"line_number":91,"context_line":"            help\u003d\u0027Determines how the next RabbitMQ node is chosen in case \u0027"},{"line_number":92,"context_line":"                 \u0027the one we are currently connected to is unavailable. \u0027"},{"line_number":93,"context_line":"                 \u0027Takes effect only if more than one RabbitMQ node is \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_bb67dce7","line":90,"in_reply_to":"9a8ffd7b_aad30c03","updated":"2015-11-27 13:16:05.000000000","message":"IMHO we should provide users with best available option by default. The change from \u0027shuffle\u0027 to \u0027round-robin\u0027 indeed changes the behaviour between releases. But it seems like round-robin provides only advantage over shuffle (best reconnection time possible) and no disadvantages.","commit_id":"e49cba7e7273f1e80f3e0769412e8becb25ca5b6"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"2cab549a5b1221080d9e461e039c6ac9581a6583","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                    \u0027longer than rpc_response_timeout.\u0027),"},{"line_number":88,"context_line":"    cfg.Opt(\u0027kombu_failover_strategy\u0027,"},{"line_number":89,"context_line":"            type\u003dtypes.String(choices\u003d(\u0027round-robin\u0027, \u0027shuffle\u0027)),"},{"line_number":90,"context_line":"            default\u003d\u0027round-robin\u0027,"},{"line_number":91,"context_line":"            help\u003d\u0027Determines how the next RabbitMQ node is chosen in case \u0027"},{"line_number":92,"context_line":"                 \u0027the one we are currently connected to is unavailable. \u0027"},{"line_number":93,"context_line":"                 \u0027Takes effect only if more than one RabbitMQ node is \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_57e6c4e8","line":90,"in_reply_to":"9a8ffd7b_bb67dce7","updated":"2015-11-27 13:38:08.000000000","message":"Agreed, let\u0027s see what other think.","commit_id":"e49cba7e7273f1e80f3e0769412e8becb25ca5b6"}]}