)]}'
{"oslo_messaging/tests/drivers/test_impl_rabbit.py":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"88f78ef8ff65055b9d85820d7681c54f73b71b5b","unresolved":false,"context_lines":[{"line_number":469,"context_line":"            # next immediately fail"},{"line_number":470,"context_line":"            dt \u003d time.time() - start"},{"line_number":471,"context_line":"            timeout \u003d self.conf.oslo_messaging_rabbit.kombu_missing_consumer_retry_timeout"},{"line_number":472,"context_line":"            self.assertTrue(timeout \u003c\u003d dt, dt)"},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"        self.assertEqual(len(senders), len(replies))"},{"line_number":475,"context_line":"        for i, reply in enumerate(replies):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_6b4e20c3","line":472,"updated":"2016-01-19 06:28:31.000000000","message":"If we remove that we can remove the assert complete, the test here is to check if the timeout is close to 0.5 or to 0.01.\n\nPerhaps we can just put \u0027self.assertTrue(dt \u003c 0.5)\u0027 because timeout is always 0.01 when reply_failure_404 is True. So the GIL can block during 0.499 instead of the current 0.110, WDYT ?","commit_id":"7888a967d21c0c6b655cff7fce817578f5c72557"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"a75740ca4bfb0b741514f5c83749926d91193fce","unresolved":false,"context_lines":[{"line_number":469,"context_line":"            # next immediately fail"},{"line_number":470,"context_line":"            dt \u003d time.time() - start"},{"line_number":471,"context_line":"            timeout \u003d self.conf.oslo_messaging_rabbit.kombu_missing_consumer_retry_timeout"},{"line_number":472,"context_line":"            self.assertTrue(timeout \u003c\u003d dt, dt)"},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"        self.assertEqual(len(senders), len(replies))"},{"line_number":475,"context_line":"        for i, reply in enumerate(replies):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_28d642f1","line":472,"in_reply_to":"ba63e191_6b4e20c3","updated":"2016-01-25 06:18:15.000000000","message":"I agree we remove the assert completely in case  reply_failure_404 \u003d True","commit_id":"7888a967d21c0c6b655cff7fce817578f5c72557"}]}