)]}'
{"doc/source/pika_driver.rst":[{"author":{"_account_id":7109,"name":"Dmitry Mescheryakov (dmitryme)","email":"dmescheryakov@mirantis.com","username":"dmitryme"},"change_message_id":"3aadb22187299b438521e0307188ff2b065f3f4e","unresolved":false,"context_lines":[{"line_number":37,"context_line":"`pika://user:pass@host1:port[,hostN:portN]`"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        [DEFAULT]"},{"line_number":40,"context_line":"        transport_url \u003d pika://guest:guest@localhost:"},{"line_number":41,"context_line":"        rpc_zmq_host \u003d {hostname}"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a68dd71_ade53b09","line":40,"updated":"2016-01-25 21:00:19.000000000","message":"port is missing after colon","commit_id":"2ffb9fd814a6de6543d8439e4c0665c6ce696071"},{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"72402ac79213d79104a41c1303ff5d08176242ae","unresolved":false,"context_lines":[{"line_number":37,"context_line":"`pika://user:pass@host1:port[,hostN:portN]`"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        [DEFAULT]"},{"line_number":40,"context_line":"        transport_url \u003d pika://guest:guest@localhost:"},{"line_number":41,"context_line":"        rpc_zmq_host \u003d {hostname}"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a68dd71_bc15554a","line":40,"in_reply_to":"9a68dd71_ade53b09","updated":"2016-01-26 10:26:04.000000000","message":"Done","commit_id":"2ffb9fd814a6de6543d8439e4c0665c6ce696071"},{"author":{"_account_id":7109,"name":"Dmitry Mescheryakov (dmitryme)","email":"dmescheryakov@mirantis.com","username":"dmitryme"},"change_message_id":"3aadb22187299b438521e0307188ff2b065f3f4e","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        [DEFAULT]"},{"line_number":40,"context_line":"        transport_url \u003d pika://guest:guest@localhost:"},{"line_number":41,"context_line":"        rpc_zmq_host \u003d {hostname}"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Connection options (optional)"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a68dd71_edb573ec","line":41,"updated":"2016-01-25 21:00:19.000000000","message":"errr, zmq?","commit_id":"2ffb9fd814a6de6543d8439e4c0665c6ce696071"},{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"72402ac79213d79104a41c1303ff5d08176242ae","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        [DEFAULT]"},{"line_number":40,"context_line":"        transport_url \u003d pika://guest:guest@localhost:"},{"line_number":41,"context_line":"        rpc_zmq_host \u003d {hostname}"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Connection options (optional)"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a68dd71_7c083d2e","line":41,"in_reply_to":"9a68dd71_edb573ec","updated":"2016-01-26 10:26:04.000000000","message":"Done","commit_id":"2ffb9fd814a6de6543d8439e4c0665c6ce696071"},{"author":{"_account_id":7109,"name":"Dmitry Mescheryakov (dmitryme)","email":"dmescheryakov@mirantis.com","username":"dmitryme"},"change_message_id":"3aadb22187299b438521e0307188ff2b065f3f4e","unresolved":false,"context_lines":[{"line_number":95,"context_line":"#. rpc_queue_expiration (default\u003d60): Time to live for rpc queues without"},{"line_number":96,"context_line":"   consumers in seconds,"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"#. default_rpc_exchange (default\u003d\"${control_exchange}_rpc\"): Exchange name for"},{"line_number":99,"context_line":"   sending RPC messages,"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"#. rpc_reply_exchange\u0027, default\u003d(\"${control_exchange}_rpc_reply\"): Exchange"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a68dd71_ed36d34f","line":98,"updated":"2016-01-25 21:00:19.000000000","message":"What is ${control_exchange}?","commit_id":"2ffb9fd814a6de6543d8439e4c0665c6ce696071"},{"author":{"_account_id":7109,"name":"Dmitry Mescheryakov (dmitryme)","email":"dmescheryakov@mirantis.com","username":"dmitryme"},"change_message_id":"0a552091fc76ed7c5c3d26f60ff44541593c8507","unresolved":false,"context_lines":[{"line_number":95,"context_line":"#. rpc_queue_expiration (default\u003d60): Time to live for rpc queues without"},{"line_number":96,"context_line":"   consumers in seconds,"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"#. default_rpc_exchange (default\u003d\"${control_exchange}_rpc\"): Exchange name for"},{"line_number":99,"context_line":"   sending RPC messages,"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"#. rpc_reply_exchange\u0027, default\u003d(\"${control_exchange}_rpc_reply\"): Exchange"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a68dd71_a822e5ff","line":98,"in_reply_to":"9a68dd71_b056d9cc","updated":"2016-01-26 13:50:25.000000000","message":"It would be nice to have it listed here then, or how users will know about it?","commit_id":"2ffb9fd814a6de6543d8439e4c0665c6ce696071"},{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"72402ac79213d79104a41c1303ff5d08176242ae","unresolved":false,"context_lines":[{"line_number":95,"context_line":"#. rpc_queue_expiration (default\u003d60): Time to live for rpc queues without"},{"line_number":96,"context_line":"   consumers in seconds,"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"#. default_rpc_exchange (default\u003d\"${control_exchange}_rpc\"): Exchange name for"},{"line_number":99,"context_line":"   sending RPC messages,"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"#. rpc_reply_exchange\u0027, default\u003d(\"${control_exchange}_rpc_reply\"): Exchange"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a68dd71_b056d9cc","line":98,"in_reply_to":"9a68dd71_ed36d34f","updated":"2016-01-26 10:26:04.000000000","message":"control_exchange is another option currently used for default exchage name. It is \"openstack\" by default. pika uses different excahges for different message types and add postfix to value of control_exchange property","commit_id":"2ffb9fd814a6de6543d8439e4c0665c6ce696071"},{"author":{"_account_id":7109,"name":"Dmitry Mescheryakov (dmitryme)","email":"dmescheryakov@mirantis.com","username":"dmitryme"},"change_message_id":"3aadb22187299b438521e0307188ff2b065f3f4e","unresolved":false,"context_lines":[{"line_number":117,"context_line":"#. default_rpc_retry_attempts (default\u003d-1): Reconnecting retry count in case of"},{"line_number":118,"context_line":"   connectivity problem during sending RPC message, -1 means infinite retry. If"},{"line_number":119,"context_line":"   actual retry attempts in not 0 the rpc request could be processed more then"},{"line_number":120,"context_line":"   one time,"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"#. rpc_retry_delay (default\u003d0.25): Reconnecting retry delay in case of"},{"line_number":123,"context_line":"   connectivity problem during sending RPC message"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a68dd71_4d927ff7","line":120,"updated":"2016-01-25 21:00:19.000000000","message":"Dot is needed here instead of comma","commit_id":"2ffb9fd814a6de6543d8439e4c0665c6ce696071"},{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"72402ac79213d79104a41c1303ff5d08176242ae","unresolved":false,"context_lines":[{"line_number":117,"context_line":"#. default_rpc_retry_attempts (default\u003d-1): Reconnecting retry count in case of"},{"line_number":118,"context_line":"   connectivity problem during sending RPC message, -1 means infinite retry. If"},{"line_number":119,"context_line":"   actual retry attempts in not 0 the rpc request could be processed more then"},{"line_number":120,"context_line":"   one time,"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"#. rpc_retry_delay (default\u003d0.25): Reconnecting retry delay in case of"},{"line_number":123,"context_line":"   connectivity problem during sending RPC message"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a68dd71_701f010a","line":120,"in_reply_to":"9a68dd71_4d927ff7","updated":"2016-01-26 10:26:04.000000000","message":"Why? it is a list, as far as I know dot should be at the end of the list, list items should be separated by \",\" or \";\". Am I wrong?","commit_id":"2ffb9fd814a6de6543d8439e4c0665c6ce696071"},{"author":{"_account_id":7109,"name":"Dmitry Mescheryakov (dmitryme)","email":"dmescheryakov@mirantis.com","username":"dmitryme"},"change_message_id":"0a552091fc76ed7c5c3d26f60ff44541593c8507","unresolved":false,"context_lines":[{"line_number":117,"context_line":"#. default_rpc_retry_attempts (default\u003d-1): Reconnecting retry count in case of"},{"line_number":118,"context_line":"   connectivity problem during sending RPC message, -1 means infinite retry. If"},{"line_number":119,"context_line":"   actual retry attempts in not 0 the rpc request could be processed more then"},{"line_number":120,"context_line":"   one time,"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"#. rpc_retry_delay (default\u003d0.25): Reconnecting retry delay in case of"},{"line_number":123,"context_line":"   connectivity problem during sending RPC message"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a68dd71_2864b547","line":120,"in_reply_to":"9a68dd71_701f010a","updated":"2016-01-26 13:50:25.000000000","message":"You are right. I didn\u0027t even notice that other items here are ended with the comma :-)","commit_id":"2ffb9fd814a6de6543d8439e4c0665c6ce696071"},{"author":{"_account_id":7109,"name":"Dmitry Mescheryakov (dmitryme)","email":"dmescheryakov@mirantis.com","username":"dmitryme"},"change_message_id":"3aadb22187299b438521e0307188ff2b065f3f4e","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"#. default_notification_retry_attempts (default\u003d-1): Reconnecting retry count"},{"line_number":139,"context_line":"    in case of connectivity problem during sending notification, -1 means"},{"line_number":140,"context_line":"    infinite retry,"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"#. notification_retry_delay (default\u003d0.25): Reconnecting retry delay in case of"},{"line_number":143,"context_line":"   connectivity problem during sending notification message"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a68dd71_302c4098","line":140,"updated":"2016-01-25 21:00:19.000000000","message":"I think the same warning as for RPC applies here: \"If actual retry attempts in not 0 the rpc request could be processed more then one time\"\n\nI.e. it is my understanding that duplicated notifications will be processed and not discarded.","commit_id":"2ffb9fd814a6de6543d8439e4c0665c6ce696071"},{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"72402ac79213d79104a41c1303ff5d08176242ae","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"#. default_notification_retry_attempts (default\u003d-1): Reconnecting retry count"},{"line_number":139,"context_line":"    in case of connectivity problem during sending notification, -1 means"},{"line_number":140,"context_line":"    infinite retry,"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"#. notification_retry_delay (default\u003d0.25): Reconnecting retry delay in case of"},{"line_number":143,"context_line":"   connectivity problem during sending notification message"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a68dd71_10e1e5d0","line":140,"in_reply_to":"9a68dd71_302c4098","updated":"2016-01-26 10:26:04.000000000","message":"Yes, Handling duplicated notifications is responsibility of notification listener. The main requirements for notification - don\u0027t lose anything. Duplication is ok","commit_id":"2ffb9fd814a6de6543d8439e4c0665c6ce696071"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"6b83c5bee5844cc8f72b23801fe3888543218d0e","unresolved":false,"context_lines":[{"line_number":148,"context_line":"Pika driver is supported by DevStack. To enable it you should edit"},{"line_number":149,"context_line":"local.conf [localrc] section and add next there:"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    enable_plugin pika https://github.com/openstack/devstack-plugin-pika.git"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a68dd71_551bf080","line":151,"updated":"2016-01-25 16:53:08.000000000","message":"Let\u0027s use the openstack url instead of the github one please\n\nhttps://git.openstack.org/openstack/devstack-plugin-zmq","commit_id":"2ffb9fd814a6de6543d8439e4c0665c6ce696071"}],"oslo_messaging/_drivers/pika_driver/pika_engine.py":[{"author":{"_account_id":7109,"name":"Dmitry Mescheryakov (dmitryme)","email":"dmescheryakov@mirantis.com","username":"dmitryme"},"change_message_id":"3aadb22187299b438521e0307188ff2b065f3f4e","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            conf.oslo_messaging_pika.rpc_listener_prefetch_count"},{"line_number":120,"context_line":"        )"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        if self.default_rpc_retry_attempts is None:"},{"line_number":123,"context_line":"            raise ValueError(\"default_rpc_retry_attempts should be an integer\")"},{"line_number":124,"context_line":"        self.rpc_retry_delay \u003d ("},{"line_number":125,"context_line":"            conf.oslo_messaging_pika.rpc_retry_delay"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_50b8d429","line":122,"updated":"2016-01-25 21:00:19.000000000","message":"self.default_rpc_retry_attempts is not defined at that point, isn\u0027t it?\n\nOr did you mean conf.oslo_messaging_pika.rpc_retry_delay ? If yes, it should not be checked for being None, as it is FloatOpt","commit_id":"2ffb9fd814a6de6543d8439e4c0665c6ce696071"},{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"72402ac79213d79104a41c1303ff5d08176242ae","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            conf.oslo_messaging_pika.rpc_listener_prefetch_count"},{"line_number":120,"context_line":"        )"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        if self.default_rpc_retry_attempts is None:"},{"line_number":123,"context_line":"            raise ValueError(\"default_rpc_retry_attempts should be an integer\")"},{"line_number":124,"context_line":"        self.rpc_retry_delay \u003d ("},{"line_number":125,"context_line":"            conf.oslo_messaging_pika.rpc_retry_delay"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_10c005e0","line":122,"in_reply_to":"9a68dd71_50b8d429","updated":"2016-01-26 10:26:04.000000000","message":"Done","commit_id":"2ffb9fd814a6de6543d8439e4c0665c6ce696071"},{"author":{"_account_id":7109,"name":"Dmitry Mescheryakov (dmitryme)","email":"dmescheryakov@mirantis.com","username":"dmitryme"},"change_message_id":"3aadb22187299b438521e0307188ff2b065f3f4e","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        self.rpc_retry_delay \u003d ("},{"line_number":125,"context_line":"            conf.oslo_messaging_pika.rpc_retry_delay"},{"line_number":126,"context_line":"        )"},{"line_number":127,"context_line":"        if (self.rpc_retry_delay is None or"},{"line_number":128,"context_line":"                self.rpc_retry_delay \u003c 0):"},{"line_number":129,"context_line":"            raise ValueError(\"rpc_retry_delay should be non-negative integer\")"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_10bd7cd7","line":127,"updated":"2016-01-25 21:00:19.000000000","message":"The rpc_retry_delay is a FloatOpt. Hence it is already validated that it is not None.\n\nAlso, I would move validation that the value is not negative to the Opt as well. Though that will require a little code, since there is no such check in FloatOpt.","commit_id":"2ffb9fd814a6de6543d8439e4c0665c6ce696071"},{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"72402ac79213d79104a41c1303ff5d08176242ae","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        self.rpc_retry_delay \u003d ("},{"line_number":125,"context_line":"            conf.oslo_messaging_pika.rpc_retry_delay"},{"line_number":126,"context_line":"        )"},{"line_number":127,"context_line":"        if (self.rpc_retry_delay is None or"},{"line_number":128,"context_line":"                self.rpc_retry_delay \u003c 0):"},{"line_number":129,"context_line":"            raise ValueError(\"rpc_retry_delay should be non-negative integer\")"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_66ae6be9","line":127,"in_reply_to":"9a68dd71_10bd7cd7","updated":"2016-01-26 10:26:04.000000000","message":"Done","commit_id":"2ffb9fd814a6de6543d8439e4c0665c6ce696071"}]}