)]}'
{"oslo_messaging/_drivers/impl_zmq.py":[{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"4b3173553c78bb38a9278ba43de251a601a5f4c4","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        self.matchmaker \u003d driver.DriverManager("},{"line_number":166,"context_line":"            \u0027oslo.messaging.zmq.matchmaker\u0027,"},{"line_number":167,"context_line":"            self.conf.rpc_zmq_matchmaker,"},{"line_number":168,"context_line":"        ).driver(self.conf, url)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        self.client \u003d LazyDriverItem("}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_e1f8dd7e","line":167,"range":{"start_line":167,"start_character":22,"end_line":167,"end_character":40},"updated":"2016-02-03 17:06:34.000000000","message":"I would be nice to add self.conf.rpc_zmq_matchmaker value to url, probably like zmq+redis://....","commit_id":"6e248ab60810485ac4990becc114d8c3dbb7c28b"},{"author":{"_account_id":7534,"name":"Yulia Portnova","email":"yportnova@mirantis.com","username":"yportnova"},"change_message_id":"c40d3fb53d308aa4286440ee0046551c0f3c8787","unresolved":false,"context_lines":[{"line_number":188,"context_line":"    def get_matchmaker_backend(self, url):"},{"line_number":189,"context_line":"        if not url or url.transport \u003d\u003d \u0027zmq\u0027:"},{"line_number":190,"context_line":"            return self.conf.rpc_zmq_matchmaker"},{"line_number":191,"context_line":"        matchmaker_backend \u003d None"},{"line_number":192,"context_line":"        zmq_transport \u003d \u0027zmq\u0027"},{"line_number":193,"context_line":"        if \u0027+\u0027 in url.transport:"},{"line_number":194,"context_line":"            zmq_transport, matchmaker_backend \u003d url.transport.split(\u0027+\u0027)"},{"line_number":195,"context_line":"        if matchmaker_backend is None:"},{"line_number":196,"context_line":"            matchmaker_backend \u003d _MATCHMAKER_DEFAULT"},{"line_number":197,"context_line":"        assert matchmaker_backend in _MATCHMAKER_BACKENDS, \"Invalid backend!\""},{"line_number":198,"context_line":"        assert zmq_transport \u003d\u003d \u0027zmq\u0027, \"Needs to be zmq for this transport!\""}],"source_content_type":"text/x-python","patch_set":6,"id":"dae33548_e5a28098","line":195,"range":{"start_line":191,"start_character":0,"end_line":195,"end_character":1},"updated":"2016-02-17 10:21:47.000000000","message":"This can be replaced with \nzmq_transport, _separator, matchmaker_backend \u003d url.transport.partition(\u0027+\u0027)","commit_id":"83a8ab3856e12517f01973b58cd5dcfd04d840be"},{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"0d2d6823be0aa95fb92f43200931bb895b6c931f","unresolved":false,"context_lines":[{"line_number":188,"context_line":"    def get_matchmaker_backend(self, url):"},{"line_number":189,"context_line":"        if not url or url.transport \u003d\u003d \u0027zmq\u0027:"},{"line_number":190,"context_line":"            return self.conf.rpc_zmq_matchmaker"},{"line_number":191,"context_line":"        matchmaker_backend \u003d None"},{"line_number":192,"context_line":"        zmq_transport \u003d \u0027zmq\u0027"},{"line_number":193,"context_line":"        if \u0027+\u0027 in url.transport:"},{"line_number":194,"context_line":"            zmq_transport, matchmaker_backend \u003d url.transport.split(\u0027+\u0027)"},{"line_number":195,"context_line":"        if matchmaker_backend is None:"},{"line_number":196,"context_line":"            matchmaker_backend \u003d _MATCHMAKER_DEFAULT"},{"line_number":197,"context_line":"        assert matchmaker_backend in _MATCHMAKER_BACKENDS, \"Invalid backend!\""},{"line_number":198,"context_line":"        assert zmq_transport \u003d\u003d \u0027zmq\u0027, \"Needs to be zmq for this transport!\""}],"source_content_type":"text/x-python","patch_set":6,"id":"dae33548_882d8900","line":195,"range":{"start_line":191,"start_character":0,"end_line":195,"end_character":1},"in_reply_to":"dae33548_e5a28098","updated":"2016-02-17 10:38:29.000000000","message":"Done","commit_id":"83a8ab3856e12517f01973b58cd5dcfd04d840be"},{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"74c5cc95e37d57a45a3142b78f0854526c50a089","unresolved":false,"context_lines":[{"line_number":194,"context_line":"            zmq_transport, matchmaker_backend \u003d url.transport.split(\u0027+\u0027)"},{"line_number":195,"context_line":"        if matchmaker_backend is None:"},{"line_number":196,"context_line":"            matchmaker_backend \u003d _MATCHMAKER_DEFAULT"},{"line_number":197,"context_line":"        assert matchmaker_backend in _MATCHMAKER_BACKENDS, \"Invalid backend!\""},{"line_number":198,"context_line":"        assert zmq_transport \u003d\u003d \u0027zmq\u0027, \"Needs to be zmq for this transport!\""},{"line_number":199,"context_line":"        return matchmaker_backend"},{"line_number":200,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"dae33548_08617905","line":197,"range":{"start_line":197,"start_character":8,"end_line":197,"end_character":14},"updated":"2016-02-17 10:45:44.000000000","message":"I would prefer to avoid asserts here.","commit_id":"83a8ab3856e12517f01973b58cd5dcfd04d840be"},{"author":{"_account_id":7534,"name":"Yulia Portnova","email":"yportnova@mirantis.com","username":"yportnova"},"change_message_id":"15c2798cac81a69e6df4fa7e4fdf800d4a6ca8c3","unresolved":false,"context_lines":[{"line_number":186,"context_line":"                                        allowed_remote_exmods)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def get_matchmaker_backend(self, url):"},{"line_number":189,"context_line":"        if not url or url.transport \u003d\u003d \u0027zmq\u0027:"},{"line_number":190,"context_line":"            return self.conf.rpc_zmq_matchmaker"},{"line_number":191,"context_line":"        zmq_transport, p, matchmaker_backend \u003d url.transport.partition(\u0027+\u0027)"},{"line_number":192,"context_line":"        assert zmq_transport \u003d\u003d \u0027zmq\u0027, \"Needs to be zmq for this transport!\""},{"line_number":193,"context_line":"        if matchmaker_backend not in _MATCHMAKER_BACKENDS:"}],"source_content_type":"text/x-python","patch_set":7,"id":"dae33548_b3e602ae","line":190,"range":{"start_line":189,"start_character":0,"end_line":190,"end_character":47},"updated":"2016-02-17 10:58:20.000000000","message":"Do we accept None as url here?\nIf not - we can remove these teo lines as \u0027zmq\u0027 transport is handled in lines 193-194","commit_id":"7fd11c8eb1a7f1ded50b1749701806b01533a595"},{"author":{"_account_id":7534,"name":"Yulia Portnova","email":"yportnova@mirantis.com","username":"yportnova"},"change_message_id":"15c2798cac81a69e6df4fa7e4fdf800d4a6ca8c3","unresolved":false,"context_lines":[{"line_number":190,"context_line":"            return self.conf.rpc_zmq_matchmaker"},{"line_number":191,"context_line":"        zmq_transport, p, matchmaker_backend \u003d url.transport.partition(\u0027+\u0027)"},{"line_number":192,"context_line":"        assert zmq_transport \u003d\u003d \u0027zmq\u0027, \"Needs to be zmq for this transport!\""},{"line_number":193,"context_line":"        if matchmaker_backend not in _MATCHMAKER_BACKENDS:"},{"line_number":194,"context_line":"            matchmaker_backend \u003d _MATCHMAKER_DEFAULT"},{"line_number":195,"context_line":"        return matchmaker_backend"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    def send(self, target, ctxt, message, wait_for_reply\u003dNone, timeout\u003dNone,"}],"source_content_type":"text/x-python","patch_set":7,"id":"dae33548_13452eb2","line":194,"range":{"start_line":193,"start_character":0,"end_line":194,"end_character":52},"updated":"2016-02-17 10:58:20.000000000","message":"Here should be some warning","commit_id":"7fd11c8eb1a7f1ded50b1749701806b01533a595"}],"oslo_messaging/_drivers/zmq_driver/matchmaker/base.py":[{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"60dc5eb73889344305d4d2ba2d1b55062a01cc01","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    def __init__(self, conf, *args, **kwargs):"},{"line_number":26,"context_line":"        super(MatchMakerBase, self).__init__()"},{"line_number":27,"context_line":"        self.conf \u003d conf"},{"line_number":28,"context_line":"        self.url \u003d kwargs[\"url\"] if \"url\" in kwargs else None"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @abc.abstractmethod"},{"line_number":31,"context_line":"    def register_publisher(self, hostname):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_19064286","line":28,"range":{"start_line":28,"start_character":57,"end_line":28,"end_character":61},"updated":"2016-02-01 06:07:47.000000000","message":"just use:\n  self.url \u003d kwargs.get(\u0027url\u0027)\n\n?","commit_id":"9f0cea251755f20a08c7949600e17e61ceca0fc9"}],"oslo_messaging/_drivers/zmq_driver/matchmaker/matchmaker_redis.py":[{"author":{"_account_id":7534,"name":"Yulia Portnova","email":"yportnova@mirantis.com","username":"yportnova"},"change_message_id":"15c2798cac81a69e6df4fa7e4fdf800d4a6ca8c3","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        super(RedisMatchMaker, self).__init__(conf, *args, **kwargs)"},{"line_number":90,"context_line":"        self.conf.register_opts(matchmaker_redis_opts, \"matchmaker_redis\")"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        self.sentinel_hosts \u003d []"},{"line_number":93,"context_line":"        self.standalone_redis \u003d {}"},{"line_number":94,"context_line":"        if self.url and self.url.hosts:"},{"line_number":95,"context_line":"            if len(self.url.hosts) \u003e 1:"}],"source_content_type":"text/x-python","patch_set":7,"id":"dae33548_93381e3f","line":92,"range":{"start_line":92,"start_character":8,"end_line":92,"end_character":32},"updated":"2016-02-17 10:58:20.000000000","message":"list comprehension can be used","commit_id":"7fd11c8eb1a7f1ded50b1749701806b01533a595"}]}