)]}'
{"oslo_messaging/_drivers/zmq_driver/client/publishers/dealer/zmq_dealer_call_publisher.py":[{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"2274dfe96f8c8ed71235f4b6ad77ed05bd54d1b6","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        retry_dec \u003d retrying.retry("},{"line_number":118,"context_line":"            wait_fixed\u003d1000,"},{"line_number":119,"context_line":"            stop_max_delay\u003dself.conf.rpc_response_timeout,"},{"line_number":120,"context_line":"            retry_on_result\u003dretry_no_ack)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        @retry_dec"}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_e80f55df","line":119,"range":{"start_line":119,"start_character":37,"end_line":119,"end_character":57},"updated":"2016-02-20 09:45:18.000000000","message":"This rpc_response_timeout is just for the timeout of a RPC call, it might not be so appropriate here.\nI prefer to add a new option and use stop_max_attempt_number instead of stop_max_delay, It would be more direct if we use stop_max_attempt_number.","commit_id":"b125c1a4c14a201f7194eef87b2c44b005ff2136"}],"oslo_messaging/_drivers/zmq_driver/server/consumers/zmq_router_consumer.py":[{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"2274dfe96f8c8ed71235f4b6ad77ed05bd54d1b6","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                return zmq_incoming_message.ZmqIncomingRequest("},{"line_number":94,"context_line":"                    self.server, socket, reply_id, request, self.poller)"},{"line_number":95,"context_line":"            elif request.msg_type in zmq_names.NON_BLOCKING_TYPES:"},{"line_number":96,"context_line":"                return RouterIncomingMessage("},{"line_number":97,"context_line":"                    self.server, request.context, request.message, socket,"},{"line_number":98,"context_line":"                    reply_id, request.message_id, self.poller)"},{"line_number":99,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_35c23134","line":96,"range":{"start_line":96,"start_character":23,"end_line":96,"end_character":44},"updated":"2016-02-20 09:45:18.000000000","message":"Prefer to send the ack(Line 87-91) in RouterIncomingMessage.acknowledge() method for clearer code, since acknowledge() would be called by the framework[1].\n\n[1]:https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/rpc/dispatcher.py#L131","commit_id":"b125c1a4c14a201f7194eef87b2c44b005ff2136"},{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"2274dfe96f8c8ed71235f4b6ad77ed05bd54d1b6","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            else:"},{"line_number":131,"context_line":"                self.acknowledged[request.message_id] \u003d time.time()"},{"line_number":132,"context_line":"        self._send_ack(request, reply_id, socket)"},{"line_number":133,"context_line":"        return False"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def _cleanup_acks(self):"},{"line_number":136,"context_line":"        erase_timeout \u003d self.conf.rpc_response_timeout"}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_484c81c7","line":133,"range":{"start_line":133,"start_character":8,"end_line":133,"end_character":20},"updated":"2016-02-20 09:45:18.000000000","message":"Not sure what it means at first sight. It might be more clear: return true if successfully sending the ACK else false(Does the false mean that it already sent one ACK?).","commit_id":"b125c1a4c14a201f7194eef87b2c44b005ff2136"}]}