)]}'
{"oslo_messaging/_drivers/amqpdriver.py":[{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"2eb02920108006aba3d016f4f191fc255e482df4","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def __init__(self, listener, ctxt, message, unique_id, msg_id, reply_q,"},{"line_number":41,"context_line":"                 obsolete_reply_queues):"},{"line_number":42,"context_line":"        super(AMQPIncomingMessage, self).__init__(ctxt, dict(message))"},{"line_number":43,"context_line":"        self.listener \u003d listener"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        self.unique_id \u003d unique_id"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_a88753d6","line":42,"updated":"2016-02-02 23:57:47.000000000","message":"Just out of curiosity by is this dict(message) needed, any idea why it copies the message dictionary, is that really needed? It just stands out here....","commit_id":"e578a6ee37b93f83566f5aecaf9f733f9ca3acc2"},{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"7f1adc76c0c926dedd2c6b612b6873ba5c316a3e","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def __init__(self, listener, ctxt, message, unique_id, msg_id, reply_q,"},{"line_number":41,"context_line":"                 obsolete_reply_queues):"},{"line_number":42,"context_line":"        super(AMQPIncomingMessage, self).__init__(ctxt, dict(message))"},{"line_number":43,"context_line":"        self.listener \u003d listener"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        self.unique_id \u003d unique_id"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_cb6f0e91","line":42,"in_reply_to":"5a5ae5dd_a88753d6","updated":"2016-02-03 12:37:38.000000000","message":"As far as I understood It is not needed in general, but base.RpcIncomingMessage.__init__ method expects dict, somehow amqp driver uses special class for message and first cover to it from dict and here convert back to dict. I can change it but is not goal of this patch","commit_id":"e578a6ee37b93f83566f5aecaf9f733f9ca3acc2"}],"oslo_messaging/_drivers/base.py":[{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"ae259c7ab9b580f1ee5f54018d4f06aeddf056b8","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":86,"context_line":"class Listener(object):"},{"line_number":87,"context_line":"    def __init__(self, prefetch_size):"},{"line_number":88,"context_line":"        self.prefetch_size \u003d prefetch_size"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_3da5c303","line":87,"updated":"2016-02-03 14:43:06.000000000","message":"Lets put the default prefetch value here so drivers wouldn\u0027t be forced to pass numbers if they don\u0027t support prefetching.","commit_id":"e578a6ee37b93f83566f5aecaf9f733f9ca3acc2"}],"oslo_messaging/_drivers/zmq_driver/server/consumers/zmq_pull_consumer.py":[{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"ae259c7ab9b580f1ee5f54018d4f06aeddf056b8","unresolved":false,"context_lines":[{"line_number":26,"context_line":"zmq \u003d zmq_async.import_zmq()"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class PullIncomingMessage(base.RpcIncomingMessage):"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def __init__(self, context, message):"},{"line_number":32,"context_line":"        super(PullIncomingMessage, self).__init__(context, message)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_bd1d3368","line":29,"updated":"2016-02-03 14:43:06.000000000","message":"base.IncomingMessage is enough here and reply method may be removed (see the doc-string)","commit_id":"e578a6ee37b93f83566f5aecaf9f733f9ca3acc2"}],"oslo_messaging/_drivers/zmq_driver/server/consumers/zmq_router_consumer.py":[{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"ae259c7ab9b580f1ee5f54018d4f06aeddf056b8","unresolved":false,"context_lines":[{"line_number":30,"context_line":"zmq \u003d zmq_async.import_zmq()"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class RouterIncomingMessage(base.RpcIncomingMessage):"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def __init__(self, context, message, socket, reply_id, msg_id,"},{"line_number":36,"context_line":"                 poller):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_d2033e0e","line":33,"updated":"2016-02-03 14:43:06.000000000","message":"base.IncomingMessage is enough here and reply method may be removed (see the doc-string)","commit_id":"e578a6ee37b93f83566f5aecaf9f733f9ca3acc2"}],"oslo_messaging/_drivers/zmq_driver/server/consumers/zmq_sub_consumer.py":[{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"ae259c7ab9b580f1ee5f54018d4f06aeddf056b8","unresolved":false,"context_lines":[{"line_number":32,"context_line":"zmq \u003d zmq_async.import_zmq()"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class SubIncomingMessage(base.RpcIncomingMessage):"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def __init__(self, listener, request, socket, poller):"},{"line_number":38,"context_line":"        super(SubIncomingMessage, self).__init__("}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_3212d263","line":35,"updated":"2016-02-03 14:43:06.000000000","message":"base.IncomingMessage is enough here and reply method may be removed (see the doc-string)","commit_id":"e578a6ee37b93f83566f5aecaf9f733f9ca3acc2"}],"oslo_messaging/_drivers/zmq_driver/server/zmq_server.py":[{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"ae259c7ab9b580f1ee5f54018d4f06aeddf056b8","unresolved":false,"context_lines":[{"line_number":31,"context_line":"class ZmqServer(base.Listener):"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def __init__(self, driver, conf, matchmaker\u003dNone):"},{"line_number":34,"context_line":"        super(ZmqServer, self).__init__(-1)"},{"line_number":35,"context_line":"        self.driver \u003d driver"},{"line_number":36,"context_line":"        self.conf \u003d conf"},{"line_number":37,"context_line":"        self.matchmaker \u003d matchmaker"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_1d948789","line":34,"updated":"2016-02-03 14:43:06.000000000","message":"Here may be no value if make prefetch default in the base class.","commit_id":"e578a6ee37b93f83566f5aecaf9f733f9ca3acc2"}]}